Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7.2.1 proposal #10127

Merged
merged 195 commits into from
Dec 6, 2016
Merged

v7.2.1 proposal #10127

merged 195 commits into from
Dec 6, 2016

Conversation

Fishrock123
Copy link
Member

@Fishrock123 Fishrock123 commented Dec 5, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Description of change

Notable Changes coming soon, highlights are the async_wrap GC fix, etc. Decided to do a patch because there's really only one (of 3) significant minor changes. ¯\_(ツ)_/¯

Aiming for tomorrow (Tuesday Dec 5).

Commit list within the fold.
  • [5379b9da11] - async_wrap: call destroy() callback in uv_idle_t (Trevor Norris) #9753
  • [5157a5cee9] - async_wrap: make Initialize a static class member (Trevor Norris) #9753
  • [3e5be7fc8b] - async_wrap: mode constructor/destructor to .cc (Trevor Norris) #9753
  • [88464ac6ac] - benchmark: reformat code for clarity (Rich Trott) #9790
  • [0c745e3a3a] - buffer: convert offset & length to int properly (Sakthipriyan Vairamani (thefourtheye)) #9815
  • [e0e62d1113] - Revert "buffer: runtime deprecation of calling Buffer without new" (Anna Henningsen) #9529
  • [371090d817] - build: Make configure file parseable on python3 (kalrover) #9657
  • [16af467146] - build: add shared library support to AIX build (Stewart Addison) #9675
  • [5c9aa18484] - constants: errors -> errno (Bryan English) #9349
  • [ac8d212428] - debugger: refactor _debugger.js (Rich Trott) #9860
  • [4bcda633c0] - deps: upgrade npm to 3.10.10 (Rebecca Turner) #9847
  • [03b1c314cd] - deps: cherry-pick 08377af from v8 upstream (Franziska Hinkelmann) #9730
  • [e9c2ffd20c] - deps: backport GYP fix to fix AIX shared suffix (Stewart Addison)
  • [346204d77e] - doc: add link to net.Server in tls.md (Devon Rifkin) #10109
  • [c4fbdfa785] - doc: fix typo for decipher.final. (iamchenxin) #10086
  • [d226418b87] - doc: suggest Buffer.alloc instead of Buffer#fill (Teddy Katz) #10000
  • [78e188d929] - doc: clarify fs.createReadStream options (Wes Tyler) #10078
  • [cdec174d4d] - doc: var => const in js code examples of addons.md (Vse Mozhet Byt) #10092
  • [13eea40d6f] - doc: rename writing_tests.md to writing-tests.md (Safia Abdalla) #9867
  • [c948d9051b] - doc: it’s -> its in api/child_process.md (Devon Rifkin) #10090
  • [f6c1f24068] - doc: update Collaborators list in README (Rich Trott) #9846
  • [a0e25b2544] - doc: remove minor contradiction in debugger doc (Rich Trott) #9832
  • [8c70f79249] - doc: clarify introductory module material (Rich Trott) #9816
  • [2e22fa043d] - doc: improve description of module exports (Sam Roberts) #9622
  • [6ab920a3fc] - doc: add guide for maintaining V8 (Ali Ijaz Sheikh) #9777
  • [4fa84c9589] - doc: fix crypto Verify cut-n-paste from Sign (子丶言) #9796
  • [6297b9afc5] - doc: minor fixes event-loop-timers-and-nexttick.md (Dan Koster) #9126
  • [a8d84d5b50] - doc: changed order of invocations in https.request() example. (atrioom) #9614
  • [c7cd400fcb] - doc: fix crypto "decipher.setAAD()" typo (子丶言) #9782
  • [77e145a00e] - doc: clarify slashes-appending in url module (Rich Trott) #9731
  • [65af114267] - doc: "util" is not needed to extend ES6 classes (Adam Brunner) #9737
  • [44ae0283af] - doc: fix inside stability boxes (Roman Reiss) #9723
  • [9554a974d1] - https: name anonymous functions in https (Pedro Lima) #9217
  • [80a3934cd7] - inspector: /json/version returns object, not array (Ben Noordhuis) #9762
  • [65cda7f265] - lib: use === in _http_server and _tls_wrap (Walter Beller-Morales) #9849
  • [a673d44d68] - lib,tools: remove unneeded escaping of / (Prince J Wesley) #9591
  • [3253954e62] - meta: whitelist dotfiles in .gitignore (Claudio Rodriguez) #8016
  • [6087e361e5] - repl: preprocess only for defaultEval (Prince J Wesley) #9752
  • [9099664959] - repl: fix generator function preprocessing (Teddy Katz) #9852
  • [5a2b68896c] - test: updated test-stream-pipe-unpipe-stream (Raja Panidepu) #10100
  • [f900753eeb] - test: refactor test-crypto-ecb (michael6) #10029
  • [6502427761] - test: refactor test-require-exceptions (Oscar Martinez) #9882
  • [a801ffb1ee] - test: refactor test-console (Matt Crummey) #9873
  • [bca587bdb3] - test: refactor test-crypto-certificate (Josh Mays) #9911
  • [278772a5df] - test: refactor dgram-send-multi-buffer-copy (Konstantin Likhter) #9909
  • [6d5ded508e] - test: refactor test-domain (Johnny Reading) #9890
  • [318a2dbea4] - test: refactor test-cli-syntax (Exlipse7) #10057
  • [da8e3d946a] - test: refactor test-child-process-constructor (k3kathy) #10060
  • [9fddf29f53] - test: refactor test-repl-mode.js (Cesar Hernandez) #10061
  • [65c44830c2] - test: var to const, assert.equal to assert.strictEqual in net (Sean Villars) #9907
  • [ef7cbde0a2] - test: changed vars to const in test-net-better-error-messages-listen-path.js (anoff) #9905
  • [f62567b7f8] - test: use const instead of var in test-require-json.js (Sarah Meyer) #9904
  • [5f3f54d4bb] - test: refactor test-http-dns-error (Outsider) #10062
  • [ae2bf0a761] - test: Changed assert.equal to assert.strictEqual (Daniel Pittman) #9902
  • [1eb581779d] - test: refactor test-vm-syntax-error-stderr.js (Jay Brownlee) #9900
  • [c456ca3601] - test: refactor test-tls-destroy-whilst-write (Chris Bystrek) #10064
  • [fd17ca7710] - test: refactor test-net-dns-custom-lookup (Kent.Fan) #10071
  • [cf3c635dba] - test: refactor test-https-truncate (davidmarkclements) #10074
  • [14c0388945] - test: refactor test-tls-server-verify (Hutson Betts) #10076
  • [36b8dd3b07] - test: refactor test-crypto-padding.js (Konstantin Likhter) #9971
  • [38ec8e44fa] - test: improve test for crypto padding (Julian Duque) #9906
  • [a771f2181c] - test: use strictEqual in test-cli-eval-event.js (Richard Karmazin) #9964
  • [e1394eeb16] - test: refactor test-tls-friendly-error-message.js (Adrian Estrada) #9967
  • [69077a13bf] - test: refactor test-fs-append-file.js (adelmann) #10110
  • [baa1accdb1] - test: assert.equal -> assert.strictEqual (davidmarkclements) #10065
  • [a34e19532c] - test: refactor test-dgram-exclusive-implicit-bind (Cesar Hernandez) #10066
  • [d87926ae34] - test: assert.equal -> assert.strictEqual (davidmarkclements) #10067
  • [c4902e44ad] - test: polish test-net-better-error-messages-listen (Hitesh Kanwathirtha) #10087
  • [9b9fe8c5ac] - test: change var to const in test-tls-key-mismatch.js (bjdelro) #9897
  • [7697aee7da] - test: use strictEqual in cwd-enoent (JDHarmon) #10077
  • [cdc2909882] - test: refactor test-fs-read-stream-inherit.js (Jonathan Darling) #9894
  • [55b58baed1] - test: use assert.strictEqual in test-crypto-ecb (Daniel Pittman) #9980
  • [e070588a8a] - test: refactor test-child-process-stdio-inherit (Wes Tyler) #9893
  • [22b15f2ab6] - test: change var to const for require and strict equality checks (Harish Tejwani) #9892
  • [2a8d29339d] - test: Update to const and use regex for assertions (Daniel Flores) #9891
  • [295eb5a3b6] - test: swap var->const/let and equal->strictEqual (Peter Masucci) #9888
  • [57f060c495] - test: replace equal with strictEqual in crypto (Julian Duque) #9886
  • [3d35930b2c] - test: replace equal with strictEqual (Julian Duque) #9879
  • [13cc6a005b] - test: var to const/let in test-tls-set-ciphers (rajatk) #9877
  • [f3eb8b1bea] - test: refactor test-tls-timeout-server-2 (Devon Rifkin) #9876
  • [dc76a20474] - test: Updating vars to const and tsl server test (Matt Webb) #9874
  • [63fafb8aca] - test: refactor test-crypto-hash-stream-pipe (Matt Wilson) #10055
  • [fb4b650159] - test: crypto-hash-stream-pipe use strict equal (Mitchell Stoutin) #9935
  • [8f550df252] - test: refactor child-process-spawn-error (Johnny Reading) #9951
  • [b73f6b760f] - test: refactor test-child-process-spawn-error (stokingerl) #9937
  • [371ca03568] - test: refactor test-vm-static-this.js (David Bradford) #9887
  • [3e37673d5c] - test: refactor test-crypto-cipheriv-decipheriv (Aileen) #10018
  • [f76bb2adf8] - test: refactor test for crypto cipher/decipher iv (Julian Duque) #9943
  • [4cc813d8b9] - test: refactor test-cluster-setup-master-argv (Oscar Martinez) #9960
  • [eb0c1cd412] - test: refactor test-cluster-setup-master-argv (Christine Hong) #9993
  • [d2e89272d2] - test: refactor test-fs-append-file-sync (Chris Bystrek) #10056
  • [070370fd0a] - test: refactor test-fs-append-file-sync (Ian White) #9977
  • [87038bb628] - test: refactor test-fs-write-file (adelmann) #10030
  • [1f6f411234] - test: refactor test/parallel/test-fs-write-file.js (Kyle Carter) #9992
  • [4cb52ee827] - test: update to const iin cluster test (Greg Valdez) #10007
  • [f9d79ef597] - test: use assert.strictEqual() cluster test (Bidur Adhikari) #10042
  • [b4ec7d6c50] - test: use const in test-crypto-pbkdf2 (Greg Valdez) #9974
  • [2e889cf056] - test: improve test for crypto pbkdf2 (joyeecheung) #9883
  • [c0a28622ce] - test: var -> let/const, .equal -> .strictEqual (shiya) #9913
  • [d1da89906d] - test: increase coverage for timers (lrlna) #10068
  • [44d9bc8b90] - test: change equal to strictEqual (Kevin Zurawel) #9872
  • [0cab6eb6ca] - test: test for http.request() invalid method error (Ashton Kinslow) #10080
  • [f9386f2846] - test: update net-local-address-port (scalkpdev) #9885
  • [66554c75d5] - test: refactor test-tls-ecdh (Adriana Rios) #9878
  • [a857c9a74c] - test: refactor test-vm-debug-context (makenova) #9875
  • [a6377a96dd] - test: increase coverage for lib/events.js (Safia Abdalla) #9865
  • [eb369f6d48] - test: use strictEqual in test-zlib-truncated (ben_cripps) #9858
  • [3af4ef4642] - test: use strictEqual in test-debugger-client.js (ben_cripps) #9857
  • [5c15a68091] - test: refactor test-debug-args (Rich Trott) #9833
  • [0e36becd39] - test: refactor test-fs-non-number-arguments-throw (Michaël Zasso) #9844
  • [c286312ef5] - test: replace assert.equal with assert.strictEqual (brad-decker) #9842
  • [0ccb2c3992] - test: refactor test-crypto-timing-safe-equal (Michaël Zasso) #9843
  • [0bdd5ca0f7] - test: run cpplint on files in test/cctest (Ben Noordhuis) #9787
  • [956239124d] - test: add toASCII and toUnicode punycode tests (Claudio Rodriguez) #9741
  • [70633f965d] - test: refactor test-util-inspect (Rich Trott) #9804
  • [4c2ad8c89f] - test: refactor test-preload (Rich Trott) #9803
  • [59aec82f88] - test: refine test-http-status-reason-invalid-chars (Rich Trott) #9802
  • [c35bf44f60] - test: refactor test-crypto-binary-default (Michaël Zasso) #9810
  • [4d1e11243b] - test: refactor and fix test-crypto (Michaël Zasso) #9807
  • [74c3283cfa] - test: fix test-buffer-slow (Michaël Zasso) #9809
  • [e2db5c8e7a] - test: refactor test-net-pingpong (Michaël Zasso) #9812
  • [cd10e1ae4a] - test: refactor and fix test-dns (Michaël Zasso) #9811
  • [dcba25082f] - test: refactor and fix test-buffer-bytelength (Michaël Zasso) #9808
  • [d06f010482] - test: cleanup test-dgram-error-message-address (Michael Macherey) #8938
  • [3b193defb2] - test: fix flaky test-cluster-dgram-2 (Rich Trott) #9791
  • [3f1b068644] - test: refactor common.js (Rich Trott) #9732
  • [d31a41149d] - test: fix test-tls-connect-address-family (mkamakura) #9573
  • [d51c856f11] - test: fix test-http-status-reason-invalid-chars (Yosuke Saito) #9572
  • [b763a31af0] - test: refactor test-child-process-exec-error (Rich Trott) #9780
  • [2b7ecb5012] - test: exclude no_interleaved_stdio test for AIX (Michael Dawson) #9772
  • [4971c3bb79] - test: fix flaky test-dgram-empty-packet & friends (Rich Trott) #9724
  • [2fb825750d] - test: fix flaky test-inspector (Rich Trott) #9727
  • [fc13cc6a12] - test: refactor test-tls-hello-parser-failure (Rich Trott) #9715
  • [ea1c4e1212] - test,url: improve escaping in url.parse (joyeecheung) #10083
  • [64854f625b] - tools: add ESLint rule for assert.throws arguments (Michaël Zasso) #10089
  • [2ee3543e04] - tools: remove unneeded escaping in generate.js (Rich Trott) #9781
  • [53d175267c] - tools: Add no useless regex char class rule (Prince J Wesley) #9591
  • [561b1494bc] - tools: allow test.py to use full paths of tests (Francis Gulotta) #9694
  • [5ae549c3aa] - url: fix -Warray-bounds warning (Santiago Gimeno) #9751

Stewart Addison and others added 30 commits November 24, 2016 19:21
Required to support the shared library builds on AIX - this sets the
shared library suffix within GYP to .a instead of .so on AIX
My patch: https://codereview.chromium.org/2492233002/ was landed as
as part of this one which fixed some other (not required, but
included for completeness of the backport) changes:

Ref: https://codereview.chromium.org/2511733005/
Updates to build the shared library version of node on AIX. Adds the
same functionality to AIX that was added on Linux under this:

Ref: #6994

PR-URL: #9675
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Allow test.py to run tests with a 'tests/' prefix or a '.js' postfix

PR-URL: #9694
Fixes: #9684
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
The constructor and destructor shouldn't have been placed in the -inl.h
file from the beginning.

PR-URL: #9753
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
This is how it's done everywhere else in core. Make it follow suit.

PR-URL: #9753
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Calling JS during GC is a no-no. So intead create a queue of all ids
that need to have their destroy() callback called and call them later.

Removed checking destroy() in test-async-wrap-uid because destroy() can
be called after the 'exit' callback.

Missing a reliable test to reproduce the issue that caused the
FATAL_ERROR.

PR-URL: #9753
Fixes: #8216
Fixes: #9465
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Fixes: #9714
PR-URL: #9723
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
* setTimeout() with no duration -> setImmediate()
* add common.mustCall() where appropriate
* var -> const
* .on() -> .once()

PR-URL: #9715
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Using `socket.destroy()` instead of `socket.end()` fixes
more-than-intermittent ECONNRESET issues on Windows.

PR-URL: #9727
Fixes: #8804
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
PR-URL: #9737
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
The `/` character does not need to be escaped when occurring inside a
character class in a regular expression. Remove such instances of
escaping in the code base.

PR-URL: #9591
Reviewed-By: Teddy Katz <[email protected]>
Eslint Rule:
Disallow useless escape in regex character class
with optional override characters option and auto
fixable with eslint --fix option.

Usage:
no-useless-regex-char-class-escape: [2, { override: ['[', ']'] }]

PR-URL: #9591
Reviewed-By: Teddy Katz <[email protected]>
PR-URL: #9782
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
When you call req.end() before you add .on listeners you get an Error that you can't call .on on undefined.

PR-URL: #9614
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Minor fixes and enhancements to event-loop-timers-and-nexttick.md
Added missing "be"
Added a link to REPL docs
Added definition of libuv and a link

PR-URL: #9126
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
* Liberal use of common.mustCall()
* Rename test-dgram-empty-packet -> test-dgram-send-empty-packet
* Remove use of timers to avoid CI failures like seen in the Ref below:

```
not ok 237 parallel/test-dgram-empty-packet
  ---
  duration_ms: 0.717
  severity: fail
  stack: |-
        ...
        throw new Error('Timeout');
        ^

    Error: Timeout
        at Timeout._onTimeout
        ...
        at ontimeout (timers.js:365:14)
        at tryOnTimeout (timers.js:237:5)
        at Timer.listOnTimeout (timers.js:207:5)
```

Refs: https://ci.nodejs.org/job/node-test-commit-freebsd/5341/nodes=freebsd11-x64/console:
PR-URL: #9724
Reviewed-By: Santiago Gimeno <[email protected]>
pseudo-tty/no_interleaved_stdio has hung a few times
in the last couple of days on AIX.  We believe
it is not a Node.js issue but an issue with python
on AIX. Its being investigated under:
#7973.
Excluding this additional test until we can
resolve the python issue.

Fixes #9765
PR-URL: #9772
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Make /json/version return an object instead of an object wrapped in an
array.

Fixes: #9760
PR-URL: #9762
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Verify documentation had cut-n-pasted documentation from Sign.

PR-URL: #9796
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Prince John Wesley <[email protected]>
Naming anonymous function in the https module

PR-URL: #9217
Ref: #8913
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
* assert.equal() -> assert.strictEqual()
* regex -> .include()
* Change variable representing a function from `fun` to idiomatic `fn`
* var -> const

PR-URL: #9780
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Prince John Wesley <[email protected]>
`-` does not need to be escaped in a regular expression outside of
character classes.

PR-URL: #9781
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Use port 0 instead of common.PORT, and use server address
instead of localhost to follow writing test guideline.
This is a part of Code And Learn at NodeFest 2016 Challenge in Tokyo.

PR-URL: #9572
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Use port 0 instead of common.PORT.

PR-URL: #9573
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Some of the benchmark code can be a little dense. Not *very* hard to
read but perhaps harder than it needs to be.

These changes (many of them whitespace-only) hopefully improve
readability.

There are also a few cases of `assert.equal()` that are changed to
`assert.strictEqual()`.

PR-URL: #9790
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
* remove unused common.faketimeCli
* remove mosly-unused common.testDir
* assert.ok(false...) -> fail()
* alphabetize list of known globals
* .indexOf() -> .includes()

PR-URL: #9732
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
There is no guarantee that a dgram packet will be received. The test is
currently written to only send exactly as many dgram packets as required
assuming they are all received. As a result, failures like this may
occur (from CI):

```
not ok 719 parallel/test-cluster-dgram-2
  ---
  duration_ms: 120.39
  severity: fail
  stack: |-
    timeout
```

This change has the workers send packets continuously until disconnect.

PR-URL: #9791
Reviewed-By: Santiago Gimeno <[email protected]>
* var -> const
* assert.equal() -> assert.strictEqual()
* assert.notEqual() -> assert.notStrictEqual()

Fixes: #8925
PR-URL: #8938
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
This reverts commit f2fe558
(#8169) as the original
justification for the runtime-deprecation does not appear
to justify the disruption to Node’s existing ecosystem.
Futhermore, the possibility of deprecating the Buffer constructor
entirely in v8.0 might lead to people having to change their code twice.

PR-URL: #9529
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Nikolai Vavilov <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
mark hughes and others added 16 commits December 6, 2016 13:51
* var -> const
* assert.equal() -> assert.strictEqual()

PR-URL: #9920
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
refactor var -> const/let
refactor process.on('exit') into common.mustCall

PR-URL: #9934
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #9919
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Changed equal to strictEqual

PR-URL: #9982
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Changed var to const and equal to strictEqual

PR-URL: #9982
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This improves the heuristic used in multiline-prompt mode to determine
whether a given slash character is at the beginning of a regular
expression.

PR-URL: #10103
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Fixes: #9300
Replace assert.equal() with assert.strictEqual().

PR-URL: #9963
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
test-dgram-send-callback-recursive.js

PR-URL: #9973
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
* changed vars to const
* changed assert.equal to assert.strictEqual
* added a common.mustCall in the childProcess.exec callback
* replaced 2 console.log strings with template strings for readability
* had to break up line 9 because it was causing a line max length (80)
listing err

PR-URL: #9939
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #9940
Reviewed-By: James M Snell <[email protected]>
Changes assert.equal to assert.strictEqual in
two places and adds a second argument of 0
to setTimeout

PR-URL: #9957
Reviewed-By: James M Snell <[email protected]>
refactor all var to either const/let
change all assert.equal to assert.strictEqual
change all assert.ok(...===...) to assert.strictEqual

PR-URL: #9970
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
* var => const
* assert test fixtures

PR-URL: #9912
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
changed equal to strictEqual in parallel/test-crypto-hash.js.
Added a second regex argument to the assert.throws function.

PR-URL: #10009
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
COLLABORATOR_GUIDE.md and onboarding.md cover some of the same
information. The aim of this commit is to remove duplicated
information.

PR-URL: #9635
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
@silverwind
Copy link
Contributor

silverwind commented Dec 6, 2016

Sorry for the tag in the commit message. I think the changelog-maker should escape things like < or > from commit messages. Filed nodejs/changelog-maker#43.

Notable changes:

* buffer:
  - Reverted the runtime deprecation of calling `Buffer()` without
`new`. (Anna Henningsen) #9529
  - Fixed `buffer.transcode()` for single-byte character
encodings to `UCS2`. (Anna Henningsen)
#9838
* promise: `--trace-warnings` now produces useful stacktraces for
Promise warnings. (Anna Henningsen)
#9525
* repl: Fixed a bug preventing correct parsing of generator functions.
(Teddy Katz) #9852
* V8: Fixed a significant `instanceof` performance regression.
(Franziska Hinkelmann) #9730
@Fishrock123
Copy link
Member Author

@Fishrock123
Copy link
Member Author

@Fishrock123
Copy link
Member Author

re-running CI on windows: https://ci.nodejs.org/job/node-test-commit-windows-fanned/5736/

@Fishrock123
Copy link
Member Author

Building @ https://ci-release.nodejs.org/job/iojs+release/1387/

@Fishrock123 Fishrock123 merged commit c2cc11b into v7.x Dec 6, 2016
Fishrock123 added a commit that referenced this pull request Dec 6, 2016
Notable changes:

* buffer:
  - Reverted the runtime deprecation of calling `Buffer()` without
`new`. (Anna Henningsen) #9529
  - Fixed `buffer.transcode()` for single-byte character
encodings to `UCS2`. (Anna Henningsen)
#9838
* promise: `--trace-warnings` now produces useful stacktraces for
Promise warnings. (Anna Henningsen)
#9525
* repl: Fixed a bug preventing correct parsing of generator functions.
(Teddy Katz) #9852
* V8: Fixed a significant `instanceof` performance regression.
(Franziska Hinkelmann) #9730

PR-URL: #10127
Fishrock123 added a commit to nodejs/nodejs.org that referenced this pull request Dec 6, 2016
@Fishrock123 Fishrock123 deleted the v7.2.1-proposal branch December 6, 2016 23:11
@italoacasas italoacasas mentioned this pull request Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet