-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
var to const/let change #10029
var to const/let change #10029
Conversation
@michael6 May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look ok but commit message needs to follow guidelines as suggested. Specifically, starting with "test:' in this case.
hex += encrypt.final('hex'); | ||
assert.equal(hex.toUpperCase(), '6D385F424AAB0CFBF0BB86E07FFB7D71'); | ||
assert.strictequal(hex.toUpperCase(), '6D385F424AAB0CFBF0BB86E07FFB7D71'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be strictEqual
@@ -10,24 +10,24 @@ if (common.hasFipsCrypto) { | |||
common.skip('BF-ECB is not FIPS 140-2 compatible'); | |||
return; | |||
} | |||
var crypto = require('crypto'); | |||
let crypto = require('crypto'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const
should work here
}()); | ||
|
||
(function() { | ||
var decrypt = crypto.createDecipheriv('BF-ECB', 'SomeRandomBlahz0c5GZVnR', | ||
let decrypt = crypto.createDecipheriv('BF-ECB', 'SomeRandomBlahz0c5GZVnR', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would seem that const
would be fine for this one too.
* var -> const/let * IIFE to blocks PR-URL: nodejs#10029 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Landed in 11b3462. |
* var -> const/let * IIFE to blocks PR-URL: #10029 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
* var -> const/let * IIFE to blocks PR-URL: nodejs#10029 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
* var -> const/let * IIFE to blocks PR-URL: nodejs#10029 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
* var -> const/let * IIFE to blocks PR-URL: #10029 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
* var -> const/let * IIFE to blocks PR-URL: #10029 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
* var -> const/let * IIFE to blocks PR-URL: #10029 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
change var to const/let and equal to strictEqual.
Checklist
make -j8 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
test
Description of change