Skip to content

Commit

Permalink
test: replace assert.equal with assert.strictEqual
Browse files Browse the repository at this point in the history
Using NodeTodo I learned of a need to swap out the .equal function
with .strictEqual in a few test files.

https://twitter.com/NodeTodo/status/803657321993961472
https://gist.github.com/Trott/864401455d4afa2428cd4814e072bd7c

additional commits squashed:
.strictEqual's argument signature is actual, expected, [message].
Previously some statements were listed as expected, actual.
As asked in PR i swapped them to match the correct argument signature.

PR-URL: #9842
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
  • Loading branch information
brad-decker authored and addaleax committed Dec 5, 2016
1 parent 0ccb2c3 commit c286312
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions test/addons/async-hello-world/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ var assert = require('assert');
const binding = require(`./build/${common.buildType}/binding`);

binding(5, common.mustCall(function(err, val) {
assert.equal(null, err);
assert.equal(10, val);
assert.strictEqual(err, null);
assert.strictEqual(val, 10);
process.nextTick(common.mustCall(function() {}));
}));
2 changes: 1 addition & 1 deletion test/addons/hello-world-function-export/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
const common = require('../../common');
var assert = require('assert');
const binding = require(`./build/${common.buildType}/binding`);
assert.equal('world', binding());
assert.strictEqual(binding(), 'world');
console.log('binding.hello() =', binding());
2 changes: 1 addition & 1 deletion test/addons/hello-world/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
const common = require('../../common');
var assert = require('assert');
const binding = require(`./build/${common.buildType}/binding`);
assert.equal('world', binding.hello());
assert.strictEqual(binding.hello(), 'world');
console.log('binding.hello() =', binding.hello());
2 changes: 1 addition & 1 deletion test/addons/load-long-path/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ fs.writeFileSync(addonDestinationPath, contents);
// Attempt to load at long path destination
var addon = require(addonDestinationPath);
assert.notEqual(addon, null);
assert.equal(addon.hello(), 'world');
assert.strictEqual(addon.hello(), 'world');
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ if (!binding.ensureAllocation(2 * kStringMaxLength)) {
}

const maxString = buf.toString('latin1');
assert.equal(maxString.length, kStringMaxLength);
assert.strictEqual(maxString.length, kStringMaxLength);
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ assert.throws(function() {
}, /"toString\(\)" failed/);

var maxString = buf.toString('latin1', 1);
assert.equal(maxString.length, kStringMaxLength);
assert.strictEqual(maxString.length, kStringMaxLength);
// Free the memory early instead of at the end of the next assignment
maxString = undefined;

maxString = buf.toString('latin1', 0, kStringMaxLength);
assert.equal(maxString.length, kStringMaxLength);
assert.strictEqual(maxString.length, kStringMaxLength);
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ if (!binding.ensureAllocation(2 * kStringMaxLength)) {
}

const maxString = buf.toString('utf16le');
assert.equal(maxString.length, (kStringMaxLength + 2) / 2);
assert.strictEqual(maxString.length, (kStringMaxLength + 2) / 2);

0 comments on commit c286312

Please sign in to comment.