-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix crypto "Verify" typo #9796
fix crypto "Verify" typo #9796
Conversation
fix crypto "Verify" typo I am currently translating doc into Chinese, but I found this problem in the translation process.
@@ -935,8 +935,8 @@ of two ways: | |||
- Using the [`verify.update()`][] and [`verify.verify()`][] methods to verify | |||
the signature. | |||
|
|||
The [`crypto.createSign()`][] method is used to create `Sign` instances. | |||
`Sign` objects are not to be created directly using the `new` keyword. | |||
The [`crypto.createVerify()`][] method is used to create `Verify` instances. `Verify` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try to wrap lines at 80 columns? Thank you :)
I'm sorry, I did not realize this before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message should start with
"doc: "
ie:
doc: fix crypto "Verify" typo
Otherwise LGTM once thats fixedup.
I can squash and rewrite the commit message when I land this, or @Amery2010 can do it, but I'm supposed to wait two working days, which means not merging until Monday :-(. Maybe there is a dispensation for such trivially correct improvements, such as this one? |
@sam-github I saw some trivial changes like typos being landed without waiting the 48/72 hours. |
Landed in 630c63e |
Verify documentation had cut-n-pasted documentation from Sign. PR-URL: #9796 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Prince John Wesley <[email protected]>
@Amery2010 I rewrote your commit message. Please take a look, I'm sure you will need to PR more improvements to docs if you are translating, because you will see many errors. |
Agreed that fixing in commit message is ok, but important @Amery2010 is aware for the next time. |
Verify documentation had cut-n-pasted documentation from Sign. PR-URL: #9796 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Prince John Wesley <[email protected]>
Verify documentation had cut-n-pasted documentation from Sign. PR-URL: #9796 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Prince John Wesley <[email protected]>
Verify documentation had cut-n-pasted documentation from Sign. PR-URL: #9796 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Prince John Wesley <[email protected]>
Verify documentation had cut-n-pasted documentation from Sign. PR-URL: #9796 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Prince John Wesley <[email protected]>
Verify documentation had cut-n-pasted documentation from Sign. PR-URL: #9796 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Prince John Wesley <[email protected]>
Checklist
make -j8 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
Description of change
fix crypto "Verify" typo
I am currently translating doc into Chinese, but I found this problem in the translation process.