-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: use strictEqual instead of equal in test-domain #9890
Conversation
The commit message needs to have the appropriate subsystem prefix, in this case it's |
@mscdex Fixed. Thanks! |
CI was a bit too flaky. Running again: https://ci.nodejs.org/job/node-test-pull-request/5182/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI is green. thank you for the PR and for participating in the code-and-learn!
Use assert.strictEqual() instead of assert.equal(). PR-URL: nodejs#9890 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Landed in c8da009. |
Use assert.strictEqual() instead of assert.equal(). PR-URL: #9890 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Use assert.strictEqual() instead of assert.equal(). PR-URL: nodejs#9890 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Use assert.strictEqual() instead of assert.equal(). PR-URL: nodejs#9890 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Use assert.strictEqual() instead of assert.equal(). PR-URL: #9890 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Use assert.strictEqual() instead of assert.equal(). PR-URL: #9890 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Use assert.strictEqual() instead of assert.equal(). PR-URL: #9890 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Checklist
make -j8 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
Description of change