Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: updated to const and strictEqual #9974

Closed
wants to merge 1 commit into from

Conversation

ghvaldez
Copy link
Contributor

@ghvaldez ghvaldez commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

Tests

Description of change

Upadted all var to const/let and updated assert.equal to
assert.strictEqual

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex mscdex added the crypto Issues and PRs related to the crypto subsystem. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@mscdex
Copy link
Contributor

mscdex commented Dec 1, 2016

tests: should be test: in the commit message.

Upadted all var to const/let and updated assert.equal to
assert.strictEqual
@ghvaldez
Copy link
Contributor Author

ghvaldez commented Dec 1, 2016

@mscdex updated commit message

@Trott
Copy link
Member

Trott commented Dec 4, 2016

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 4, 2016
Updated all remaining var to const

PR-URL: nodejs#9974
Reviewed-By: Rich Trott <[email protected]>
@Trott
Copy link
Member

Trott commented Dec 4, 2016

Landed in 7837866. Thanks for the contribution! 🎉

@Trott Trott closed this Dec 4, 2016
addaleax pushed a commit that referenced this pull request Dec 5, 2016
Updated all remaining var to const

PR-URL: #9974
Reviewed-By: Rich Trott <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
Updated all remaining var to const

PR-URL: nodejs#9974
Reviewed-By: Rich Trott <[email protected]>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
Updated all remaining var to const

PR-URL: nodejs#9974
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Updated all remaining var to const

PR-URL: #9974
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants