test: add toASCII and toUnicode punycode tests #9741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
approved these changes
Nov 22, 2016
lpinca
reviewed
Nov 22, 2016
| { | ||
| string: 'ليهمابتكلموشعربي؟', | ||
| encoded: 'egbpdaj6bu4bxfgehfvwxn', | ||
| decoded: '\u0644\u064A\u0647\u0645\u0627\u0628\u062A\u0643\u0644\u0645' + |
There was a problem hiding this comment.
Isn't decoded just a copy of string? If so can't we just use string and encoded?
There was a problem hiding this comment.
I guess we could. Why did the test use the \u codes?
There was a problem hiding this comment.
Yeah, maybe because that's how the sample strings are listed in the RFC?
There was a problem hiding this comment.
I agree that we can probably just remove them if they server no purpose.
There was a problem hiding this comment.
If that's how they appear in the RFC, I'd say maybe leave them just in case? It might also help in debugging, if the test ever starts failing, to have the bytecodes handy. We could just stick with decoded though
dongsik2026
reviewed
Nov 23, 2016
| '\uC5B4\uB97C\uC774\uD574\uD55C\uB2E4\uBA74\uC5BC\uB9C8\uB098\uC88B' + | ||
| '\uC744\uAE4C', | ||
| { | ||
| string: '세계의모든사람들이한국어를이해한다면얼마나좋을까', |
There was a problem hiding this comment.
I Guide this sentence like "세계의 모든 사람들이 한국어를 이해한다면 얼마나 좋을까"
claudiorodriguez
force-pushed
the
test-punycode-ascii-unicode
branch
from
7557cfc
to
4452fc0
Compare
|
I've removed the duplicitous New CI: https://ci.nodejs.org/job/node-test-pull-request/4961/ |
claudiorodriguez
force-pushed
the
test-punycode-ascii-unicode
branch
from
4452fc0
to
c660c24
Compare
lpinca
reviewed
Nov 23, 2016
| toASCII: (test) => assert.strictEqual( | ||
| punycode.toASCII(test.decoded), | ||
| regexNonASCII.test(test.decoded) | ||
| ? 'xn--' + test.encoded |
lpinca
approved these changes
Nov 23, 2016
- Add toUnicode and toASCII tests to test-punycode - Refactor test-punycode.js to better organize test cases - Change assert.equal to assert.strictEqual in test-punycode.js
claudiorodriguez
force-pushed
the
test-punycode-ascii-unicode
branch
from
c660c24
to
8beee2a
Compare
|
CI Failure seems unrelated |
|
I'll merge this tomorrow if there's no objections |
claudiorodriguez
added a commit
that referenced
this pull request
Nov 30, 2016
- Add toUnicode and toASCII tests to test-punycode - Refactor test-punycode.js to better organize test cases - Change assert.equal to assert.strictEqual in test-punycode.js PR-URL: #9741 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in c2f8487 |
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
- Add toUnicode and toASCII tests to test-punycode - Refactor test-punycode.js to better organize test cases - Change assert.equal to assert.strictEqual in test-punycode.js PR-URL: #9741 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
- Add toUnicode and toASCII tests to test-punycode - Refactor test-punycode.js to better organize test cases - Change assert.equal to assert.strictEqual in test-punycode.js PR-URL: nodejs#9741 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax
added
land-on-v6.x
punycode
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
- Add toUnicode and toASCII tests to test-punycode - Refactor test-punycode.js to better organize test cases - Change assert.equal to assert.strictEqual in test-punycode.js PR-URL: #9741 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
- Add toUnicode and toASCII tests to test-punycode - Refactor test-punycode.js to better organize test cases - Change assert.equal to assert.strictEqual in test-punycode.js PR-URL: #9741 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
- Add toUnicode and toASCII tests to test-punycode - Refactor test-punycode.js to better organize test cases - Change assert.equal to assert.strictEqual in test-punycode.js PR-URL: #9741 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change