repl: preprocess only for defaultEval #9752
Conversation
| }) | ||
| }; | ||
|
|
||
| const r = repl.start(options); | ||
| r.context = {foo: 'bar'}; | ||
|
|
||
| try { | ||
| r.write('foo\n'); | ||
| r.write('function f() {}\n'); |
There was a problem hiding this comment.
Can I suggest that you add a comment describing why this particular input was chosen?
| // Append a \n so that it will be either | ||
| // terminated, or continued onto the next expression if it's an | ||
| // unexpected end of input. | ||
| return `${cmd}\n`; |
There was a problem hiding this comment.
This appending of the \n isn't needed for custom eval functions?
Because it was being appended before.
There was a problem hiding this comment.
@nunocastromartins Good point. \n was appended for most of the cases and it was done in same preprocess. I'll add \n for all cases as if eval function receives what user entered including the final enter.
CC: @Fishrock123
|
Last CI wasn't so happy...? |
|
New CI: https://ci.nodejs.org/job/node-test-pull-request/4974/ |
|
@Fishrock123 CI is green 😄 |
|
@nodejs/collaborators I'll land this tomorrow if there is no objection. |
|
@addaleax review the changes made after your approval. |
|
@nodejs/collaborators ping |
Code preprocessing is applicable only for default eval function. Therefore, Moved `preprocess` function invocation inside `defaultEval` function. Fixes: nodejs#9743 PR-URL: nodejs#9752 Reviewed-By: Anna Henningsen <[email protected]>
princejwesley
force-pushed
the
repl.9743
branch
from
ed4179b
to
b345fab
Compare
|
Rebased, CI again: https://ci.nodejs.org/job/node-test-pull-request/5157/ |
Code preprocessing is applicable only for default eval function. Therefore, Moved `preprocess` function invocation inside `defaultEval` function. Fixes: #9743 PR-URL: #9752 Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in 9366b8 |
Code preprocessing is applicable only for default eval function. Therefore, Moved `preprocess` function invocation inside `defaultEval` function. Fixes: #9743 PR-URL: #9752 Reviewed-By: Anna Henningsen <[email protected]>
Code preprocessing is applicable only for default eval function. Therefore, Moved `preprocess` function invocation inside `defaultEval` function. Fixes: nodejs#9743 PR-URL: nodejs#9752 Reviewed-By: Anna Henningsen <[email protected]>
Code preprocessing is applicable only for default eval function. Therefore, Moved `preprocess` function invocation inside `defaultEval` function. Fixes: #9743 PR-URL: #9752 Reviewed-By: Anna Henningsen <[email protected]>
Code preprocessing is applicable only for default eval function. Therefore, Moved `preprocess` function invocation inside `defaultEval` function. Fixes: #9743 PR-URL: #9752 Reviewed-By: Anna Henningsen <[email protected]>
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
repl
Description of change
Code preprocessing is applicable only for default
eval function. Therefore, Moved
preprocessfunctioninvocation inside
defaultEvalfunction.Fixes: #9743