-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(app-testing): full phase 1 app analysis battery #12143
Conversation
* edge: (116 commits) feat(system-server): add sqlite database and barebones HTTP server (#12085) feat(ot3): add enableOT3FirmwareUpdates feature flag to gate firmware update functionality. (#12102) feat(app): add bare bones hardware section to protocol details (#12099) feat(app): Support failed calibrations in the calibration wizard (#12092) refactor(docs): clean up Versioning page (#12084) refactor(robot-server): Make run and protocol limits configurable at launch (#12094) feat(app): add robotServerVersion to display the current robot software version (#12096) fix(hardware): do not track tip motor positions (#12093) feat(engine): allow calibrateGripper command to save calibration data (#12046) feat(app, api-client, react-api-client): delete POC TLC calibration data from overflow menu (#12075) fix(api): actually update OT3 instrument calibration offset in cache instrument (#12089) fix(robot-server): correct the data returned from instruments endpoint (#12067) feat(api): add thermocycler plate lift to hardware controller (#12068) fix(app): reference moduleId from result not params (#12077) feat(app): create ODD protocol setup page (#12071) refactor(api): Deprecate presses and increment args when using PAPI pick_up_tip (#12079) fix(ot3): handle multiple responses for a tip action request (#12083) refactor(api): touch tip implementation for PAPIv2 engine core (#12053) refactor(app): Remove ssid parameter from OnDeviceRouteParams (#11930) fix(api): fix broken test in the api hardware controller (#12080) ...
* origin/edge: (31 commits) refactor(hardware): Update appropriate revision (#12130) fix(api): Fix accidental error on any PAPIv2.14 protocol (#12141) refactor(api): Allow homing after drop tip in engine core (#12124) fix(shared-data): remove newLocation and strategy from schemav6 (#12133) refactor(api): load pipette with useVirtualPipettes config option (#12117) chore(api): further speed up ot3controller tests and add profiling (#12132) docs(api): Settle in to leave Labware.default_magdeck_engage_height alone, for now (#12122) refactor(api): Improve error messages for JSONv6 and PAPIv2.14 protocols (#12131) refactor(robot-server): Note mistaken type in migration (#12126) chore(hardware): Remove docstring content checks (#12128) feat(hardware_control): Added firmware update mechanism for submodules (#12076) feat(app): remove feature flag for calibration dashboard and wizard updates (#12125) feat(app): Calibration dashboard wizard data invalidation (#12097) feat(hardware): support new revision values (#12111) feat(app): add Chip component (#12090) docs(api): Officially remove the `height` parameter of `MagneticModuleContext.engage()` (#12114) feat(system-server): add persistent UUID generation (#12123) feat(odd): add manual connection for a hidden network (#12033) feat(hardware): add progress output to subsystem firmware update process (#12059) refactor(api): Improve OT3 instrument calibration process (#11807) ...
Codecov Report
@@ Coverage Diff @@
## edge #12143 +/- ##
=======================================
Coverage 74.31% 74.31%
=======================================
Files 2159 2159
Lines 59571 59571
Branches 6093 6093
=======================================
+ Hits 44269 44270 +1
Misses 13939 13939
+ Partials 1363 1362 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Overview
All protocols selected by QA team now a part of the analysis battery against the app. Passing on edge.
Next phase is to add 2.14 protocols.
Risk assessment
None, test only against test code only.