Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ot3): add enableOT3FirmwareUpdates feature flag to gate firmware update functionality. #12102

Merged
merged 4 commits into from
Feb 6, 2023

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Feb 5, 2023

Overview

We are in the middle of developing firmware updates for the OT3 subsystems, we need to be able to work on these features without interfering with the regular system. So let's add a feature flag to gate this functionality.

Closes: RCORE-478

Test Plan

  • Make sure this causes no issues when enabled/disabled

Changelog

  • add enableOT3FirmwareUpdates feature flag

Review requests

Risk assessment

Low, OT3 work

@vegano1 vegano1 requested a review from a team as a code owner February 5, 2023 21:47
@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Merging #12102 (3693ee8) into edge (23c79aa) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 3693ee8 differs from pull request most recent head 1b52e5d. Consider uploading reports for the commit 1b52e5d to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #12102   +/-   ##
=======================================
  Coverage   74.28%   74.28%           
=======================================
  Files        2190     2190           
  Lines       60709    60709           
  Branches     6480     6480           
=======================================
  Hits        45097    45097           
  Misses      14081    14081           
  Partials     1531     1531           
Flag Coverage Δ
notify-server 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/src/opentrons/config/feature_flags.py 86.66% <ø> (ø)
api/src/opentrons/config/advanced_settings.py 93.81% <100.00%> (ø)

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once lint and so on passes

@vegano1 vegano1 requested a review from a team as a code owner February 6, 2023 18:35
@vegano1 vegano1 merged commit 10e73dc into edge Feb 6, 2023
@vegano1 vegano1 deleted the RCORE-478_fw_updates_feature_flag branch February 6, 2023 18:55
y3rsh added a commit that referenced this pull request Feb 7, 2023
* edge: (116 commits)
  feat(system-server): add sqlite database and barebones HTTP server (#12085)
  feat(ot3): add enableOT3FirmwareUpdates feature flag to gate firmware update functionality. (#12102)
  feat(app): add bare bones hardware section to protocol details (#12099)
  feat(app): Support failed calibrations in the calibration wizard (#12092)
  refactor(docs): clean up Versioning page (#12084)
  refactor(robot-server): Make run and protocol limits configurable at launch (#12094)
  feat(app): add robotServerVersion to display the current robot software version (#12096)
  fix(hardware): do not track tip motor positions (#12093)
  feat(engine): allow calibrateGripper command to save calibration data (#12046)
  feat(app, api-client, react-api-client): delete POC TLC calibration data from overflow menu (#12075)
  fix(api): actually update OT3 instrument calibration offset in cache instrument (#12089)
  fix(robot-server): correct the data returned from instruments endpoint (#12067)
  feat(api): add thermocycler plate lift to hardware controller (#12068)
  fix(app): reference moduleId from result not params (#12077)
  feat(app): create ODD protocol setup page (#12071)
  refactor(api): Deprecate presses and increment args when using PAPI pick_up_tip (#12079)
  fix(ot3): handle multiple responses for a tip action request (#12083)
  refactor(api): touch tip implementation for PAPIv2 engine core (#12053)
  refactor(app): Remove ssid parameter from OnDeviceRouteParams (#11930)
  fix(api): fix broken test in the api hardware controller (#12080)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants