-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hardware): add progress output to subsystem firmware update process #12059
feat(hardware): add progress output to subsystem firmware update process #12059
Conversation
We're going to track update progress and creating this class facilitates this.
Codecov Report
@@ Coverage Diff @@
## edge #12059 +/- ##
==========================================
+ Coverage 74.19% 74.76% +0.57%
==========================================
Files 2223 2176 -47
Lines 60956 59765 -1191
Branches 6514 6342 -172
==========================================
- Hits 45225 44684 -541
+ Misses 14201 13571 -630
+ Partials 1530 1510 -20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good, will need to adjust a bit to merge in with my work but not too bad. |
…iles to be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tested on machine!
* origin/edge: (31 commits) refactor(hardware): Update appropriate revision (#12130) fix(api): Fix accidental error on any PAPIv2.14 protocol (#12141) refactor(api): Allow homing after drop tip in engine core (#12124) fix(shared-data): remove newLocation and strategy from schemav6 (#12133) refactor(api): load pipette with useVirtualPipettes config option (#12117) chore(api): further speed up ot3controller tests and add profiling (#12132) docs(api): Settle in to leave Labware.default_magdeck_engage_height alone, for now (#12122) refactor(api): Improve error messages for JSONv6 and PAPIv2.14 protocols (#12131) refactor(robot-server): Note mistaken type in migration (#12126) chore(hardware): Remove docstring content checks (#12128) feat(hardware_control): Added firmware update mechanism for submodules (#12076) feat(app): remove feature flag for calibration dashboard and wizard updates (#12125) feat(app): Calibration dashboard wizard data invalidation (#12097) feat(hardware): support new revision values (#12111) feat(app): add Chip component (#12090) docs(api): Officially remove the `height` parameter of `MagneticModuleContext.engage()` (#12114) feat(system-server): add persistent UUID generation (#12123) feat(odd): add manual connection for a hidden network (#12033) feat(hardware): add progress output to subsystem firmware update process (#12059) refactor(api): Improve OT3 instrument calibration process (#11807) ...
Overview
Add progress reporting to robot microcontroller/subsystem firmware update process. Reporting takes the form (nodeid: (macro_status, micro_status)) for each nodeid being updated, where macro_status is one of (queued, updating, done) and micro_status is a float from 0 to 1 during the updating macro_status.
Test Plan
Changelog
Review requests
Risk assessment
Low. This builds off of the existing and proven updating process with proven software components.