feat(app): Support failed calibrations in the calibration wizard

[ewagoner]

Overview

This PR handles how the calibration wizard responds to various permutations of failed calibration health checks with the deck, pipette tip length, and pipette offset.

It closes RAUT-97, RAUT-108, and RAUT-112.

Test Plan

• Created taskList fixtures for all combinations of failures
• Wrote tests ensuring that real failures produce test plans that match the fixtures
• Wrote component tests to ensure correct warning UI was in place
• Manually went through calibration flow and intentionally introduced calibration failures to trigger the changes

Changelog

• Added test fixtures for all combinations of bad calibrations and tests that use them
• Add alert-circle icons to title and footer of bad tasklist items
• Add 'Calibration recommended' footers to markedBad tasklist fixtures
• Add 'Calibration recommended' footers to tasks marked bad and add tests for same
• Add optional markedBad flag to deckCalibrationData

Review requests

The three tickets spell out the following specific combinations of failures:

• TLC and POC is found to be bad after a calibration health check
• all calibrations are recommended except TLC
• all calibrations need to be re-done after a failed calibration health check

Risk assessment

The purpose of the work is to easily guide the user through recalibrating just the items that have failed their health checks. If I haven't properly pushed those failures through the task list component and thus in to the wizard, the user will not know about those failures and will have to work harder than they should to correct them.

I am not pushing failure flags to other parts of the system, so the rest of the code should be rather isolated from the changes I have made here.

[codecov]

Codecov Report

Merging #12092 (761bf88) into edge (27a1e2a) will increase coverage by 0.07%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##             edge   #12092      +/-   ##
==========================================
+ Coverage   73.97%   74.04%   +0.07%     
==========================================
  Files        2198     2198              
  Lines       60912    61003      +91     
  Branches     6477     6512      +35     
==========================================
+ Hits        45058    45169     +111     
+ Misses      14317    14293      -24     
- Partials     1537     1541       +4     

Flag	Coverage Δ
app	72.72% <93.33%> (+0.30%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../organisms/Devices/hooks/useCalibrationTaskList.ts	94.49% <90.90%> (-0.70%)	⬇️
.../organisms/Devices/hooks/useDeckCalibrationData.ts	90.90% <100.00%> (+0.90%)	⬆️
app/src/organisms/TaskList/index.tsx	90.62% <100.00%> (+37.39%)	⬆️
...c/pages/OnDeviceDisplay/RobotSettingsDashboard.tsx	64.28% <0.00%> (-10.72%)	⬇️
...isms/Devices/HistoricalProtocolRunOverflowMenu.tsx	90.16% <0.00%> (+5.16%)	⬆️
...ngsCalibration/CalibrationDetails/OverflowMenu.tsx	84.12% <0.00%> (+8.41%)	⬆️
app/src/organisms/CalibrationTaskList/index.tsx	91.66% <0.00%> (+16.66%)	⬆️

[ewagoner]

Images for RAUT-108

[ewagoner]

Images for RAUT-97

[ewagoner]

Images for RAUT-112

[jgbowser]

This LGTM, I'd wait for a +1 from @b-cooper or another set of eyes though

[b-cooper]

It looks like the screenshots here include more warning icons than the designs. Specifically the icons that appear in your screenshots to the left of the sub task headers. The designs don't include those as seen below:

In addition, your screenshots include a "Calibration Recommended" with icon under the body of the "Deck Calibration" task. In the designs, those are only present on subtasks.

I've circled the two callouts in your screenshots below:

Other than the extra visuals the logic looks sound here!

[ewagoner]

D'oh! You're absolutely right. I'll fix both right quick.

[ewagoner]

Corrections:

[jgbowser]

whoops, yeah good catch Brian. Now it really LGTM