feat(app): create ODD protocol setup page #12071
Conversation
creates the ProtocolSetup page that shows basic protocol information, hosts specific setup screens (e.g. Modules), and can play/cancel a run. re RCORE-486
Codecov Report
@@ Coverage Diff @@
## edge #12071 +/- ##
==========================================
- Coverage 73.99% 73.97% -0.03%
==========================================
Files 2197 2198 +1
Lines 60839 60912 +73
Branches 6456 6477 +21
==========================================
+ Hits 45017 45058 +41
- Misses 14300 14317 +17
- Partials 1522 1537 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
code lgtm! left comments about using colors from our ui constants since some of the colors will probably stay the same. might be worth just using em now so we wont have to come back and convert them later.
sweet to see this coming together, great work. its very motivating to me, i hope it is to you too!
| path: '/protocols/:protocolId/:runId/setup', | ||
| path: '/protocols/:runId/setup', |
| // TODO(bh, 2022-12-7): finish styling when designs finalized | ||
| export function BackButton(): JSX.Element { | ||
| export function BackButton({ | ||
| onClick, |
| ready: 'rgba(4, 170, 101, 0.2)', | ||
| 'not ready': '#FCF0D8', | ||
| general: '#E0E0E0', |
There was a problem hiding this comment.
this is fine for now until design gets finalized, but any reason some of these are both hex + rgba?
There was a problem hiding this comment.
just transcribing directly from figma. may have already changed
| > | ||
| {status !== 'general' ? ( | ||
| <Icon | ||
| color={status === 'ready' ? '#04AA65' : '#F09D20'} |
There was a problem hiding this comment.
these colors will almost certainly change, but we've got these colors as style constants (successEnabled, and warningEnabled) if u wanna use em
| return ( | ||
| <Btn | ||
| alignItems={ALIGN_CENTER} | ||
| border="2px solid #BF0000" |
There was a problem hiding this comment.
same deal here with errorEnabled
| onClick={onClose} | ||
| aria-label="close" | ||
| > | ||
| <Icon color="#BF0000" name="ot-close" size="2rem" /> |
There was a problem hiding this comment.
same deal here with errorEnabled
| return ( | ||
| <Btn | ||
| alignItems={ALIGN_CENTER} | ||
| backgroundColor={disabled ? '#8F8F8F' : '#006CFA'} |
There was a problem hiding this comment.
same thing here re: constants
| detail?: string | ||
| // second line of detail text | ||
| subDetail?: string |
There was a problem hiding this comment.
might be worth changing these to accept null so you don't have to fallback to undefined in your ternaries
|
|
||
| return ( | ||
| <> | ||
| {/* Protocol Setup Header */} |
There was a problem hiding this comment.
more hex colors in this file that we've got in constants
* edge: (116 commits) feat(system-server): add sqlite database and barebones HTTP server (#12085) feat(ot3): add enableOT3FirmwareUpdates feature flag to gate firmware update functionality. (#12102) feat(app): add bare bones hardware section to protocol details (#12099) feat(app): Support failed calibrations in the calibration wizard (#12092) refactor(docs): clean up Versioning page (#12084) refactor(robot-server): Make run and protocol limits configurable at launch (#12094) feat(app): add robotServerVersion to display the current robot software version (#12096) fix(hardware): do not track tip motor positions (#12093) feat(engine): allow calibrateGripper command to save calibration data (#12046) feat(app, api-client, react-api-client): delete POC TLC calibration data from overflow menu (#12075) fix(api): actually update OT3 instrument calibration offset in cache instrument (#12089) fix(robot-server): correct the data returned from instruments endpoint (#12067) feat(api): add thermocycler plate lift to hardware controller (#12068) fix(app): reference moduleId from result not params (#12077) feat(app): create ODD protocol setup page (#12071) refactor(api): Deprecate presses and increment args when using PAPI pick_up_tip (#12079) fix(ot3): handle multiple responses for a tip action request (#12083) refactor(api): touch tip implementation for PAPIv2 engine core (#12053) refactor(app): Remove ssid parameter from OnDeviceRouteParams (#11930) fix(api): fix broken test in the api hardware controller (#12080) ...
Overview
the first pass on the Protocol Setup page - the page hosts screens for instruments, modules, labware, etc and functional play and cancel buttons. The page is reached from the "Run protocol" button on the protocol details page, which creates a run. there are a few TODOs pending other pieces coming together. Components and styling are not final but close to what's currently in figma.
re RCORE-486
Test Plan
Changelog
Review requests
Risk assessment
low