Do not require ActiveStorage in core
#5450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The activestorage adapter is optional and stores might use another attachment adapter (ie. paperclip). Since bundler already requires activestorage if the store decided to use activestorage adapter (either via a direct dependency or the transient rails gem) we do not need to require it in our engine. This removes a LoadError for stores/engines that do not use activestorage.
tvdeyen
added
backport-v3.4
github-actions
bot
added
the
changelog:solidus_core
Codecov Report
@@ Coverage Diff @@
## main #5450 +/- ##
==========================================
- Coverage 88.91% 88.91% -0.01%
==========================================
Files 614 614
Lines 14827 14826 -1
==========================================
- Hits 13183 13182 -1
Misses 1644 1644
π£ Weβre building smart automated test selection to slash your CI/CD build times. Learn more |
elia
approved these changes
Oct 24, 2023
rainerdema
approved these changes
Oct 25, 2023
This was referenced Oct 25, 2023
π All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
3 tasks
|
This was wrong. Added a fix in #5479 |
elia
changed the title
ActiveStorage in core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The activestorage adapter is optional and stores might use another attachment adapter (ie. paperclip). We do not have it as dependency in our
gemspec.Since bundler already requires activestorage if the store decided to use activestorage adapter (either via a direct dependency or the transient
railsgem) we do not need to require it in our engine.This removes a
LoadErrorfor stores/engines that do not use activestorage.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: