Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not require ActiveStorage in core #5450

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Do not require ActiveStorage in core #5450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Do not require active_storage/engine 
The activestorage adapter is optional and stores might
use another attachment adapter (ie. paperclip).

Since bundler already requires activestorage if the store
decided to use activestorage adapter (either via a direct
dependency or the transient rails gem) we do not need
to require it in our engine.

This removes a LoadError for stores/engines that do not
use activestorage.
  • Loading branch information
@tvdeyen
tvdeyen committed Oct 24, 2023
commit ea0254b13abe237cb56cd79787207bb7691d3173
1 change: 0 additions & 1 deletion core/lib/spree/core.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
require "active_job/railtie"
require "active_model/railtie"
require "active_record/railtie"
require "active_storage/engine"
require "sprockets/railtie"

require 'active_support/deprecation'
Expand Down