Skip to content

Commit

Permalink
Do not require active_storage/engine
Browse files Browse the repository at this point in the history
The activestorage adapter is optional and stores might
use another attachment adapter (ie. paperclip).

Since bundler already requires activestorage if the store
decided to use activestorage adapter (either via a direct
dependency or the transient rails gem) we do not need
to require it in our engine.

This removes a LoadError for stores/engines that do not
use activestorage.
  • Loading branch information
tvdeyen committed Oct 24, 2023
1 parent b2a6f41 commit ea0254b
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion core/lib/spree/core.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
require "active_job/railtie"
require "active_model/railtie"
require "active_record/railtie"
require "active_storage/engine"
require "sprockets/railtie"

require 'active_support/deprecation'
Expand Down

0 comments on commit ea0254b

Please sign in to comment.