Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.2] Do not require active_storage/engine #5456

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

github-actions[bot]
Copy link

Backport

This will backport the following commits from main to v4.2:

Questions ?

Please refer to the Backport tool documentation

The activestorage adapter is optional and stores might
use another attachment adapter (ie. paperclip).

Since bundler already requires activestorage if the store
decided to use activestorage adapter (either via a direct
dependency or the transient rails gem) we do not need
to require it in our engine.

This removes a LoadError for stores/engines that do not
use activestorage.

(cherry picked from commit ea0254b)
@github-actions github-actions bot requested a review from a team as a code owner October 25, 2023 08:51
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #5456 (beaec28) into v4.2 (bc67ece) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             v4.2    #5456      +/-   ##
==========================================
- Coverage   88.86%   88.86%   -0.01%     
==========================================
  Files         607      607              
  Lines       14747    14746       -1     
==========================================
- Hits        13105    13104       -1     
  Misses       1642     1642              
Files Coverage Δ
core/lib/spree/core.rb 98.78% <ø> (-0.02%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tvdeyen tvdeyen merged commit c6c1a8c into v4.2 Oct 27, 2023
9 checks passed
@tvdeyen tvdeyen deleted the backport/v4.2/pr-5450 branch October 27, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants