[v4.0] Do not require active_storage/engine #5454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
changelog:solidus_core
3 tasks
|
Tests fail because of a chromedriver not found error |
adammathys
approved these changes
Oct 25, 2023
|
@elia do you know what I can do to fix the chromedriver issue? Can we remove the pinned version now that CircleCI-Public/browser-tools-orb#75 has been merged? |
The activestorage adapter is optional and stores might use another attachment adapter (ie. paperclip). Since bundler already requires activestorage if the store decided to use activestorage adapter (either via a direct dependency or the transient rails gem) we do not need to require it in our engine. This removes a LoadError for stores/engines that do not use activestorage. (cherry picked from commit ea0254b)
tvdeyen
force-pushed
the
backport/v4.0/pr-5450
branch
from
5827323
to
2e1e758
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov4.0:Questions ?
Please refer to the Backport tool documentation