Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not require ActiveStorage in core #5450

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Do not require ActiveStorage in core #5450

merged 1 commit into from
Oct 25, 2023

Commits on Oct 24, 2023

  1. Do not require active_storage/engine 

    The activestorage adapter is optional and stores might
use another attachment adapter (ie. paperclip).

Since bundler already requires activestorage if the store
decided to use activestorage adapter (either via a direct
dependency or the transient rails gem) we do not need
to require it in our engine.

This removes a LoadError for stores/engines that do not
use activestorage.
    @tvdeyen
    tvdeyen committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    ea0254b View commit details
    Browse the repository at this point in the history