Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-20462] migrate any_team_permission_gate to typescript #6547

Merged
merged 6 commits into from
Oct 7, 2020
Merged

[MM-20462] migrate any_team_permission_gate to typescript #6547

merged 6 commits into from
Oct 7, 2020

Conversation

Tak-Iwamoto
Copy link
Contributor

Summary

  • Migrate 'components/permissions_gates/any_team_permission_gate' module and associated tests to TypeScript

Ticket Link

Fixes mattermost/mattermost#15478
JIRA: https://mattermost.atlassian.net/browse/MM-20462

@hanzei hanzei added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Sep 26, 2020
@Tak-Iwamoto Tak-Iwamoto changed the title migrate any_team_permission_gate to typescript [MM-20462] migrate any_team_permission_gate to typescript Sep 28, 2020
Willyfrog
Willyfrog approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@Willyfrog Willyfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, left a small improvement, but it is not a blocker for this

components/permissions_gates/any_team_permission_gate/any_team_permission_gate.tsx Outdated Show resolved Hide resolved
Tak-Iwamoto and others added 3 commits September 28, 2020 22:46
@Tak-Iwamoto @Willyfrog
Update components/permissions_gates/any_team_permission_gate/any_team…
fc657e7 
…_permission_gate.tsx

Co-authored-by: Guillermo Vayá <[email protected]>
Merge branch 'master' of github.com:Tak-Iwamoto/mattermost-webapp int…
7bbb5ca 
…o MM-20462

* 'master' of github.com:Tak-Iwamoto/mattermost-webapp:
  fix getType is not a function (mattermost#6566)
  MM-29028 Remove findDOMNode from Slack import (mattermost#6554)
  MM-28997 Remove references to old context API (mattermost#6545)
  Add custom slash command tests (mattermost#6391)
  Cypress/E2E: Fix guest experience ui spec (mattermost#6563)
  [MM-28784] Migrate string refs to functional ones (mattermost#6494)
  [MM-28680] fix blank page on undefined message (mattermost#6450)
  MM-28733 : Admin Advisor v2 (mattermost#6461)
  MM 20547 user settings security ts (mattermost#6216)
  MM-20904 Add E2E tests for custom categories (mattermost#5981)
  Update NOTICE.txt (mattermost#6550)
  Check if emojiMap is undefined before invoking method for it (mattermost#6495)
  [MM-28151] Cypress/E2E: Automate backlogs - System Console > User Password (mattermost#6538)
  [MM-28295] e2e/messaging/reactions: add reactions spec (mattermost#6535)
  [MM-28706] revert ordering change for `in:` auto-suggest search results (mattermost#6493)
  Remove usage of t function with useIntl (mattermost#6552)
  MM-28992 Remove unused notPresent and mustBePresent props from MultiSelectSetting (mattermost#6544)
  MM-27530 Fix for Multiselect items not scrolling into view on arrow keys (mattermost#6286)
  Demoting failed test from prod (mattermost#6534)
Merge branch 'MM-20462' of github.com:Tak-Iwamoto/mattermost-webapp i…
62aa1e5 
…nto MM-20462

* 'MM-20462' of github.com:Tak-Iwamoto/mattermost-webapp:
  Update components/permissions_gates/any_team_permission_gate/any_team_permission_gate.tsx
@ashishbhate ashishbhate removed the 2: Dev Review Requires review by a core commiter label Sep 29, 2020
Merge branch 'master' of github.com:Tak-Iwamoto/mattermost-webapp int…
e04794b 
…o MM-20462

* 'master' of github.com:Tak-Iwamoto/mattermost-webapp: (23 commits)
  [MM-25553] favicon added for unread messages without mention (mattermost#6431)
  fix intermittent failing tests at common commands (mattermost#6606)
  [MM-28260] Automate backlogs - Integrations > Slash Commands (mattermost#6429)
  [MM-27207] e2e archived channels I (4) (mattermost#6511)
  MM-24813 Add e2e tests for archive post menu options (mattermost#6571)
  fix MM-T1467 (mattermost#6588)
  MM-23345 - MM-T187 Inline markdown images open preview window (mattermost#6455)
  [Mm-27817] e2e add user to gm (mattermost#6278)
  [MM-28199] Dropdown Input Common Component (mattermost#6543)
  [MM-28783] migrate string refs in edit post modal (mattermost#6560)
  MM-24811 Archive channels should not have options to manage users (mattermost#6570)
  MM-28263: Cypress/E2E: Automate backlogs - Messaging > Pinned Posts part 2 (mattermost#6519)
  Cypress/E2E: Fix MM-T1462 accessibility for incoming message (mattermost#6589)
  Added legal text to upgrade button, and showing again the Edition section in team edition (mattermost#6470)
  add uiClickPostDropdownMenu (mattermost#6581)
  Fix nested a tags in Marketplace labels (mattermost#6520)
  [MM-27277] Enable stream mode for file uploads (mattermost#6568)
  move cypress plugin api (mattermost#6496)
  [MM-28361] User limit reached and overage banners for Mattermost Cloud (mattermost#6548)
  MM-28409 Add e2e for testing archive channel header (mattermost#6522)
  ...
@jgilliam17 jgilliam17 added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Oct 6, 2020
jgilliam17
jgilliam17 approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@jgilliam17 jgilliam17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Tak-Iwamoto
Tested, looks good to merge.

  • Verified team options based on user's permissions - as expected.

@jgilliam17 jgilliam17 added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Oct 6, 2020
@mm-cloud-bot
Copy link

Test server destroyed

Merge branch 'master' of github.com:Tak-Iwamoto/mattermost-webapp int…
d6f9471 
…o MM-20462

* 'master' of github.com:Tak-Iwamoto/mattermost-webapp:
  [MM-22161] - Improve accessibility of channel switcher (mattermost#6199)
  [MM-20460] Migrate 'components/permissions_gates/channel_permission_gate' module and associated tests to TypeScript (mattermost#6601)
  [GH-15724] Remove usage of findDOMNode from Create Team screens (mattermost#6621)
  [MM-29302] Billing Summary Card - No Billing History case (mattermost#6639)
  /files should target=_blank (mattermost#6616)
  MM T134 visual verification of tooltips (mattermost#6604)
  MM-24812 Add e2e tests for adding reactions to existing reactions in archived channel posts (mattermost#6579)
  [MM-20490] Migrate 'components/post_view/combined_user_activity_post' module and associated tests to TypeScript (mattermost#6632)
  MM-24810 Add e2e for reactions for archived channel posts (mattermost#6562)
  [MM-28965] - Prevent link overlap in channel header (mattermost#6546)
  MM-28780: Migrate dotMenu string refs to functional ones (mattermost#6592)
  Cypress/E2E: Fix archived channel specs (mattermost#6617)
  Fixed cypress env for PostgreSQL connection (mattermost#6627)
  Migrate post_list_row component to typescript (mattermost#6593)
  Cypress/E2E: Fix managing bot accounts spec (mattermost#6614)
  Cypress/E2E: Stabilize profile popover spec (mattermost#6612)
  Migrated string refs in signup_email (mattermost#6602)
  Renaming diagnostics-to-telemetry (mattermost#5741)
@ashishbhate ashishbhate merged commit cd67fb6 into mattermost:master Oct 7, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 7, 2020
Tak-Iwamoto pushed a commit to Tak-Iwamoto/mattermost-webapp that referenced this pull request Oct 10, 2020
Merge branch 'master' of github.com:Tak-Iwamoto/mattermost-webapp int…
8f76d21 
…o MM-20499

* 'master' of github.com:Tak-Iwamoto/mattermost-webapp: (71 commits)
  Fix bot icon heigth (mattermost#6578)
  Cypress/E2E: Update quick switch hint (mattermost#6691)
  migrate string-refs in search_results.jsx (mattermost#6671)
  MM-T581 Regen token (mattermost#6642)
  Switch button-bg-## to use button-bg-rgb variables (mattermost#6635)
  [MM-27142] In-Web-App purchase of Mattermost Cloud  (mattermost#6583)
  migrate user_list_row_with_error to ts (mattermost#6624)
  [MM-28217] Front-end for displaying company info (mattermost#6580)
  [MM-28211] Plan Details Card (mattermost#6582)
  [MM-28216] Billing History View (UX Only) (mattermost#6637)
  Added final set of cypress tests part of MM-29347 (mattermost#6659)
  [MM-24507] - Pin comment box on bottom of RHS thread (mattermost#6167)
  Cypress/E2E: Fix channel switcher spec (mattermost#6662)
  [MM-28781] migrate string refs in channelView (mattermost#6607)
  [GH-15777] Replace center-channel-color-## with center-channel-color-rgb variables (mattermost#6643)
  [GH-15776]Switch center-channel-color-## with center-channel-color-rgb variables (mattermost#6641)
  MM-29038 Removed usage of centre-channel-color from post comments (mattermost#6633)
  [MM-29034] Remove usage of sidebar-text-## CSS variables (mattermost#6634)
  Translations update from Weblate (mattermost#6673)
  [MM-20462] migrate any_team_permission_gate to typescript (mattermost#6547)
  ...
Tak-Iwamoto pushed a commit to Tak-Iwamoto/mattermost-webapp that referenced this pull request Oct 10, 2020
Merge branch 'master' of github.com:Tak-Iwamoto/mattermost-webapp int…
0f3c332 
…o MM-20465

* 'master' of github.com:Tak-Iwamoto/mattermost-webapp: (71 commits)
  Fix bot icon heigth (mattermost#6578)
  Cypress/E2E: Update quick switch hint (mattermost#6691)
  migrate string-refs in search_results.jsx (mattermost#6671)
  MM-T581 Regen token (mattermost#6642)
  Switch button-bg-## to use button-bg-rgb variables (mattermost#6635)
  [MM-27142] In-Web-App purchase of Mattermost Cloud  (mattermost#6583)
  migrate user_list_row_with_error to ts (mattermost#6624)
  [MM-28217] Front-end for displaying company info (mattermost#6580)
  [MM-28211] Plan Details Card (mattermost#6582)
  [MM-28216] Billing History View (UX Only) (mattermost#6637)
  Added final set of cypress tests part of MM-29347 (mattermost#6659)
  [MM-24507] - Pin comment box on bottom of RHS thread (mattermost#6167)
  Cypress/E2E: Fix channel switcher spec (mattermost#6662)
  [MM-28781] migrate string refs in channelView (mattermost#6607)
  [GH-15777] Replace center-channel-color-## with center-channel-color-rgb variables (mattermost#6643)
  [GH-15776]Switch center-channel-color-## with center-channel-color-rgb variables (mattermost#6641)
  MM-29038 Removed usage of centre-channel-color from post comments (mattermost#6633)
  [MM-29034] Remove usage of sidebar-text-## CSS variables (mattermost#6634)
  Translations update from Weblate (mattermost#6673)
  [MM-20462] migrate any_team_permission_gate to typescript (mattermost#6547)
  ...
Tak-Iwamoto pushed a commit to Tak-Iwamoto/mattermost-webapp that referenced this pull request Oct 10, 2020
Merge remote-tracking branch 'upstream/master' into MM-20469
02663a8 
* upstream/master: (84 commits)
  Fix bot icon heigth (mattermost#6578)
  Cypress/E2E: Update quick switch hint (mattermost#6691)
  migrate string-refs in search_results.jsx (mattermost#6671)
  MM-T581 Regen token (mattermost#6642)
  Switch button-bg-## to use button-bg-rgb variables (mattermost#6635)
  [MM-27142] In-Web-App purchase of Mattermost Cloud  (mattermost#6583)
  migrate user_list_row_with_error to ts (mattermost#6624)
  [MM-28217] Front-end for displaying company info (mattermost#6580)
  [MM-28211] Plan Details Card (mattermost#6582)
  [MM-28216] Billing History View (UX Only) (mattermost#6637)
  Added final set of cypress tests part of MM-29347 (mattermost#6659)
  [MM-24507] - Pin comment box on bottom of RHS thread (mattermost#6167)
  Cypress/E2E: Fix channel switcher spec (mattermost#6662)
  [MM-28781] migrate string refs in channelView (mattermost#6607)
  [GH-15777] Replace center-channel-color-## with center-channel-color-rgb variables (mattermost#6643)
  [GH-15776]Switch center-channel-color-## with center-channel-color-rgb variables (mattermost#6641)
  MM-29038 Removed usage of centre-channel-color from post comments (mattermost#6633)
  [MM-29034] Remove usage of sidebar-text-## CSS variables (mattermost#6634)
  Translations update from Weblate (mattermost#6673)
  [MM-20462] migrate any_team_permission_gate to typescript (mattermost#6547)
  ...
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
@Tak-Iwamoto @jfrerich
[MM-20462] migrate any_team_permission_gate to typescript (#6547)
4e2427a 
Summary
Migrate 'components/permissions_gates/any_team_permission_gate' module and associated tests to TypeScript

Ticket Link
Fixes mattermost/mattermost#15478
JIRA: https://mattermost.atlassian.net/browse/MM-20462
calebroseland pushed a commit that referenced this pull request Oct 27, 2020
@Tak-Iwamoto @calebroseland
[MM-20462] migrate any_team_permission_gate to typescript (#6547)
b692c1e 
Summary
Migrate 'components/permissions_gates/any_team_permission_gate' module and associated tests to TypeScript

Ticket Link
Fixes mattermost/mattermost#15478
JIRA: https://mattermost.atlassian.net/browse/MM-20462
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Willyfrog Willyfrog Willyfrog approved these changes

@ashishbhate ashishbhate ashishbhate approved these changes

@jgilliam17 jgilliam17 jgilliam17 approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate 'components/permissions_gates/any_team_permission_gate' module and associated tests to TypeScript
7 participants
@Tak-Iwamoto @mm-cloud-bot @Willyfrog @ashishbhate @jgilliam17 @hanzei @amyblais