This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Cypress/E2E: fix getType is not a function #6566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srkgupta
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
Thanks @saturninoabril. Tested and its working fine now. PR LGTM
josephbaylon
approved these changes
Sep 28, 2020
josephbaylon
added
4: Reviews Complete
Tak-Iwamoto
pushed a commit
to Tak-Iwamoto/mattermost-webapp
that referenced
this pull request
Sep 28, 2020
…o MM-20462 * 'master' of github.com:Tak-Iwamoto/mattermost-webapp: fix getType is not a function (mattermost#6566) MM-29028 Remove findDOMNode from Slack import (mattermost#6554) MM-28997 Remove references to old context API (mattermost#6545) Add custom slash command tests (mattermost#6391) Cypress/E2E: Fix guest experience ui spec (mattermost#6563) [MM-28784] Migrate string refs to functional ones (mattermost#6494) [MM-28680] fix blank page on undefined message (mattermost#6450) MM-28733 : Admin Advisor v2 (mattermost#6461) MM 20547 user settings security ts (mattermost#6216) MM-20904 Add E2E tests for custom categories (mattermost#5981) Update NOTICE.txt (mattermost#6550) Check if emojiMap is undefined before invoking method for it (mattermost#6495) [MM-28151] Cypress/E2E: Automate backlogs - System Console > User Password (mattermost#6538) [MM-28295] e2e/messaging/reactions: add reactions spec (mattermost#6535) [MM-28706] revert ordering change for `in:` auto-suggest search results (mattermost#6493) Remove usage of t function with useIntl (mattermost#6552) MM-28992 Remove unused notPresent and mustBePresent props from MultiSelectSetting (mattermost#6544) MM-27530 Fix for Multiselect items not scrolling into view on arrow keys (mattermost#6286) Demoting failed test from prod (mattermost#6534)
amyblais
added
Changelog/Not Needed
Tak-Iwamoto
pushed a commit
to Tak-Iwamoto/mattermost-webapp
that referenced
this pull request
Oct 1, 2020
…o MM-20457 * 'master' of github.com:Tak-Iwamoto/mattermost-webapp: Added legal text to upgrade button, and showing again the Edition section in team edition (mattermost#6470) add uiClickPostDropdownMenu (mattermost#6581) Fix nested a tags in Marketplace labels (mattermost#6520) [MM-27277] Enable stream mode for file uploads (mattermost#6568) move cypress plugin api (mattermost#6496) [MM-28361] User limit reached and overage banners for Mattermost Cloud (mattermost#6548) MM-28409 Add e2e for testing archive channel header (mattermost#6522) channel cannot be required (because it's often not there), so check for it (mattermost#6475) Cypress test for MM-T2368 'Fixed width center' setting does not cause scroll pop and breaks post display (mattermost#6443) MM 18912 Migrate 'utils/filter_users.js' and associated tests to TypeScript (mattermost#4890) fix getType is not a function (mattermost#6566) MM-29028 Remove findDOMNode from Slack import (mattermost#6554) MM-28997 Remove references to old context API (mattermost#6545) Add custom slash command tests (mattermost#6391) Cypress/E2E: Fix guest experience ui spec (mattermost#6563) [MM-28784] Migrate string refs to functional ones (mattermost#6494)
jfrerich
pushed a commit
that referenced
this pull request
Oct 23, 2020
calebroseland
pushed a commit
that referenced
this pull request
Oct 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix getType is not a function by explicitly adding mime version 2 which is a dependent of cypress-file-upload package.
Ticket Link
none
Screenshots
Before: error on file upload
