[MM-24507] - Pin comment box on bottom of RHS thread #6167

nevyangelova · 2020-08-17T15:13:03Z

Summary

Pin comment box on bottom of RHS thread.

Ticket Link

https://mattermost.atlassian.net/browse/MM-24507

esethna · 2020-08-17T16:16:38Z

@nevyangelova can you test this on chrome Win 10? RHS stops scrolling after the comment thread gets large enough to push the comment box to the bottom of the screen

nevyangelova · 2020-09-16T16:34:41Z

Sorry @esethna i have somehow missed the comment. It's working for me on all devices now :)

esethna · 2020-09-16T16:47:40Z

Thanks, adding @jgilliam17 for testing, please make sure to test this on multiple browsers and OS

calebroseland

LGTM!

jgilliam17 · 2020-09-17T02:54:11Z

Thank you @nevyangelova
Tested on Desktop app, Chrome, Firefox and Edge on macOS Catalina, - works as expected.
Tested on Desktop app, Edge on Windows 10 - works as expected.
Tested on Desktop app and Firefox on Ubuntu - works as expected.

Safari on macOS Catalina has an issue, see gif. RHS fails to scroll up when adding additional posts.
May not be an issue - Observed: RHS scrolls to the bottom as soon as you add text, not when posting. Not sure if this is intended, differs from main channel. @esethna any thoughts?
i. Open long thread on the RHS
ii. Scroll up in the thread, close to top
iii. Enter at least one character into RHS box
Observed: RHS scrolls to the bottom as soon as you start typing.

nevyangelova · 2020-09-17T11:26:41Z

@jgilliam17 seems like another safari weirdness but I can't repro :( any additional steps?

However I am pretty certain that its a browser specific thing we will have to avoid using some kind of a hack. @esethna can advice is this is necessary.

esethna · 2020-09-17T13:44:05Z

@jgilliam17 @nevyangelova re # 2, that looks like a regression

jgilliam17 · 2020-09-17T13:59:09Z

Nevy,
For 1. I don't have any additional steps. For me in Safari the RHS thread is stuck on top and does not scroll at all to reveal new posts.
For 2. Just wanted to add that I am seeing this on all devices (other than Safari)

nevyangelova · 2020-09-17T14:03:17Z

Good to know I will add a scrollBottom functionality if the component doesn't already have a prop for that! Thanks both

jgilliam17

Thank you @nevyangelova
Tested, looks good to merge. 🎉

Verified text box is pinned to the bottom of the RHS on long threads. RHS thread scrolls to the bottom when new post is added. Tested on various browsers and desktop apps on macOS, Windows and Ubuntu

mm-cloud-bot · 2020-10-07T13:35:58Z

Test server destroyed

…o MM-20499 * 'master' of github.com:Tak-Iwamoto/mattermost-webapp: (71 commits) Fix bot icon heigth (mattermost#6578) Cypress/E2E: Update quick switch hint (mattermost#6691) migrate string-refs in search_results.jsx (mattermost#6671) MM-T581 Regen token (mattermost#6642) Switch button-bg-## to use button-bg-rgb variables (mattermost#6635) [MM-27142] In-Web-App purchase of Mattermost Cloud (mattermost#6583) migrate user_list_row_with_error to ts (mattermost#6624) [MM-28217] Front-end for displaying company info (mattermost#6580) [MM-28211] Plan Details Card (mattermost#6582) [MM-28216] Billing History View (UX Only) (mattermost#6637) Added final set of cypress tests part of MM-29347 (mattermost#6659) [MM-24507] - Pin comment box on bottom of RHS thread (mattermost#6167) Cypress/E2E: Fix channel switcher spec (mattermost#6662) [MM-28781] migrate string refs in channelView (mattermost#6607) [GH-15777] Replace center-channel-color-## with center-channel-color-rgb variables (mattermost#6643) [GH-15776]Switch center-channel-color-## with center-channel-color-rgb variables (mattermost#6641) MM-29038 Removed usage of centre-channel-color from post comments (mattermost#6633) [MM-29034] Remove usage of sidebar-text-## CSS variables (mattermost#6634) Translations update from Weblate (mattermost#6673) [MM-20462] migrate any_team_permission_gate to typescript (mattermost#6547) ...

…o MM-20465 * 'master' of github.com:Tak-Iwamoto/mattermost-webapp: (71 commits) Fix bot icon heigth (mattermost#6578) Cypress/E2E: Update quick switch hint (mattermost#6691) migrate string-refs in search_results.jsx (mattermost#6671) MM-T581 Regen token (mattermost#6642) Switch button-bg-## to use button-bg-rgb variables (mattermost#6635) [MM-27142] In-Web-App purchase of Mattermost Cloud (mattermost#6583) migrate user_list_row_with_error to ts (mattermost#6624) [MM-28217] Front-end for displaying company info (mattermost#6580) [MM-28211] Plan Details Card (mattermost#6582) [MM-28216] Billing History View (UX Only) (mattermost#6637) Added final set of cypress tests part of MM-29347 (mattermost#6659) [MM-24507] - Pin comment box on bottom of RHS thread (mattermost#6167) Cypress/E2E: Fix channel switcher spec (mattermost#6662) [MM-28781] migrate string refs in channelView (mattermost#6607) [GH-15777] Replace center-channel-color-## with center-channel-color-rgb variables (mattermost#6643) [GH-15776]Switch center-channel-color-## with center-channel-color-rgb variables (mattermost#6641) MM-29038 Removed usage of centre-channel-color from post comments (mattermost#6633) [MM-29034] Remove usage of sidebar-text-## CSS variables (mattermost#6634) Translations update from Weblate (mattermost#6673) [MM-20462] migrate any_team_permission_gate to typescript (mattermost#6547) ...

* upstream/master: (84 commits) Fix bot icon heigth (mattermost#6578) Cypress/E2E: Update quick switch hint (mattermost#6691) migrate string-refs in search_results.jsx (mattermost#6671) MM-T581 Regen token (mattermost#6642) Switch button-bg-## to use button-bg-rgb variables (mattermost#6635) [MM-27142] In-Web-App purchase of Mattermost Cloud (mattermost#6583) migrate user_list_row_with_error to ts (mattermost#6624) [MM-28217] Front-end for displaying company info (mattermost#6580) [MM-28211] Plan Details Card (mattermost#6582) [MM-28216] Billing History View (UX Only) (mattermost#6637) Added final set of cypress tests part of MM-29347 (mattermost#6659) [MM-24507] - Pin comment box on bottom of RHS thread (mattermost#6167) Cypress/E2E: Fix channel switcher spec (mattermost#6662) [MM-28781] migrate string refs in channelView (mattermost#6607) [GH-15777] Replace center-channel-color-## with center-channel-color-rgb variables (mattermost#6643) [GH-15776]Switch center-channel-color-## with center-channel-color-rgb variables (mattermost#6641) MM-29038 Removed usage of centre-channel-color from post comments (mattermost#6633) [MM-29034] Remove usage of sidebar-text-## CSS variables (mattermost#6634) Translations update from Weblate (mattermost#6673) [MM-20462] migrate any_team_permission_gate to typescript (mattermost#6547) ...

amyblais · 2020-10-19T20:24:23Z

/cherry-pick release-5.29

mattermod · 2020-10-19T20:24:24Z

Cherry pick is scheduled.

* [MM-24507] - Pin comment box on bottom of RHS thread * Update snaps * Fix autoheight * update snap * Fix scrolling issues * update snaps * Add comment Co-authored-by: Nevyana Angelova <[email protected]> Co-authored-by: Nevyana Angelova <[email protected]> (cherry picked from commit c2c57d8)

Automatic Merge

This reverts commit c2c57d8.

…#6870) This reverts commit c2c57d8.

…ost#6167)" (mattermost#6870) This reverts commit c2c57d8. (cherry picked from commit c2f293c)

…#6870) (#6886) This reverts commit c2c57d8. (cherry picked from commit c2f293c) Co-authored-by: Nev Angelova <[email protected]>

…o MM-20465 * 'master' of github.com:Tak-Iwamoto/mattermost-webapp: (80 commits) MM-27498 Implement new unread filter (mattermost#6594) [MM-29922] fix typo (mattermost#6893) [MM-29914] Fixed the initial value of the country on company info edit (mattermost#6890) [MM-28216] Hookups to back-end for Billing History section (mattermost#6879) MM-T613 Disable outgoing webhooks in System Console (mattermost#6872) Revert "[MM-24507] - Pin comment box on bottom of RHS thread (mattermost#6167)" (mattermost#6870) Migrate string refs to functional ones in brand_image_setting component (mattermost#6687) MM 27448 remove jquery from root (mattermost#6730) MM-28882: Add config setting to ignore guest ldap sync (mattermost#6750) [MM-29183] - fix(post_info): add id prop to ToolTip (mattermost#6603) [MM-28218] Fix for when both billing address and company address are missing and you can't add company info (mattermost#6875) Removed usage of this.refs.errorMessage (Migrate string-refs to functional ones) (mattermost#6684) [MM-20494] Migrate 'components/post_view/post_attachment_opengraph' module and associated tests to TypeScript (mattermost#6669) MM-20566 Migrate 'components/admin_console/system_users/list' to TypeScript. (mattermost#6759) [MM-29411] migrate string-refs in reset_emailmodal (mattermost#6678) Migrate 'components/admin_console/custom_terms_of_service_settings' to TypeScript (mattermost#6715) Migrate refs of create_post component (mattermost#6653) [MM-29395]Replaced line 522 changeCss to using CSS variable (mattermost#6753) [GH-15579] migrate lifecycle methods from SearchBar component (mattermost#6597) [MM-20456] Typescript Conversion of integrations/edit_outgoing_webhook (mattermost#6615) ...

* [MM-24507] - Pin comment box on bottom of RHS thread * Update snaps * Fix autoheight * update snap * Fix scrolling issues * update snaps * Add comment Co-authored-by: Nevyana Angelova <[email protected]> Co-authored-by: Nevyana Angelova <[email protected]>

…#6870) This reverts commit c2c57d8.

[MM-24507] - Pin comment box on bottom of RHS thread

c68a0bf

nevyangelova added 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Aug 17, 2020

nevyangelova added this to the v5.27 milestone Aug 17, 2020

nevyangelova requested review from hmhealey, calebroseland, esethna and jgilliam17 August 17, 2020 15:13

nevyangelova added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Aug 17, 2020

Update snaps

d241305

amyblais modified the milestones: v5.27, v5.28 Aug 20, 2020

amyblais removed the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Aug 20, 2020

Nevyana Angelova added 4 commits September 10, 2020 17:17

Merge branch 'master' into MM-24507

2803b6a

Merge branch 'master' into MM-24507

cce4cb5

Fix autoheight

44438c3

update snap

9ed7a27

calebroseland added Setup Cloud Test Server Setup a test server using Mattermost Cloud and removed Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Sep 16, 2020

calebroseland approved these changes Sep 16, 2020

View reviewed changes

jgilliam17 approved these changes Oct 7, 2020

View reviewed changes

jgilliam17 added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Oct 7, 2020

nevyangelova merged commit c2c57d8 into master Oct 7, 2020

nevyangelova deleted the MM-24507 branch October 7, 2020 13:43

amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Oct 16, 2020

mattermost-build mentioned this pull request Oct 19, 2020

Automated cherry pick of #6167 #6849

Merged

mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Oct 19, 2020

mattermod pushed a commit that referenced this pull request Oct 20, 2020

[MM-24507] - Pin comment box on bottom of RHS thread (#6167) (#6849)

0f88ee0

Automatic Merge

amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Oct 20, 2020

nevyangelova pushed a commit that referenced this pull request Oct 21, 2020

Revert "[MM-24507] - Pin comment box on bottom of RHS thread (#6167)"

d27bcc0

This reverts commit c2c57d8.

nevyangelova mentioned this pull request Oct 21, 2020

Revert "[MM-24507] - Pin comment box on bottom of RHS thread" #6870

Merged

nevyangelova added a commit that referenced this pull request Oct 22, 2020

Revert "[MM-24507] - Pin comment box on bottom of RHS thread (#6167)" (…

c2f293c

…#6870) This reverts commit c2c57d8.

nevyangelova added a commit that referenced this pull request Oct 22, 2020

Revert "[MM-24507] - Pin comment box on bottom of RHS thread (#6167)" (…

7878ee5

…#6870) (#6886) This reverts commit c2c57d8. (cherry picked from commit c2f293c) Co-authored-by: Nev Angelova <[email protected]>

calebroseland pushed a commit that referenced this pull request Oct 27, 2020

Revert "[MM-24507] - Pin comment box on bottom of RHS thread (#6167)" (…

089b864

…#6870) This reverts commit c2c57d8.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MM-24507] - Pin comment box on bottom of RHS thread #6167

[MM-24507] - Pin comment box on bottom of RHS thread #6167

nevyangelova commented Aug 17, 2020

esethna commented Aug 17, 2020

nevyangelova commented Sep 16, 2020

esethna commented Sep 16, 2020 •

edited

Loading

calebroseland left a comment

jgilliam17 commented Sep 17, 2020

nevyangelova commented Sep 17, 2020 •

edited

Loading

esethna commented Sep 17, 2020 •

edited

Loading

jgilliam17 commented Sep 17, 2020

nevyangelova commented Sep 17, 2020

jgilliam17 left a comment

mm-cloud-bot commented Oct 7, 2020

amyblais commented Oct 19, 2020

mattermod commented Oct 19, 2020

[MM-24507] - Pin comment box on bottom of RHS thread #6167

[MM-24507] - Pin comment box on bottom of RHS thread #6167

Conversation

nevyangelova commented Aug 17, 2020

Summary

Ticket Link

esethna commented Aug 17, 2020

nevyangelova commented Sep 16, 2020

esethna commented Sep 16, 2020 • edited Loading

calebroseland left a comment

Choose a reason for hiding this comment

jgilliam17 commented Sep 17, 2020

nevyangelova commented Sep 17, 2020 • edited Loading

esethna commented Sep 17, 2020 • edited Loading

jgilliam17 commented Sep 17, 2020

nevyangelova commented Sep 17, 2020

jgilliam17 left a comment

Choose a reason for hiding this comment

mm-cloud-bot commented Oct 7, 2020

amyblais commented Oct 19, 2020

mattermod commented Oct 19, 2020

esethna commented Sep 16, 2020 •

edited

Loading

nevyangelova commented Sep 17, 2020 •

edited

Loading

esethna commented Sep 17, 2020 •

edited

Loading