This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srkgupta
added
the
CherryPick/Approved
Meant for the quality or patch release tracked in the milestone
label
Sep 23, 2020
prapti
approved these changes
Sep 23, 2020
josephbaylon
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@srkgupta The PR has cherry pick label but not sure if it's intended since there's no milestone. I'll let you merge just in case my assumption is incorrect |
josephbaylon
added
the
4: Reviews Complete
All reviewers have approved the pull request
label
Sep 24, 2020
Thanks for pointing it out @josephbaylon |
Cherry pick is scheduled. |
mattermost-build
pushed a commit
to mattermost-build/mattermost-webapp
that referenced
this pull request
Sep 24, 2020
(cherry picked from commit 0213a51)
mattermod
added
CherryPick/Done
Successfully cherry-picked to the quality or patch release tracked in the milestone
and removed
CherryPick/Approved
Meant for the quality or patch release tracked in the milestone
labels
Sep 24, 2020
amyblais
added
Changelog/Not Needed
Does not require a changelog entry
Docs/Not Needed
Does not require documentation
labels
Sep 24, 2020
mattermod
pushed a commit
that referenced
this pull request
Sep 24, 2020
Tak-Iwamoto
pushed a commit
to Tak-Iwamoto/mattermost-webapp
that referenced
this pull request
Sep 28, 2020
…o MM-20457 * 'master' of github.com:Tak-Iwamoto/mattermost-webapp: [MM-28680] fix blank page on undefined message (mattermost#6450) MM-28733 : Admin Advisor v2 (mattermost#6461) MM 20547 user settings security ts (mattermost#6216) MM-20904 Add E2E tests for custom categories (mattermost#5981) Update NOTICE.txt (mattermost#6550) Check if emojiMap is undefined before invoking method for it (mattermost#6495) [MM-28151] Cypress/E2E: Automate backlogs - System Console > User Password (mattermost#6538) [MM-28295] e2e/messaging/reactions: add reactions spec (mattermost#6535) [MM-28706] revert ordering change for `in:` auto-suggest search results (mattermost#6493) Remove usage of t function with useIntl (mattermost#6552) MM-28992 Remove unused notPresent and mustBePresent props from MultiSelectSetting (mattermost#6544) MM-27530 Fix for Multiselect items not scrolling into view on arrow keys (mattermost#6286) Demoting failed test from prod (mattermost#6534) migrate show_more to typescript (mattermost#6501) [MM-28878] Revert style change to remove next steps arrow (mattermost#6527) [MM-28972] Added 'Always On' option for new sidebar (mattermost#6530) MM-28839 Fix for hover of cursor on indicators (mattermost#6524) [MM-28790] allow plugins to open in a different tab (mattermost#6476) MM-28290 Always update team member unread counts when added to a channel (mattermost#6500)
Tak-Iwamoto
pushed a commit
to Tak-Iwamoto/mattermost-webapp
that referenced
this pull request
Sep 28, 2020
…o MM-20462 * 'master' of github.com:Tak-Iwamoto/mattermost-webapp: fix getType is not a function (mattermost#6566) MM-29028 Remove findDOMNode from Slack import (mattermost#6554) MM-28997 Remove references to old context API (mattermost#6545) Add custom slash command tests (mattermost#6391) Cypress/E2E: Fix guest experience ui spec (mattermost#6563) [MM-28784] Migrate string refs to functional ones (mattermost#6494) [MM-28680] fix blank page on undefined message (mattermost#6450) MM-28733 : Admin Advisor v2 (mattermost#6461) MM 20547 user settings security ts (mattermost#6216) MM-20904 Add E2E tests for custom categories (mattermost#5981) Update NOTICE.txt (mattermost#6550) Check if emojiMap is undefined before invoking method for it (mattermost#6495) [MM-28151] Cypress/E2E: Automate backlogs - System Console > User Password (mattermost#6538) [MM-28295] e2e/messaging/reactions: add reactions spec (mattermost#6535) [MM-28706] revert ordering change for `in:` auto-suggest search results (mattermost#6493) Remove usage of t function with useIntl (mattermost#6552) MM-28992 Remove unused notPresent and mustBePresent props from MultiSelectSetting (mattermost#6544) MM-27530 Fix for Multiselect items not scrolling into view on arrow keys (mattermost#6286) Demoting failed test from prod (mattermost#6534)
jfrerich
pushed a commit
that referenced
this pull request
Oct 23, 2020
calebroseland
pushed a commit
that referenced
this pull request
Oct 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
4: Reviews Complete
All reviewers have approved the pull request
Changelog/Not Needed
Does not require a changelog entry
CherryPick/Done
Successfully cherry-picked to the quality or patch release tracked in the milestone
Docs/Not Needed
Does not require documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Demoting failed tests from prod. These tests are working fine locally but for some reasons they are failing on the Cypress test instance on daily runs.
Ticket Link
N/A