Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-28411] Archive channels should not have options to manage users #6570

Merged
merged 2 commits into from
Oct 1, 2020

Conversation

sudheerDev
Copy link
Contributor

Summary

Add e2e tests for channel dropdown to not have manage user options

Ticket Link

https://mattermost.atlassian.net/browse/MM-28411

@sudheerDev sudheerDev added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Sep 28, 2020
@sudheerDev sudheerDev changed the title MM-24812 Archive channels should not have options to manage users MM-24811 Archive channels should not have options to manage users Sep 28, 2020
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sudheerDev. Tested and passed. Test LGTM

@sudheerDev sudheerDev removed the 2: Dev Review Requires review by a core commiter label Sep 29, 2020
@jgilliam17 jgilliam17 added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Oct 1, 2020
Copy link
Contributor

@jgilliam17 jgilliam17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sudheerDev
Looks good to merge.

  • Test case steps, details and links verified/updated.

@jgilliam17 jgilliam17 added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Oct 1, 2020
@mm-cloud-bot
Copy link

Test server destroyed

@sudheerDev sudheerDev merged commit d848702 into mattermost:master Oct 1, 2020
@sudheerDev sudheerDev deleted the MM-24811 branch October 1, 2020 15:25
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 1, 2020
Tak-Iwamoto pushed a commit to Tak-Iwamoto/mattermost-webapp that referenced this pull request Oct 2, 2020
…o MM-20462

* 'master' of github.com:Tak-Iwamoto/mattermost-webapp: (23 commits)
  [MM-25553] favicon added for unread messages without mention (mattermost#6431)
  fix intermittent failing tests at common commands (mattermost#6606)
  [MM-28260] Automate backlogs - Integrations > Slash Commands (mattermost#6429)
  [MM-27207] e2e archived channels I (4) (mattermost#6511)
  MM-24813 Add e2e tests for archive post menu options (mattermost#6571)
  fix MM-T1467 (mattermost#6588)
  MM-23345 - MM-T187 Inline markdown images open preview window (mattermost#6455)
  [Mm-27817] e2e add user to gm (mattermost#6278)
  [MM-28199] Dropdown Input Common Component (mattermost#6543)
  [MM-28783] migrate string refs in edit post modal (mattermost#6560)
  MM-24811 Archive channels should not have options to manage users (mattermost#6570)
  MM-28263: Cypress/E2E: Automate backlogs - Messaging > Pinned Posts part 2 (mattermost#6519)
  Cypress/E2E: Fix MM-T1462 accessibility for incoming message (mattermost#6589)
  Added legal text to upgrade button, and showing again the Edition section in team edition (mattermost#6470)
  add uiClickPostDropdownMenu (mattermost#6581)
  Fix nested a tags in Marketplace labels (mattermost#6520)
  [MM-27277] Enable stream mode for file uploads (mattermost#6568)
  move cypress plugin api (mattermost#6496)
  [MM-28361] User limit reached and overage banners for Mattermost Cloud (mattermost#6548)
  MM-28409 Add e2e for testing archive channel header (mattermost#6522)
  ...
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
)

* MM-24812 Archive channels should not have options to manage users

* lint fix
calebroseland pushed a commit that referenced this pull request Oct 27, 2020
)

* MM-24812 Archive channels should not have options to manage users

* lint fix
@jgilliam17 jgilliam17 changed the title MM-24811 Archive channels should not have options to manage users [MM-24811] Archive channels should not have options to manage users Dec 21, 2020
@jgilliam17 jgilliam17 changed the title [MM-24811] Archive channels should not have options to manage users [MM-28411] Archive channels should not have options to manage users Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
6 participants