This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-28295] e2e/messaging/reactions: add reactions spec #6535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isacikgoz
added
2: Dev Review
streamer45
approved these changes
Sep 23, 2020
isacikgoz
changed the title
|
@streamer45 I'm request a re-review I added the remaining test cases to this PR. |
josephbaylon
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
LGTM. Just minor typo fixes. Tests passed locally. Tests match TM4J. Thanks @isacikgoz !!
streamer45
approved these changes
Sep 24, 2020
Co-authored-by: Joseph Baylon <[email protected]> Co-authored-by: Claudio Costa <[email protected]>
lindy65
reviewed
Sep 25, 2020
lindy65
reviewed
Sep 25, 2020
lindy65
approved these changes
Sep 25, 2020
lindy65
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
Tak-Iwamoto
pushed a commit
to Tak-Iwamoto/mattermost-webapp
that referenced
this pull request
Sep 28, 2020
…o MM-20457 * 'master' of github.com:Tak-Iwamoto/mattermost-webapp: [MM-28680] fix blank page on undefined message (mattermost#6450) MM-28733 : Admin Advisor v2 (mattermost#6461) MM 20547 user settings security ts (mattermost#6216) MM-20904 Add E2E tests for custom categories (mattermost#5981) Update NOTICE.txt (mattermost#6550) Check if emojiMap is undefined before invoking method for it (mattermost#6495) [MM-28151] Cypress/E2E: Automate backlogs - System Console > User Password (mattermost#6538) [MM-28295] e2e/messaging/reactions: add reactions spec (mattermost#6535) [MM-28706] revert ordering change for `in:` auto-suggest search results (mattermost#6493) Remove usage of t function with useIntl (mattermost#6552) MM-28992 Remove unused notPresent and mustBePresent props from MultiSelectSetting (mattermost#6544) MM-27530 Fix for Multiselect items not scrolling into view on arrow keys (mattermost#6286) Demoting failed test from prod (mattermost#6534) migrate show_more to typescript (mattermost#6501) [MM-28878] Revert style change to remove next steps arrow (mattermost#6527) [MM-28972] Added 'Always On' option for new sidebar (mattermost#6530) MM-28839 Fix for hover of cursor on indicators (mattermost#6524) [MM-28790] allow plugins to open in a different tab (mattermost#6476) MM-28290 Always update team member unread counts when added to a channel (mattermost#6500)
Tak-Iwamoto
pushed a commit
to Tak-Iwamoto/mattermost-webapp
that referenced
this pull request
Sep 28, 2020
…o MM-20462 * 'master' of github.com:Tak-Iwamoto/mattermost-webapp: fix getType is not a function (mattermost#6566) MM-29028 Remove findDOMNode from Slack import (mattermost#6554) MM-28997 Remove references to old context API (mattermost#6545) Add custom slash command tests (mattermost#6391) Cypress/E2E: Fix guest experience ui spec (mattermost#6563) [MM-28784] Migrate string refs to functional ones (mattermost#6494) [MM-28680] fix blank page on undefined message (mattermost#6450) MM-28733 : Admin Advisor v2 (mattermost#6461) MM 20547 user settings security ts (mattermost#6216) MM-20904 Add E2E tests for custom categories (mattermost#5981) Update NOTICE.txt (mattermost#6550) Check if emojiMap is undefined before invoking method for it (mattermost#6495) [MM-28151] Cypress/E2E: Automate backlogs - System Console > User Password (mattermost#6538) [MM-28295] e2e/messaging/reactions: add reactions spec (mattermost#6535) [MM-28706] revert ordering change for `in:` auto-suggest search results (mattermost#6493) Remove usage of t function with useIntl (mattermost#6552) MM-28992 Remove unused notPresent and mustBePresent props from MultiSelectSetting (mattermost#6544) MM-27530 Fix for Multiselect items not scrolling into view on arrow keys (mattermost#6286) Demoting failed test from prod (mattermost#6534)
jfrerich
pushed a commit
that referenced
this pull request
Oct 23, 2020
* e2e/messaging/reactions: add T2189 * add remaning cases * Apply suggestions from code review Co-authored-by: Joseph Baylon <[email protected]> Co-authored-by: Claudio Costa <[email protected]> * s/flag/save Co-authored-by: Joseph Baylon <[email protected]> Co-authored-by: Claudio Costa <[email protected]>
calebroseland
pushed a commit
that referenced
this pull request
Oct 27, 2020
* e2e/messaging/reactions: add T2189 * add remaning cases * Apply suggestions from code review Co-authored-by: Joseph Baylon <[email protected]> Co-authored-by: Claudio Costa <[email protected]> * s/flag/save Co-authored-by: Joseph Baylon <[email protected]> Co-authored-by: Claudio Costa <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds:
Ticket Link
https://mattermost.atlassian.net/browse/MM-28265