Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-12579 Migration of team_actions to be pure redux #1887

Merged
merged 8 commits into from
Oct 29, 2018
Merged

MM-12579 Migration of team_actions to be pure redux #1887

merged 8 commits into from
Oct 29, 2018

Conversation

sudheerDev
Copy link
Contributor

@sudheerDev sudheerDev commented Oct 15, 2018 •
edited
Loading

Summary

Remove updateTeam legacy actions
Remove createTeam legacy action
Remove getTeamMembersForUser legacy action
Remove getTeamsForUser legacy action

Affected areas:
Manage teams sections in system console for users.

Ticket Link

12579

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed
  • Added or updated unit tests (required for all new features)

@sudheerDev sudheerDev force-pushed the MM-12579 branch 2 times, most recently from a1af530 to 7187015 Compare October 15, 2018 19:20
@sudheerDev sudheerDev added the Work in Progress Not yet ready for review label Oct 15, 2018
@sudheerDev sudheerDev changed the title MM-12579 Migration of team_actions to be pure redux [WIP] MM-12579 Migration of team_actions to be pure redux Oct 15, 2018
@sudheerDev sudheerDev added this to the v5.6.0 milestone Oct 15, 2018
@sudheerDev sudheerDev changed the title [WIP] MM-12579 Migration of team_actions to be pure redux MM-12579 Migration of team_actions to be pure redux Oct 16, 2018
@sudheerDev sudheerDev added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester and removed Work in Progress Not yet ready for review labels Oct 16, 2018
@sudheerDev sudheerDev added Awaiting Submitter Action Blocked on the author and removed 3: QA Review Requires review by a QA tester 2: Dev Review Requires review by a core commiter labels Oct 16, 2018
@sudheerDev
Copy link
Contributor Author

I will update this ticket to have another action as it is in the same workflow and QA can smoke test just once.

@sudheerDev sudheerDev added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester Setup Old Test Server Triggers the creation of a test server and removed Awaiting Submitter Action Blocked on the author labels Oct 17, 2018
@mattermod
Copy link
Contributor

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

@mattermod
Copy link
Contributor

Spinmint test server created at: https://i-011c5a7f5048872aa.test.spinmint.com

Test Admin Account: Username: sysadmin | Password: sysadmin

Test User Account: Username: user-1 | Password: user-1

Instance ID: i-011c5a7f5048872aa

saturninoabril
saturninoabril approved these changes Oct 18, 2018
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎉

@DHaussermann
Copy link

@sudheerDev, This change looks good to me.
Tested as follows:

  • Create Team
  • Updated all values for team settings
  • Add member to Team
  • Manage members options for Team
  • As sysadmin, View all Teams for a user and ensure remove from team is working.
    No issues found.

@sudheerDev sudheerDev mentioned this pull request Oct 23, 2018
Merged
4 tasks
@sudheerDev
Copy link
Contributor Author

@hmhealey review?

@mattermod
Copy link
Contributor

Spinmint test running for more than 7 days. This test server was terminated.

@sudheerDev
MM-12579 Migration of team_actions to redux actions
b421950 
Remove updateTeam legacy actions
 * Removing are we not using this.

Remove createTeam legacy action
 * Removing as we are not using this.

Remove getTeamMembersForUser legacy action
 * Using mattermost-redux now.

Remove getTeamsForUser legacy action
 * Using mattermost-redux now.

Remove checkIfTeams legacy actions
 * Removing as we are not using this.
@sudheerDev
Remove wrapper.update
26c3d28
@sudheerDev
Fix review comments
6db38b8
@sudheerDev
Review comments
a0d7864
@sudheerDev
Fix rebase updates
fd2ecca
@sudheerDev
Changes after rebase
60fc618 
  * move actions for mange_modal to its connected component
@hmhealey hmhealey removed the 2: Dev Review Requires review by a core commiter label Oct 29, 2018
@mattermod
Copy link
Contributor

Spinmint test server destroyed

@sudheerDev sudheerDev added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester Setup Old Test Server Triggers the creation of a test server labels Oct 29, 2018
@sudheerDev sudheerDev merged commit 64b96de into mattermost:master Oct 29, 2018
@sudheerDev sudheerDev deleted the MM-12579 branch October 29, 2018 21:54
mickmister pushed a commit to mickmister/mattermost-webapp that referenced this pull request Nov 6, 2018
@sudheerDev @mickmister
MM-12579 Migration of team_actions to be pure redux (mattermost#1887)
5ec2608 
* MM-12579 Migration of team_actions to redux actions

Remove updateTeam legacy actions
 * Removing are we not using this.

Remove createTeam legacy action
 * Removing as we are not using this.

Remove getTeamMembersForUser legacy action
 * Using mattermost-redux now.

Remove getTeamsForUser legacy action
 * Using mattermost-redux now.

Remove checkIfTeams legacy actions
 * Removing as we are not using this.

* Remove wrapper.update

* Fix review comments

* Review comments

* Fix rebase updates

* Changes after rebase

  * move actions for mange_modal to its connected component

* Revert process tick

* Change async to done
mickmister pushed a commit to mickmister/mattermost-webapp that referenced this pull request Nov 6, 2018
@jwilander @mickmister
Update mattermost-redux to latest (mattermost#1960)
7379e9d 
Remove last flux store usage from actions (mattermost#1951)

* Remove flus usages from diagnostics

* Remove flux usages from status actions

* Convert status actions to redux actions and add tests

* Updates per feedback

* Update per feedback

MM-12579 Migration of team_actions to be pure redux (mattermost#1887)

* MM-12579 Migration of team_actions to redux actions

Remove updateTeam legacy actions
 * Removing are we not using this.

Remove createTeam legacy action
 * Removing as we are not using this.

Remove getTeamMembersForUser legacy action
 * Using mattermost-redux now.

Remove getTeamsForUser legacy action
 * Using mattermost-redux now.

Remove checkIfTeams legacy actions
 * Removing as we are not using this.

* Remove wrapper.update

* Fix review comments

* Review comments

* Fix rebase updates

* Changes after rebase

  * move actions for mange_modal to its connected component

* Revert process tick

* Change async to done

MM-12807 Fix clicking on multiselect items (mattermost#1965)

* Fix clicking on multiselect items

* Update snapshots

MM-12585 Complete migration of file_actions to redux actions (mattermost#1955)

remove the setting link and dont render the settings page for a plugin if dont need (mattermost#1872)

* remove the setting link and dont render the settings page for a plugin if dont need

* add tests for admin_sidebar

MM-12810 Fix for redirection is path is not root (mattermost#1963)

Migrated removed_from_channel_modal to be Pure and use Redux (mattermost#1839)

* Migrated to redux
* Removed usage of BrowserStore and jQuery
* Added usage of react-bootstrap's Modal and openModal/closeModal
actions
* Added unit tests

migrate increasePostVisibility into redux-style action (mattermost#1958)

showFlaggedPosts uses redux (mattermost#1953)

Fixed tests

Fixed tests

fixes

Remove flux store usages from channel_actions.jsx (mattermost#1925)

change @undefined to Someone in combined system messages (mattermost#1949)

add channel header dropdown page object and some tests to channel header (mattermost#1947)

Reset state properly when cancelling notifaction settings (mattermost#1978)

MM-12815: Stop using permissions-deprecated config settings in web app (mattermost#1970)

* Remove RestrictTeamInvite.

* Do EnableOnlyAdminIntegrations

* Do EnableTeamCreation.

* Do AllowEditPost.

* Cleanup SelectTeam component use of permissions.

Fixing users not searchable when adding user to a channel. (mattermost#1977)

Remove flux store usages from websocket_actions.jsx (mattermost#1948)

* Remove BrowserStore usages and convert removed from channel modal

* Remove ChannelStore

* Remove PreferenceStore

* Remove TeamStore and fix redirect on leave team

* Remove UserStore

* Clean up import

* Fix merge

* Update tests

add build discader to avoid disk full issues in jenkins (mattermost#1973)

MM-12429 Add LDAP/AD create account label when redirected from sign-up to login (mattermost#1972)

* Add LDAP/AD create account label when redirected from sign-up to login

* Use URLSearchParams for query string construction

* Update alert colors and remove icon

MM-12838: Make hashtag highlighting case insensitive. (mattermost#1982)

Remove flux store usages from utils (mattermost#1952)

MM-12677 Removing SuggestionStore (mattermost#1932)

* Removing SuggestionStore.

* Fixing clicking mention in popover.

* Fixing laggy text manipulation.

* Feedback fixes

Removing ErrorStore. (mattermost#1976)
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 16, 2018
@DHaussermann DHaussermann added the Tests/Done Release tests have been written label Nov 24, 2018
JayaKrishnaNamburu pushed a commit to JayaKrishnaNamburu/mattermost-webapp that referenced this pull request Dec 3, 2018
@sudheerDev @JayaKrishnaNamburu
MM-12579 Migration of team_actions to be pure redux (mattermost#1887)
8d65e2e 
* MM-12579 Migration of team_actions to redux actions

Remove updateTeam legacy actions
 * Removing are we not using this.

Remove createTeam legacy action
 * Removing as we are not using this.

Remove getTeamMembersForUser legacy action
 * Using mattermost-redux now.

Remove getTeamsForUser legacy action
 * Using mattermost-redux now.

Remove checkIfTeams legacy actions
 * Removing as we are not using this.

* Remove wrapper.update

* Fix review comments

* Review comments

* Fix rebase updates

* Changes after rebase

  * move actions for mange_modal to its connected component

* Revert process tick

* Change async to done
JayaKrishnaNamburu pushed a commit to JayaKrishnaNamburu/mattermost-webapp that referenced this pull request Dec 3, 2018
@sudheerDev @JayaKrishnaNamburu
MM-12579 Migration of team_actions to be pure redux (mattermost#1887)
eea42a9 
* MM-12579 Migration of team_actions to redux actions

Remove updateTeam legacy actions
 * Removing are we not using this.

Remove createTeam legacy action
 * Removing as we are not using this.

Remove getTeamMembersForUser legacy action
 * Using mattermost-redux now.

Remove getTeamsForUser legacy action
 * Using mattermost-redux now.

Remove checkIfTeams legacy actions
 * Removing as we are not using this.

* Remove wrapper.update

* Fix review comments

* Review comments

* Fix rebase updates

* Changes after rebase

  * move actions for mange_modal to its connected component

* Revert process tick

* Change async to done
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hmhealey hmhealey hmhealey approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.6.0
6 participants
@sudheerDev @mattermod @DHaussermann @hmhealey @saturninoabril @amyblais