Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-12710 Migration of team_actions to redux #1930

Merged
merged 5 commits into from
Nov 20, 2018
Merged

MM-12710 Migration of team_actions to redux #1930

merged 5 commits into from
Nov 20, 2018

Conversation

sudheerDev
Copy link
Contributor

@sudheerDev sudheerDev commented Oct 23, 2018 •
edited
Loading

Summary

Migration of these actions.

  1. removeUserFromTeam(Updated)
  2. addUserToTeamFromInvite(Updated)
  3. addUsersToTeam(Updated)
  4. getInviteInfo(Removed using a redux action instead)
  5. switchTeams(Updated)
  6. inviteMembers(Removed using a redux action instead)

QA Areas:

  1. Removing user from team
  2. Adding user to team
  3. User signing up with invite team link
  4. Sending email invites to users

Ticket Link

MM-12710

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

@sudheerDev sudheerDev added the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Oct 23, 2018
@sudheerDev sudheerDev force-pushed the MM-12710 branch 3 times, most recently from 8161dd4 to 6fbbe28 Compare November 5, 2018 08:48
@sudheerDev sudheerDev added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester and removed Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) labels Nov 5, 2018
@sudheerDev sudheerDev added this to the v5.6.0 milestone Nov 5, 2018
@enahum enahum added the Setup Old Test Server Triggers the creation of a test server label Nov 5, 2018
@sudheerDev
Copy link
Contributor Author

@enahum Made changes. I will rebase later so it is easy to follow the commits after review comments .

enahum
enahum approved these changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@enahum enahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@DHaussermann DHaussermann added Setup Old Test Server Triggers the creation of a test server and removed Setup Old Test Server Triggers the creation of a test server labels Nov 14, 2018
@sudheerDev sudheerDev force-pushed the MM-12710 branch 2 times, most recently from bd1ece4 to 44b6074 Compare November 14, 2018 20:21
@sudheerDev sudheerDev added Setup Old Test Server Triggers the creation of a test server and removed Setup Old Test Server Triggers the creation of a test server labels Nov 14, 2018
@DHaussermann DHaussermann added Setup Old Test Server Triggers the creation of a test server and removed Setup Old Test Server Triggers the creation of a test server labels Nov 15, 2018
@mattermost mattermost deleted a comment from mattermod Nov 16, 2018
@mattermost mattermost deleted a comment from mattermod Nov 16, 2018
@mattermost mattermost deleted a comment from mattermod Nov 20, 2018
@DHaussermann
Copy link

@sudheerDev I was unable to test the latest round. The server would not build because a re-base was required. Can you assist?

@sudheerDev
MM-12710 Migrate team_actions to redux
d6f7825 
  * removeUserFromTeam(Updated)
  * addUserToTeamFromInvite(Updated)
  * addUsersToTeam(Updated)
  * getInviteInfo(Removed using a redux action instead)
  * switchTeams(Updated)
  * inviteMembers(Removed using a redux action instead)
@sudheerDev
Update tests
25ef6a6
@sudheerDev
Move removeUserFromTeam to manage_teams_modal
359786a
@sudheerDev
* Fix reabse error and move tests
a1038fa
@sudheerDev
Fix for a test issue found where userId is being passed instead of te…
bd00944 
…stId
@DHaussermann DHaussermann added the Setup Old Test Server Triggers the creation of a test server label Nov 20, 2018
@mattermod
Copy link
Contributor

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

@mattermod
Copy link
Contributor

Spinmint test server created at: https://i-0a4fe78c9dbf46e43.test.spinmint.com

Test Admin Account: Username: sysadmin | Password: sysadmin

Test User Account: Username: user-1 | Password: user-1

Instance ID: i-0a4fe78c9dbf46e43

@DHaussermann
Copy link

Thnaks @sudheerDev this is now resolved. Also re-tested other team related actions.

This looks good to me.

DHaussermann
DHaussermann approved these changes Nov 20, 2018
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by QA after functional testing.

@DHaussermann DHaussermann removed 3: QA Review Requires review by a QA tester Setup Old Test Server Triggers the creation of a test server labels Nov 20, 2018
@mattermod
Copy link
Contributor

Spinmint test server destroyed

@sudheerDev sudheerDev added 4: Reviews Complete All reviewers have approved the pull request 2: Dev Review Requires review by a core commiter and removed 2: Dev Review Requires review by a core commiter 4: Reviews Complete All reviewers have approved the pull request labels Nov 20, 2018
@sudheerDev sudheerDev added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Nov 20, 2018
@sudheerDev sudheerDev merged commit 0d2442e into mattermost:master Nov 20, 2018
@sudheerDev sudheerDev deleted the MM-12710 branch November 20, 2018 18:16
@lindy65 lindy65 removed the 4: Reviews Complete All reviewers have approved the pull request label Nov 20, 2018
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Nov 21, 2018
@lindy65 lindy65 added the Tests/Done Release tests have been written label Dec 4, 2018
@JtheBAB JtheBAB mentioned this pull request Jan 15, 2019
Closed
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jwilander jwilander jwilander approved these changes

@enahum enahum enahum approved these changes

@DHaussermann DHaussermann DHaussermann approved these changes

Assignees
No one assigned
Labels
Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.6.0
8 participants
@sudheerDev @DHaussermann @mattermod @jwilander @enahum @cpanato @lindy65 @amyblais