This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-12714] Migrate increasePostVisibility into redux-style action #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturninoabril
added
2: Dev Review
mkraft
approved these changes
Oct 30, 2018
enahum
approved these changes
Oct 30, 2018
|
@DHaussermann I think this is fine not to have QA test since change is just converting the use of state and dispatch. I'm merging this now. Thanks |
mickmister
pushed a commit
to mickmister/mattermost-webapp
that referenced
this pull request
Nov 6, 2018
mickmister
pushed a commit
to mickmister/mattermost-webapp
that referenced
this pull request
Nov 6, 2018
Remove last flux store usage from actions (mattermost#1951) * Remove flus usages from diagnostics * Remove flux usages from status actions * Convert status actions to redux actions and add tests * Updates per feedback * Update per feedback MM-12579 Migration of team_actions to be pure redux (mattermost#1887) * MM-12579 Migration of team_actions to redux actions Remove updateTeam legacy actions * Removing are we not using this. Remove createTeam legacy action * Removing as we are not using this. Remove getTeamMembersForUser legacy action * Using mattermost-redux now. Remove getTeamsForUser legacy action * Using mattermost-redux now. Remove checkIfTeams legacy actions * Removing as we are not using this. * Remove wrapper.update * Fix review comments * Review comments * Fix rebase updates * Changes after rebase * move actions for mange_modal to its connected component * Revert process tick * Change async to done MM-12807 Fix clicking on multiselect items (mattermost#1965) * Fix clicking on multiselect items * Update snapshots MM-12585 Complete migration of file_actions to redux actions (mattermost#1955) remove the setting link and dont render the settings page for a plugin if dont need (mattermost#1872) * remove the setting link and dont render the settings page for a plugin if dont need * add tests for admin_sidebar MM-12810 Fix for redirection is path is not root (mattermost#1963) Migrated removed_from_channel_modal to be Pure and use Redux (mattermost#1839) * Migrated to redux * Removed usage of BrowserStore and jQuery * Added usage of react-bootstrap's Modal and openModal/closeModal actions * Added unit tests migrate increasePostVisibility into redux-style action (mattermost#1958) showFlaggedPosts uses redux (mattermost#1953) Fixed tests Fixed tests fixes Remove flux store usages from channel_actions.jsx (mattermost#1925) change @undefined to Someone in combined system messages (mattermost#1949) add channel header dropdown page object and some tests to channel header (mattermost#1947) Reset state properly when cancelling notifaction settings (mattermost#1978) MM-12815: Stop using permissions-deprecated config settings in web app (mattermost#1970) * Remove RestrictTeamInvite. * Do EnableOnlyAdminIntegrations * Do EnableTeamCreation. * Do AllowEditPost. * Cleanup SelectTeam component use of permissions. Fixing users not searchable when adding user to a channel. (mattermost#1977) Remove flux store usages from websocket_actions.jsx (mattermost#1948) * Remove BrowserStore usages and convert removed from channel modal * Remove ChannelStore * Remove PreferenceStore * Remove TeamStore and fix redirect on leave team * Remove UserStore * Clean up import * Fix merge * Update tests add build discader to avoid disk full issues in jenkins (mattermost#1973) MM-12429 Add LDAP/AD create account label when redirected from sign-up to login (mattermost#1972) * Add LDAP/AD create account label when redirected from sign-up to login * Use URLSearchParams for query string construction * Update alert colors and remove icon MM-12838: Make hashtag highlighting case insensitive. (mattermost#1982) Remove flux store usages from utils (mattermost#1952) MM-12677 Removing SuggestionStore (mattermost#1932) * Removing SuggestionStore. * Fixing clicking mention in popover. * Fixing laggy text manipulation. * Feedback fixes Removing ErrorStore. (mattermost#1976)
amyblais
added
Changelog/Done
DHaussermann
added
Tests/Not Needed
JayaKrishnaNamburu
pushed a commit
to JayaKrishnaNamburu/mattermost-webapp
that referenced
this pull request
Dec 3, 2018
JayaKrishnaNamburu
pushed a commit
to JayaKrishnaNamburu/mattermost-webapp
that referenced
this pull request
Dec 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate increasePostVisibility into redux-style action.
Affected area:
@DHaussermann I'd like to request for regression test for affected area above. Thanks!
Ticket Link
Jira ticket: MM-12714
Checklist
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed