Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Remove flux store usages from utils #1952

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Remove flux store usages from utils #1952

merged 1 commit into from
Nov 1, 2018

Conversation

jwilander
Copy link
Member

Summary

Remove flux store usages from utils. We should probably not have any references to the stores at all in the utils but that's a much larger task than what I'm trying to do here.

@lindy65 can you test to make sure MFA enforcement still works and that clicking on desktop notifications sends you to the right channel?

Ticket Link

Part of https://mattermost.atlassian.net/browse/MM-12564

Checklist

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed
  • Added or updated unit tests (required for all new features)

@jwilander jwilander added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Oct 27, 2018
@lindy65 lindy65 added Setup Old Test Server Triggers the creation of a test server and removed Setup Old Test Server Triggers the creation of a test server labels Oct 28, 2018
@mattermost mattermost deleted a comment from mattermod Oct 28, 2018
@mattermost mattermost deleted a comment from mattermod Oct 28, 2018
@lindy65 lindy65 added the Setup Old Test Server Triggers the creation of a test server label Oct 28, 2018
@mattermost mattermost deleted a comment from mattermod Oct 29, 2018
@lindy65 lindy65 removed the Setup Old Test Server Triggers the creation of a test server label Oct 29, 2018
@mattermost mattermost deleted a comment from mattermod Oct 29, 2018
@lindy65 lindy65 added the Setup Old Test Server Triggers the creation of a test server label Oct 29, 2018
@mattermod
Copy link
Contributor

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

@mattermod
Copy link
Contributor

Spinmint test server created at: https://i-0537aa63646762269.test.spinmint.com

Test Admin Account: Username: sysadmin | Password: sysadmin

Test User Account: Username: user-1 | Password: user-1

Instance ID: i-0537aa63646762269

@lindy65
Copy link
Contributor

lindy65 commented Oct 29, 2018

Thanks @jwilander

Tested:

  • MFA enforcement
    • works as expected for a user who has MFA turned on already as well as for a user who doesn't and has to set it up at next login.
  • clicking on desktop notifications sends you to the right channel
    • works as expected - no issues found

@lindy65 lindy65 added Tests/Done Release tests have been written and removed 3: QA Review Requires review by a QA tester labels Oct 29, 2018
@jwilander jwilander removed the Setup Old Test Server Triggers the creation of a test server label Oct 29, 2018
@mattermod
Copy link
Contributor

Spinmint test server destroyed

sudheerDev
sudheerDev approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@sudheerDev sudheerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the minor nit.

utils/utils.jsx
@@ -122,21 +120,32 @@ export function isSystemAdmin(roles) {
return false;
}

export function getTeamRelativeUrl(team) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: utils/url.jsx Seems like a is a better place for this.

grundleborg
grundleborg approved these changes Nov 1, 2018
View reviewed changes
Copy link
Contributor

@grundleborg grundleborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grundleborg grundleborg added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Nov 1, 2018
@grundleborg
Copy link
Contributor

@jwilander I think this needs a rebase.

@jwilander jwilander merged commit 655bb53 into master Nov 1, 2018
@jwilander jwilander deleted the flux-utils branch November 1, 2018 17:50
mickmister pushed a commit to mickmister/mattermost-webapp that referenced this pull request Nov 6, 2018
@jwilander @mickmister
Remove flux store usages from utils (mattermost#1952)
de0117a
mickmister pushed a commit to mickmister/mattermost-webapp that referenced this pull request Nov 6, 2018
@jwilander @mickmister
Update mattermost-redux to latest (mattermost#1960)
7379e9d 
Remove last flux store usage from actions (mattermost#1951)

* Remove flus usages from diagnostics

* Remove flux usages from status actions

* Convert status actions to redux actions and add tests

* Updates per feedback

* Update per feedback

MM-12579 Migration of team_actions to be pure redux (mattermost#1887)

* MM-12579 Migration of team_actions to redux actions

Remove updateTeam legacy actions
 * Removing are we not using this.

Remove createTeam legacy action
 * Removing as we are not using this.

Remove getTeamMembersForUser legacy action
 * Using mattermost-redux now.

Remove getTeamsForUser legacy action
 * Using mattermost-redux now.

Remove checkIfTeams legacy actions
 * Removing as we are not using this.

* Remove wrapper.update

* Fix review comments

* Review comments

* Fix rebase updates

* Changes after rebase

  * move actions for mange_modal to its connected component

* Revert process tick

* Change async to done

MM-12807 Fix clicking on multiselect items (mattermost#1965)

* Fix clicking on multiselect items

* Update snapshots

MM-12585 Complete migration of file_actions to redux actions (mattermost#1955)

remove the setting link and dont render the settings page for a plugin if dont need (mattermost#1872)

* remove the setting link and dont render the settings page for a plugin if dont need

* add tests for admin_sidebar

MM-12810 Fix for redirection is path is not root (mattermost#1963)

Migrated removed_from_channel_modal to be Pure and use Redux (mattermost#1839)

* Migrated to redux
* Removed usage of BrowserStore and jQuery
* Added usage of react-bootstrap's Modal and openModal/closeModal
actions
* Added unit tests

migrate increasePostVisibility into redux-style action (mattermost#1958)

showFlaggedPosts uses redux (mattermost#1953)

Fixed tests

Fixed tests

fixes

Remove flux store usages from channel_actions.jsx (mattermost#1925)

change @undefined to Someone in combined system messages (mattermost#1949)

add channel header dropdown page object and some tests to channel header (mattermost#1947)

Reset state properly when cancelling notifaction settings (mattermost#1978)

MM-12815: Stop using permissions-deprecated config settings in web app (mattermost#1970)

* Remove RestrictTeamInvite.

* Do EnableOnlyAdminIntegrations

* Do EnableTeamCreation.

* Do AllowEditPost.

* Cleanup SelectTeam component use of permissions.

Fixing users not searchable when adding user to a channel. (mattermost#1977)

Remove flux store usages from websocket_actions.jsx (mattermost#1948)

* Remove BrowserStore usages and convert removed from channel modal

* Remove ChannelStore

* Remove PreferenceStore

* Remove TeamStore and fix redirect on leave team

* Remove UserStore

* Clean up import

* Fix merge

* Update tests

add build discader to avoid disk full issues in jenkins (mattermost#1973)

MM-12429 Add LDAP/AD create account label when redirected from sign-up to login (mattermost#1972)

* Add LDAP/AD create account label when redirected from sign-up to login

* Use URLSearchParams for query string construction

* Update alert colors and remove icon

MM-12838: Make hashtag highlighting case insensitive. (mattermost#1982)

Remove flux store usages from utils (mattermost#1952)

MM-12677 Removing SuggestionStore (mattermost#1932)

* Removing SuggestionStore.

* Fixing clicking mention in popover.

* Fixing laggy text manipulation.

* Feedback fixes

Removing ErrorStore. (mattermost#1976)
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Nov 17, 2018
JayaKrishnaNamburu pushed a commit to JayaKrishnaNamburu/mattermost-webapp that referenced this pull request Dec 3, 2018
@jwilander @JayaKrishnaNamburu
Remove flux store usages from utils (mattermost#1952)
68f3c58
JayaKrishnaNamburu pushed a commit to JayaKrishnaNamburu/mattermost-webapp that referenced this pull request Dec 3, 2018
@jwilander @JayaKrishnaNamburu
Remove flux store usages from utils (mattermost#1952)
6a15e83
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grundleborg grundleborg grundleborg approved these changes

@sudheerDev sudheerDev sudheerDev approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Milestone
No milestone
6 participants
@jwilander @mattermod @lindy65 @grundleborg @sudheerDev @amyblais