Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-9602 Update showFlaggedPosts action to use redux #1953

Merged
merged 1 commit into from
Oct 30, 2018
Merged

MM-9602 Update showFlaggedPosts action to use redux #1953

merged 1 commit into from
Oct 30, 2018

Conversation

fraziern
Copy link
Contributor

Summary

Redux action 'getFlaggedPosts' is used by mattermost-mobile, but not mattermost-webapp. Changes are made to the 'showFlaggedPosts' view action so that the webapp uses redux instead of the webapp 'getFlaggedPosts' or 'showFlaggedPosts' actions.

The webapp's view action 'getFlaggedPosts' is superfluous so was deleted.

Ticket Link

mattermost/mattermost#8497

Checklist

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit tests passed
  • Added or updated unit tests (required for all new features)

@fraziern fraziern force-pushed the MM-9602 branch 2 times, most recently from 007cc52 to 2b8cb6c Compare October 28, 2018 12:44
@fraziern
showFlaggedPosts uses redux
065b057 
Fixed tests

Fixed tests

fixes
@jwilander jwilander added 2: Dev Review Requires review by a core commiter Hacktoberfest labels Oct 28, 2018
@jwilander jwilander added 3: QA Review Requires review by a QA tester Setup Old Test Server Triggers the creation of a test server labels Oct 28, 2018
@jwilander
Copy link
Member

QA, can we do a quick smoke test of flagged posts?

@mattermost mattermost deleted a comment from mattermod Oct 29, 2018
@mattermost mattermost deleted a comment from mattermod Oct 29, 2018
@lindy65 lindy65 added Setup Old Test Server Triggers the creation of a test server and removed Setup Old Test Server Triggers the creation of a test server labels Oct 29, 2018
@mattermost mattermost deleted a comment from mattermod Oct 29, 2018
@mattermost mattermost deleted a comment from mattermod Oct 29, 2018
@jwilander jwilander added Setup Old Test Server Triggers the creation of a test server and removed Setup Old Test Server Triggers the creation of a test server labels Oct 29, 2018
@jwilander
Copy link
Member

@lindy65 test server is up

lieut-data
lieut-data approved these changes Oct 29, 2018
View reviewed changes
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

actions/views/rhs.js
} catch (error) {
dispatch({type: ActionTypes.SEARCH_FLAGGED_POSTS_FAILURE, error});
}
dispatch({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first, I was thinking we should rup out handling of ActionTypes.SEARCH_FLAGGED_POSTS_REQUEST everywhere too, until I realized that mattermost-redux uses an action type of the same name here, so everything "just works", though "scary" to see the action name overlap.

In the future, it would be interesting to see if there is a parallel change for pinned posts to eliminate the get(PrePost)RHSSearchActions methods altogether.

@lindy65
Copy link
Contributor

lindy65 commented Oct 29, 2018

Thanks @fraziern @jwilander

  • Tested flagging and unflagging posts from center channel, RHS, expanded RHS, search results and permalink view.
  • Tested across public, private, DM and GM channels as well as that flagged posts in DM/GM's do show across teams.

I did not find any issues 👍

@lindy65 lindy65 added Tests/Done Release tests have been written and removed 3: QA Review Requires review by a QA tester labels Oct 29, 2018
@jwilander jwilander removed the Setup Old Test Server Triggers the creation of a test server label Oct 29, 2018
@mattermod
Copy link
Contributor

Spinmint test server destroyed

@saturninoabril saturninoabril added Setup Old Test Server Triggers the creation of a test server and removed Setup Old Test Server Triggers the creation of a test server labels Oct 30, 2018
saturninoabril
saturninoabril approved these changes Oct 30, 2018
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I also checked the loading icon when searching flagged posts and it's working fine.

Thanks @fraziern!

@saturninoabril saturninoabril added the 4: Reviews Complete All reviewers have approved the pull request label Oct 30, 2018
@saturninoabril saturninoabril removed the 2: Dev Review Requires review by a core commiter label Oct 30, 2018
@mattermost mattermost deleted a comment from mattermod Oct 30, 2018
@mattermost mattermost deleted a comment from mattermod Oct 30, 2018
@saturninoabril saturninoabril merged commit 1a60ab3 into mattermost:master Oct 30, 2018
@fraziern fraziern mentioned this pull request Nov 2, 2018
Closed
3 tasks
mickmister pushed a commit to mickmister/mattermost-webapp that referenced this pull request Nov 6, 2018
@fraziern @mickmister
showFlaggedPosts uses redux (mattermost#1953)
b64a93a 
Fixed tests

Fixed tests

fixes
mickmister pushed a commit to mickmister/mattermost-webapp that referenced this pull request Nov 6, 2018
@jwilander @mickmister
Update mattermost-redux to latest (mattermost#1960)
7379e9d 
Remove last flux store usage from actions (mattermost#1951)

* Remove flus usages from diagnostics

* Remove flux usages from status actions

* Convert status actions to redux actions and add tests

* Updates per feedback

* Update per feedback

MM-12579 Migration of team_actions to be pure redux (mattermost#1887)

* MM-12579 Migration of team_actions to redux actions

Remove updateTeam legacy actions
 * Removing are we not using this.

Remove createTeam legacy action
 * Removing as we are not using this.

Remove getTeamMembersForUser legacy action
 * Using mattermost-redux now.

Remove getTeamsForUser legacy action
 * Using mattermost-redux now.

Remove checkIfTeams legacy actions
 * Removing as we are not using this.

* Remove wrapper.update

* Fix review comments

* Review comments

* Fix rebase updates

* Changes after rebase

  * move actions for mange_modal to its connected component

* Revert process tick

* Change async to done

MM-12807 Fix clicking on multiselect items (mattermost#1965)

* Fix clicking on multiselect items

* Update snapshots

MM-12585 Complete migration of file_actions to redux actions (mattermost#1955)

remove the setting link and dont render the settings page for a plugin if dont need (mattermost#1872)

* remove the setting link and dont render the settings page for a plugin if dont need

* add tests for admin_sidebar

MM-12810 Fix for redirection is path is not root (mattermost#1963)

Migrated removed_from_channel_modal to be Pure and use Redux (mattermost#1839)

* Migrated to redux
* Removed usage of BrowserStore and jQuery
* Added usage of react-bootstrap's Modal and openModal/closeModal
actions
* Added unit tests

migrate increasePostVisibility into redux-style action (mattermost#1958)

showFlaggedPosts uses redux (mattermost#1953)

Fixed tests

Fixed tests

fixes

Remove flux store usages from channel_actions.jsx (mattermost#1925)

change @undefined to Someone in combined system messages (mattermost#1949)

add channel header dropdown page object and some tests to channel header (mattermost#1947)

Reset state properly when cancelling notifaction settings (mattermost#1978)

MM-12815: Stop using permissions-deprecated config settings in web app (mattermost#1970)

* Remove RestrictTeamInvite.

* Do EnableOnlyAdminIntegrations

* Do EnableTeamCreation.

* Do AllowEditPost.

* Cleanup SelectTeam component use of permissions.

Fixing users not searchable when adding user to a channel. (mattermost#1977)

Remove flux store usages from websocket_actions.jsx (mattermost#1948)

* Remove BrowserStore usages and convert removed from channel modal

* Remove ChannelStore

* Remove PreferenceStore

* Remove TeamStore and fix redirect on leave team

* Remove UserStore

* Clean up import

* Fix merge

* Update tests

add build discader to avoid disk full issues in jenkins (mattermost#1973)

MM-12429 Add LDAP/AD create account label when redirected from sign-up to login (mattermost#1972)

* Add LDAP/AD create account label when redirected from sign-up to login

* Use URLSearchParams for query string construction

* Update alert colors and remove icon

MM-12838: Make hashtag highlighting case insensitive. (mattermost#1982)

Remove flux store usages from utils (mattermost#1952)

MM-12677 Removing SuggestionStore (mattermost#1932)

* Removing SuggestionStore.

* Fixing clicking mention in popover.

* Fixing laggy text manipulation.

* Feedback fixes

Removing ErrorStore. (mattermost#1976)
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Nov 17, 2018
JayaKrishnaNamburu pushed a commit to JayaKrishnaNamburu/mattermost-webapp that referenced this pull request Dec 3, 2018
@fraziern @JayaKrishnaNamburu
showFlaggedPosts uses redux (mattermost#1953)
cecd22e 
Fixed tests

Fixed tests

fixes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lieut-data lieut-data lieut-data approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation Hacktoberfest Tests/Done Release tests have been written
Projects
None yet
Milestone
No milestone
7 participants
@fraziern @jwilander @lindy65 @mattermod @lieut-data @saturninoabril @amyblais