Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Remove flux store usages from websocket_actions.jsx #1948

Merged
merged 8 commits into from
Oct 31, 2018
Merged

Remove flux store usages from websocket_actions.jsx #1948

merged 8 commits into from
Oct 31, 2018

Conversation

jwilander
Copy link
Member

Summary

Remove flux store usages from websocket_actions.jsx.

@lindy65, could you regression test the following logged in on multiple browsers: leaving a team, view an unread channel on the same team, updating a user, deleting a team, getting removed from a channel you're viewing.

Ticket Link

Part of https://mattermost.atlassian.net/browse/MM-12564

Checklist

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed

@jwilander jwilander added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Oct 26, 2018
@jwilander
Copy link
Member Author

Dev reviewers, might be easier to look at commit by commit

@jwilander jwilander added the Setup Old Test Server Triggers the creation of a test server label Oct 26, 2018
@mattermost mattermost deleted a comment from jwilander Oct 26, 2018
@lindy65
Copy link
Contributor

lindy65 commented Oct 28, 2018

@jwilander can you set up a new spinmint please? I'm getting a weird redirecting loop and login page is not loading. (For future, how do I destroy an existing spinmint and create a new one?)

@jwilander jwilander removed the Setup Old Test Server Triggers the creation of a test server label Oct 28, 2018
@mattermost mattermost deleted a comment from mattermod Oct 28, 2018
@mattermost mattermost deleted a comment from mattermod Oct 28, 2018
@mattermost mattermost deleted a comment from mattermod Oct 28, 2018
@jwilander
Copy link
Member Author

@lindy65 if you remove the label, delete all the mattermod comments and then add the label back it will generate a new spinmint for you. There seems to be some sort of issue with mattermod at the moment, however

@lindy65
Copy link
Contributor

lindy65 commented Oct 29, 2018

Thanks @jwilander I'll try again in a while

@lindy65 lindy65 added the Setup Old Test Server Triggers the creation of a test server label Oct 29, 2018
@mattermod
Copy link
Contributor

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

@mattermod
Copy link
Contributor

Spinmint test server created at: https://i-03cfad0a46dd1e50d.test.spinmint.com

Test Admin Account: Username: sysadmin | Password: sysadmin

Test User Account: Username: user-1 | Password: user-1

Instance ID: i-03cfad0a46dd1e50d

@lindy65
Copy link
Contributor

lindy65 commented Oct 29, 2018

Thanks @jwilander

I tested being logged in on multiple browsers:

  1. leaving a team,
    • in the browser window I leave the team from, I get the following error message and am not directly taken to the remaining team I belong to. After clicking on "Back to Town Square", I am taken to Town Square of the remaining team I belong to. (In the other browser window I am observing from, I am taken to Town Square of the remaining team I am on (as expected) without the attached error message.)

image

  • This exact scenario does NOT reproduce on master but there is a bug on master where when you leave a team, the team icon in the sidebar disappears along with public and private channels but the team name is still at the top of the LHS next to your username

image

  • I'm unsure whether the issue on master is causing the issue on this particular PR or whether they're unrelated? Let me know and I can put in a separate ticket for the issue on master.

  1. view an unread channel on the same team,

    • no issues found

  2. updating a user,

    • no issues found

  3. deleting a team,

    • I'm not able to test this yet as I believe this is done via CLI?

  4. getting removed from a channel you're viewing.

    • no issues found (message advising I've been removed from the channel is displayed as expected).

@jwilander
Copy link
Member Author

Thanks @lindy65, I'll check 1)

@jwilander
Copy link
Member Author

@lindy65 does 1) reproduce for you every time? I can't seem to reproduce it locally or on the spinmint even when throttling my connection

@lindy65
Copy link
Contributor

lindy65 commented Oct 29, 2018

Hey @jwilander - I've just retested and, as sods law would have it, I am no longer able to reproduce :( Tried both sysadmin and user-1 accounts, Chrome, Firefox and IE11 and couldn't get the issue to reproduce again...

@lindy65 lindy65 added Tests/Done Release tests have been written and removed 3: QA Review Requires review by a QA tester labels Oct 29, 2018
@jwilander jwilander removed the Setup Old Test Server Triggers the creation of a test server label Oct 30, 2018
@mattermod
Copy link
Contributor

Spinmint test server destroyed

@hmhealey hmhealey removed the 2: Dev Review Requires review by a core commiter label Oct 31, 2018
@hmhealey hmhealey merged commit 8b8b7a0 into master Oct 31, 2018
@hmhealey hmhealey deleted the flux-store-websocket branch October 31, 2018 19:14
mickmister pushed a commit to mickmister/mattermost-webapp that referenced this pull request Nov 6, 2018
@jwilander @mickmister
Remove flux store usages from websocket_actions.jsx (mattermost#1948)
6595726 
* Remove BrowserStore usages and convert removed from channel modal

* Remove ChannelStore

* Remove PreferenceStore

* Remove TeamStore and fix redirect on leave team

* Remove UserStore

* Clean up import

* Fix merge

* Update tests
mickmister pushed a commit to mickmister/mattermost-webapp that referenced this pull request Nov 6, 2018
@jwilander @mickmister
Update mattermost-redux to latest (mattermost#1960)
7379e9d 
Remove last flux store usage from actions (mattermost#1951)

* Remove flus usages from diagnostics

* Remove flux usages from status actions

* Convert status actions to redux actions and add tests

* Updates per feedback

* Update per feedback

MM-12579 Migration of team_actions to be pure redux (mattermost#1887)

* MM-12579 Migration of team_actions to redux actions

Remove updateTeam legacy actions
 * Removing are we not using this.

Remove createTeam legacy action
 * Removing as we are not using this.

Remove getTeamMembersForUser legacy action
 * Using mattermost-redux now.

Remove getTeamsForUser legacy action
 * Using mattermost-redux now.

Remove checkIfTeams legacy actions
 * Removing as we are not using this.

* Remove wrapper.update

* Fix review comments

* Review comments

* Fix rebase updates

* Changes after rebase

  * move actions for mange_modal to its connected component

* Revert process tick

* Change async to done

MM-12807 Fix clicking on multiselect items (mattermost#1965)

* Fix clicking on multiselect items

* Update snapshots

MM-12585 Complete migration of file_actions to redux actions (mattermost#1955)

remove the setting link and dont render the settings page for a plugin if dont need (mattermost#1872)

* remove the setting link and dont render the settings page for a plugin if dont need

* add tests for admin_sidebar

MM-12810 Fix for redirection is path is not root (mattermost#1963)

Migrated removed_from_channel_modal to be Pure and use Redux (mattermost#1839)

* Migrated to redux
* Removed usage of BrowserStore and jQuery
* Added usage of react-bootstrap's Modal and openModal/closeModal
actions
* Added unit tests

migrate increasePostVisibility into redux-style action (mattermost#1958)

showFlaggedPosts uses redux (mattermost#1953)

Fixed tests

Fixed tests

fixes

Remove flux store usages from channel_actions.jsx (mattermost#1925)

change @undefined to Someone in combined system messages (mattermost#1949)

add channel header dropdown page object and some tests to channel header (mattermost#1947)

Reset state properly when cancelling notifaction settings (mattermost#1978)

MM-12815: Stop using permissions-deprecated config settings in web app (mattermost#1970)

* Remove RestrictTeamInvite.

* Do EnableOnlyAdminIntegrations

* Do EnableTeamCreation.

* Do AllowEditPost.

* Cleanup SelectTeam component use of permissions.

Fixing users not searchable when adding user to a channel. (mattermost#1977)

Remove flux store usages from websocket_actions.jsx (mattermost#1948)

* Remove BrowserStore usages and convert removed from channel modal

* Remove ChannelStore

* Remove PreferenceStore

* Remove TeamStore and fix redirect on leave team

* Remove UserStore

* Clean up import

* Fix merge

* Update tests

add build discader to avoid disk full issues in jenkins (mattermost#1973)

MM-12429 Add LDAP/AD create account label when redirected from sign-up to login (mattermost#1972)

* Add LDAP/AD create account label when redirected from sign-up to login

* Use URLSearchParams for query string construction

* Update alert colors and remove icon

MM-12838: Make hashtag highlighting case insensitive. (mattermost#1982)

Remove flux store usages from utils (mattermost#1952)

MM-12677 Removing SuggestionStore (mattermost#1932)

* Removing SuggestionStore.

* Fixing clicking mention in popover.

* Fixing laggy text manipulation.

* Feedback fixes

Removing ErrorStore. (mattermost#1976)
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Nov 17, 2018
JayaKrishnaNamburu pushed a commit to JayaKrishnaNamburu/mattermost-webapp that referenced this pull request Dec 3, 2018
@jwilander @JayaKrishnaNamburu
Remove flux store usages from websocket_actions.jsx (mattermost#1948)
3cb828d 
* Remove BrowserStore usages and convert removed from channel modal

* Remove ChannelStore

* Remove PreferenceStore

* Remove TeamStore and fix redirect on leave team

* Remove UserStore

* Clean up import

* Fix merge

* Update tests
JayaKrishnaNamburu pushed a commit to JayaKrishnaNamburu/mattermost-webapp that referenced this pull request Dec 3, 2018
@jwilander @JayaKrishnaNamburu
Remove flux store usages from websocket_actions.jsx (mattermost#1948)
35a20a6 
* Remove BrowserStore usages and convert removed from channel modal

* Remove ChannelStore

* Remove PreferenceStore

* Remove TeamStore and fix redirect on leave team

* Remove UserStore

* Clean up import

* Fix merge

* Update tests
@hmhealey hmhealey mentioned this pull request Apr 25, 2023
Merged
@giuesposbit giuesposbit mentioned this pull request Jun 22, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hmhealey hmhealey hmhealey approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

Assignees
No one assigned
Labels
Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Milestone
No milestone
6 participants
@jwilander @lindy65 @mattermod @hmhealey @saturninoabril @amyblais