fix: do not load cache files when recompile flag is set #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, feels like a good clean solution, but I am not the best person for having an opinion on Rust code. |
kevinkassimo
reviewed
Feb 6, 2019
src/deno_dir.rs
Outdated
| maybe_source_map_filename: output_source_map_filename | ||
| .to_str() | ||
| .map(|s| s.to_string()), | ||
| maybe_source_map: maybe_source_map, |
There was a problem hiding this comment.
nit: could be simplified as
Ok(CodeFetchOutput {
// ...
maybe_source_code,
maybe_source_map,
})
ry
reviewed
Feb 6, 2019
src/deno_dir.rs
Outdated
| maybe_output_code: maybe_output_code, | ||
| maybe_source_map_filename: output_source_map_filename | ||
| .to_str() | ||
| .map(|s| s.to_string()), |
There was a problem hiding this comment.
nit: could be simplified as map(String::from) (here and elsewhere)
ry
added a commit
to ry/deno
that referenced
this pull request
Feb 9, 2019
- Add deps to --info output (denoland#1720) - Add --allow-read (denoland#1689) - Add deno.isTTY() (denoland#1622) - Add emojis to permission prompts (denoland#1684) - Add basic WebAssembly support (denoland#1677) - Add `NO_COLOR` support https://no-color.org/ (denoland#1716) - Add color exceptions (denoland#1698) - Fix: do not load cache files when recompile flag is set (denoland#1695) - Upgrade V8 to 7.4.98 (denoland#1640)
ry
added a commit
that referenced
this pull request
Feb 9, 2019
- Add deps to --info output (#1720) - Add --allow-read (#1689) - Add deno.isTTY() (#1622) - Add emojis to permission prompts (#1684) - Add basic WebAssembly support (#1677) - Add `NO_COLOR` support https://no-color.org/ (#1716) - Add color exceptions (#1698) - Fix: do not load cache files when recompile flag is set (#1695) - Upgrade V8 to 7.4.98 (#1640)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #1637 which is labeled bug.
if recompile flag is set, not load cache files,
else load cache files.
And add a test case test_code_fetch_1.