Add WebAssembly to runtime library #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also modifies the `ts_library_builder` to support inlining assets. Includes integration tests from @sh7dm
dsseng
approved these changes
Feb 5, 2019
daynin
approved these changes
Feb 5, 2019
ry
approved these changes
Feb 5, 2019
| assert(targetSourceFile.getNamespace("Qat") != null); | ||
| const qatNamespace = targetSourceFile.getNamespaceOrThrow("Qat"); | ||
| assert(qatNamespace.getClass("Foo") != null); | ||
| }); |
ry
added a commit
to ry/deno
that referenced
this pull request
Feb 9, 2019
- Add deps to --info output (denoland#1720) - Add --allow-read (denoland#1689) - Add deno.isTTY() (denoland#1622) - Add emojis to permission prompts (denoland#1684) - Add basic WebAssembly support (denoland#1677) - Add `NO_COLOR` support https://no-color.org/ (denoland#1716) - Add color exceptions (denoland#1698) - Fix: do not load cache files when recompile flag is set (denoland#1695) - Upgrade V8 to 7.4.98 (denoland#1640)
ry
added a commit
that referenced
this pull request
Feb 9, 2019
- Add deps to --info output (#1720) - Add --allow-read (#1689) - Add deno.isTTY() (#1622) - Add emojis to permission prompts (#1684) - Add basic WebAssembly support (#1677) - Add `NO_COLOR` support https://no-color.org/ (#1716) - Add color exceptions (#1698) - Fix: do not load cache files when recompile flag is set (#1695) - Upgrade V8 to 7.4.98 (#1640)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also modifies the
ts_library_builderto support inlining assets.We are going to have to manage this slightly different way than other items, because it isn't describing something we are adding to the runtime, it is describing something that is already there. In all other cases that is something we have leveraged the libs that come with TypeScript. We could include the
@typesbut it would be a pain in the long term. I hope that TypeScript re-adds these as a lib since they have broad browser support now. The previous issue at TypeScript was closed based on it being experimental.cc/ @ry @sh7dm