Add isTTY function #1622
Merged
Add isTTY function #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this should take the file as an argument, either file.isTTY or isTTY(file), specifically you may want to be able to see if stdout or stderr is a tty. Note: You can use atty for this, I think there's no need to use libc/unsafe. |
ry
reviewed
Jan 29, 2019
ry
reviewed
Jan 29, 2019
|
Needs tests. Probably custom tests written in python... |
|
Are stdin, stdout and stderr the only files that can be TTY? |
hayd
reviewed
Jan 30, 2019
Will do! |
hayd
reviewed
Jan 30, 2019
hayd
reviewed
Feb 1, 2019
ry
reviewed
Feb 1, 2019
ry
reviewed
Feb 1, 2019
ry
reviewed
Feb 1, 2019
ry
reviewed
Feb 1, 2019
ry
reviewed
Feb 1, 2019
ry
reviewed
Feb 1, 2019
ry
reviewed
Feb 1, 2019
|
@ry thanks for help, I've fixed all problems |
ry
reviewed
Feb 2, 2019
ry
reviewed
Feb 2, 2019
ry
reviewed
Feb 2, 2019
ry
reviewed
Feb 2, 2019
ry
reviewed
Feb 2, 2019
ry
reviewed
Feb 2, 2019
ry
reviewed
Feb 2, 2019
ry
reviewed
Feb 2, 2019
ry
reviewed
Feb 2, 2019
ry
added a commit
to ry/deno
that referenced
this pull request
Feb 9, 2019
- Add deps to --info output (denoland#1720) - Add --allow-read (denoland#1689) - Add deno.isTTY() (denoland#1622) - Add emojis to permission prompts (denoland#1684) - Add basic WebAssembly support (denoland#1677) - Add `NO_COLOR` support https://no-color.org/ (denoland#1716) - Add color exceptions (denoland#1698) - Fix: do not load cache files when recompile flag is set (denoland#1695) - Upgrade V8 to 7.4.98 (denoland#1640)
ry
added a commit
that referenced
this pull request
Feb 9, 2019
- Add deps to --info output (#1720) - Add --allow-read (#1689) - Add deno.isTTY() (#1622) - Add emojis to permission prompts (#1684) - Add basic WebAssembly support (#1677) - Add `NO_COLOR` support https://no-color.org/ (#1716) - Add color exceptions (#1698) - Fix: do not load cache files when recompile flag is set (#1695) - Upgrade V8 to 7.4.98 (#1640)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1607.
To test run in REPL: