Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust loads from cache with --recompile #1637

Closed
kitsonk opened this issue Feb 1, 2019 · 2 comments
Closed

Rust loads from cache with --recompile #1637

kitsonk opened this issue Feb 1, 2019 · 2 comments
Labels
bug Something isn't working correctly
Milestone

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Feb 1, 2019

In cleaning up the compiler, I noticed while passing the --recompile flag with debug, that Rust will still attempt to load the local cache of a file even though it should "know" that it is not going to be used. For example:

DEBUG JS - args [ "tests/005_more_imports.ts" ]
DEBUG RS - code_fetch. specifier tests/005_more_imports.ts referrer .
DEBUG RS - resolve_module specifier tests/005_more_imports.ts referrer .
DEBUG RS - module_name: /Users/kkelly/github/deno/tests/005_more_imports.ts, filename: /Users/kkelly/github/deno/tests/005_more_imports.ts
DEBUG RS - fetch local or reload /Users/kkelly/github/deno/tests/005_more_imports.ts is_module_remote false
DEBUG RS - found local source 
DEBUG RS - load_cache code: /Users/kkelly/.deno/gen/e74a8e8c25c18115805245674c5d1a615441f4b7.js map: /Users/kkelly/.deno/gen/e74a8e8c25c18115805245674c5d1a615441f4b7.js.map
@kitsonk
Copy link
Contributor Author

kitsonk commented Feb 1, 2019

Actually it is "worse" than that, because on the code_fetch from the compiler, it loads it a second time:

DEBUG JS - args [ "tests/005_more_imports.ts" ]
DEBUG RS - code_fetch. specifier tests/005_more_imports.ts referrer .
DEBUG RS - resolve_module specifier tests/005_more_imports.ts referrer .
DEBUG RS - module_name: /Users/kkelly/github/deno/tests/005_more_imports.ts, filename: /Users/kkelly/github/deno/tests/005_more_imports.ts
DEBUG RS - fetch local or reload /Users/kkelly/github/deno/tests/005_more_imports.ts is_module_remote false
DEBUG RS - found local source 
DEBUG RS - load_cache code: /Users/kkelly/.deno/gen/e74a8e8c25c18115805245674c5d1a615441f4b7.js map: /Users/kkelly/.deno/gen/e74a8e8c25c18115805245674c5d1a615441f4b7.js.map
DEBUG RS - >>>>> compile_sync START
...
DEBUG TS - os.ts codeFetch tests/005_more_imports.ts .
DEBUG RS - code_fetch. specifier tests/005_more_imports.ts referrer .
DEBUG RS - resolve_module specifier tests/005_more_imports.ts referrer .
DEBUG RS - module_name: /Users/kkelly/github/deno/tests/005_more_imports.ts, filename: /Users/kkelly/github/deno/tests/005_more_imports.ts
DEBUG RS - fetch local or reload /Users/kkelly/github/deno/tests/005_more_imports.ts is_module_remote false
DEBUG RS - found local source 
DEBUG RS - load_cache code: /Users/kkelly/.deno/gen/e74a8e8c25c18115805245674c5d1a615441f4b7.js map: /Users/kkelly/.deno/gen/e74a8e8c25c18115805245674c5d1a615441f4b7.js.map

@ry ry added this to the v0.3 milestone Feb 2, 2019
@ry ry added the bug Something isn't working correctly label Feb 2, 2019
@kitsonk
Copy link
Contributor Author

kitsonk commented Feb 7, 2019

Closed in 37b0574

@ry ry closed this as completed Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

2 participants