Upgrade V8 to 7.4.98 (kKeep fix) #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayd
reviewed
Feb 1, 2019
adb0011
to
cf70997
Compare
|
Basically no speed up, unfortunately: Probably we need to exercise the TS compiler before snapshotting to get optimized code. |
|
Note that the patch we need was reverted earlier today: https://bugs.chromium.org/p/v8/issues/detail?id=8761#c6 |
I looked at it before, it is semi tricky, we might have to do something silly like actually compile some code and emit it. |
|
Fix has been landed in V8 7.4.98. This patch is ready to land. |
piscisaureus
approved these changes
Feb 7, 2019
| @@ -255,8 +255,7 @@ def download_clang_format(): | |||
|
|
|||
| # Download clang by calling the clang update script. | |||
| def download_clang(): | |||
| run(['python', | |||
| tp('v8/tools/clang/scripts/update.py'), '--if-needed'], | |||
| run(['python', tp('v8/tools/clang/scripts/update.py')], | |||
There was a problem hiding this comment.
Dont think so / they seem to have removed it.
ry
added a commit
to ry/deno
that referenced
this pull request
Feb 9, 2019
- Add deps to --info output (denoland#1720) - Add --allow-read (denoland#1689) - Add deno.isTTY() (denoland#1622) - Add emojis to permission prompts (denoland#1684) - Add basic WebAssembly support (denoland#1677) - Add `NO_COLOR` support https://no-color.org/ (denoland#1716) - Add color exceptions (denoland#1698) - Fix: do not load cache files when recompile flag is set (denoland#1695) - Upgrade V8 to 7.4.98 (denoland#1640)
ry
added a commit
that referenced
this pull request
Feb 9, 2019
- Add deps to --info output (#1720) - Add --allow-read (#1689) - Add deno.isTTY() (#1622) - Add emojis to permission prompts (#1684) - Add basic WebAssembly support (#1677) - Add `NO_COLOR` support https://no-color.org/ (#1716) - Add color exceptions (#1698) - Fix: do not load cache files when recompile flag is set (#1695) - Upgrade V8 to 7.4.98 (#1640)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #814
https://bugs.chromium.org/p/v8/issues/detail?id=8761