Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deps to --info output. #1720

Merged
merged 3 commits into from
Feb 9, 2019
Merged

Add deps to --info output. #1720

merged 3 commits into from
Feb 9, 2019

Conversation

ry
Copy link
Member

@ry ry commented Feb 8, 2019

Move module stuff into its own file.
cc @kevinkassimo

Move module stuff into its own file.
src/modules.rs Outdated Show resolved Hide resolved
src/modules.rs Outdated Show resolved Hide resolved
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the first pass.
That said, I find the tree formatting very barebones to the point where the output is hard to interpret. I would suggest opening an issue that calls for improvement.

impl fmt::Display for Deps {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
for _i in 0..self.depth {
write!(f, "| ")?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bar | is not helpful IMO.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very open to reformatting

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Barebones:

root
  aaa
    alpha
      first
      second
    beta
      foo
      bar
  bbb
    something

Basic:

root
- aaa
  * alpha
    - first
    - second
  * bbb
    - foo
    - bar
- bbb
  * something

Advanced:

root
├─ aaa
│  ├─ alpha
│  │  ├─ first
│  │  └─ second
│  └─ bbb
│     ├─ foo
│     └─ bar
└─ bbb
   └─ something

Copy link
Member Author

@ry ry Feb 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"advanced" looks fine

@ry ry merged commit 99ce807 into denoland:master Feb 9, 2019
@ry ry deleted the deps branch February 9, 2019 02:37
ry added a commit to ry/deno that referenced this pull request Feb 9, 2019
- Add deps to --info output (denoland#1720)
- Add --allow-read (denoland#1689)
- Add deno.isTTY() (denoland#1622)
- Add emojis to permission prompts (denoland#1684)
- Add basic WebAssembly support (denoland#1677)
- Add `NO_COLOR` support https://no-color.org/ (denoland#1716)
- Add color exceptions (denoland#1698)
- Fix: do not load cache files when recompile flag is set (denoland#1695)
- Upgrade V8 to 7.4.98 (denoland#1640)
ry added a commit that referenced this pull request Feb 9, 2019
- Add deps to --info output (#1720)
- Add --allow-read (#1689)
- Add deno.isTTY() (#1622)
- Add emojis to permission prompts (#1684)
- Add basic WebAssembly support (#1677)
- Add `NO_COLOR` support https://no-color.org/ (#1716)
- Add color exceptions (#1698)
- Fix: do not load cache files when recompile flag is set (#1695)
- Upgrade V8 to 7.4.98 (#1640)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants