Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upgrade to v3] move page content to main guide #8646

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Conversation

sarah11918
Copy link
Member

@sarah11918 sarah11918 commented Jun 24, 2024

Description (required)

Both the Images guide and the View Transitions guide still had upgrade advice specific to upgrading from v2.x to v3.0.

This PR moves that specific content to the v3 upgrade guide itself, as it's no longer important to have on the individual page.

FOR TRANSLATORS: There is minimal content change here, but there are changes to be aware of:

  • Heading Levels: Entire sections from the two guide pages have been copy/pasted with no text changes BUT, all heading levels have increased by one.
  • Links: The links at the top of the v3 upgrade guide now link to the (new) headings at the bottom of the page, not to the original heading content on the external pages; also some internal links changed
  • /de/ and /ru/: Some sentences or links have been removed since it is not possible to update the old links. Check the respective commits for your specific languages, and you can add the sentences/links back in when your pages are updated!

Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 2:53pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Jun 24, 2024 2:53pm

@sarah11918 sarah11918 added the improve documentation Enhance existing documentation (e.g. add an example, improve description) label Jun 24, 2024
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jun 24, 2024

Lunaria Status Overview

🌑 This pull request will not trigger status changes.

Learn more

Lunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: i18nIgnore.

You can change this by either removing the keyword above from the PR's title, or modifying the ignoreKeywords property in your Lunaria configuration file.

Tracked Files

Note

The notes below indicate what would happen if the pull request is merged when triggering status changes. Since a ignored keyword was found in the PR's title, the status changes indicated below won't be applied.

Locale File Note
de guides/upgrade-to/v3.mdx Localization changed, will be marked as complete.
en guides/images.mdx Source changed, localizations will be marked as outdated.
en guides/upgrade-to/v3.mdx Source changed, localizations will be marked as outdated.
en guides/view-transitions.mdx Source changed, localizations will be marked as outdated.
ru guides/upgrade-to/v3.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jun 24, 2024
@sarah11918 sarah11918 changed the title [upgrade to v3] move page content to main guide [i18nIgnore][upgrade to v3] move page content to main guide Jun 24, 2024
@sarah11918 sarah11918 changed the title [i18nIgnore][upgrade to v3] move page content to main guide [upgrade to v3] move page content to main guide Jun 24, 2024
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Here's your daily dose of Lunaria arcana to use:

@lunaria-track:src/content/docs/en/guides/upgrade-to/v3.mdx;src/content/docs/en/guides/view-transitions.mdx;src/content/docs/en/guides/images.mdx

@sarah11918 sarah11918 merged commit e87c73e into main Jun 24, 2024
8 checks passed
@sarah11918 sarah11918 deleted the old-upgrade-guides branch June 24, 2024 15:16
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Jun 25, 2024
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Jun 25, 2024
yanthomasdev added a commit that referenced this pull request Jun 25, 2024
* i18n(fr): Update guides/astro-db from #8478

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/backend from #8450

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/backend/google-firebase from #8422

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/cms/apostrophecms from #8480

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/cms/builderio from #8259

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/cms/directus from #8647

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/cms/ghost from #8518

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/cms/statamic from #7119

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/content-collections from #8447

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/data-fetching from #8210

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/deploy/cloudflare from #8421

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/deploy/netlify from #8233

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/deploy/render from #8233

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/deploy/vercel from #8217 (and fix little typos)

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/environment-variables from #8533

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/environment-variables from #8611

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/images from #8447 #8646

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide from #8575

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/cloudflare from #8211

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/lit from #8270

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/markdoc from #8167 (Steeeeps)

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/preact from #8644

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/react from #8038

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/vue from #8295

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/markdown-content from #7218

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/markdown-content from #8167 #8239

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/middleware from #8572

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/prefetch from #8246

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/routing from #8466

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/rss from #8632

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/testing from #8369

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/view-transitions from #8646

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix typo in routing.mdx

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix links ?

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix badge

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix badge

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix tabs

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix tabs

Signed-off-by: Thomas Bonnet <[email protected]>

* Update src/content/docs/fr/guides/environment-variables.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/integrations-guide/lit.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/integrations-guide/vue.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/markdown-content.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/middleware.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/testing.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/testing.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/testing.mdx

Co-authored-by: pioupia <[email protected]>

* i18n(fr): Fix links

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `tutorial/6-islands` because CI links err

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): fix links

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): fix links

Signed-off-by: Thomas Bonnet <[email protected]>

---------

Signed-off-by: Thomas Bonnet <[email protected]>
Co-authored-by: pioupia <[email protected]>
Co-authored-by: Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! improve documentation Enhance existing documentation (e.g. add an example, improve description)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants