Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sentry Integration as a Recipe #8450

Merged
merged 20 commits into from
Jun 19, 2024
Merged

Add Sentry Integration as a Recipe #8450

merged 20 commits into from
Jun 19, 2024

Conversation

smeubank
Copy link
Contributor

@smeubank smeubank commented Jun 6, 2024

Description (required)

As the official monitoring partner, Sentry should be listed as one of the top recipes, to show to best integration Astro with Sentry, and link to our docs for alatest information

Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jun 19, 2024 6:31pm

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jun 6, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/backend.mdx Source changed, localizations will be marked as outdated.
en guides/backend/sentry.mdx Source added, will be tracked.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918
Copy link
Member

Updating branch to get the latest version of docs with a working link checker!

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @smeubank ! Thank you for this submission!

I've left some comments for this page to make it more consistent with our docs style! If you'd like to review and make the appropriate changes yourself, you are welcome to!

If you would prefer I just handle making changes and publishing on my end (if you'd like this off of your plate and out of your hands), then I am also happy to do the rework and publish without bothering you again! 😄

Just let me know!

src/content/docs/en/guides/monitor/sentry.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/monitor/sentry.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/monitor/sentry.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/monitor/sentry.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/monitor/sentry.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/monitor/sentry.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/monitor/sentry.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/monitor/sentry.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/monitor/sentry.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/monitor/sentry.mdx Outdated Show resolved Hide resolved
@smeubank
Copy link
Contributor Author

If you would prefer I just handle making changes and publishing on my end (if you'd like this off of your plate and out of your hands), then I am also happy to do the rework and publish without bothering you again! 😄

hi @sarah11918 it would be great if you can make the changes 😅

and you are not bothering me at all! These are all greate suggestions. If you are fine to make the changes, please do, if you need any more feedback from me. I am also happy to jump on a call and we can knock this out :)

@sarah11918
Copy link
Member

@smeubank Sounds good then! I'm happy to make changes and just ask you specific questions that I might not know the answer to about how things work. At the end, I'll give you a final draft for your review, and I can make changes based on your feedback! 🙌

@sarah11918
Copy link
Member

sarah11918 commented Jun 14, 2024

OK @smeubank ! Here's what we've got, for your review!

Here's the preview of your page, and you can let me know if you'd change anything, or if you approve, then we can move ahead with this as soon as I hear from you!

https://docs-git-fork-smeubank-main-astrodotbuild.vercel.app/en/guides/backend/sentry/

Copy link
Sponsor Member

@kevinzunigacuellar kevinzunigacuellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the guide—amazing DX experience! I left a few comments expanding on keys/credentials, as they are among the most requested information when setting up a new SDK.

src/content/docs/en/guides/backend/sentry.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/backend/sentry.mdx Outdated Show resolved Hide resolved
@sarah11918
Copy link
Member

Excellent suggestions, @kevinzunigacuellar ! Great additions, as always!

(@smeubank , Kevin is one of our maintainers who regularly does the walk-throughs of these guides replicating the steps to ensure accuracy and thinking of the user experience.)

@sarah11918
Copy link
Member

Hi @smeubank ! With @kevinzunigacuellar 's additional help after performing a walk through of the steps, I think this is good to go!

Let me know if there are any inaccuracies/edits. Once you sign off on a final review (you can view your page directly here: https://docs-git-fork-smeubank-main-astrodotbuild.vercel.app/en/guides/backend/sentry/ ) then we'll publish it to docs!

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. 3rd-party guide Community submitted CMS, deploy, backend etc. guide Docs is happy if OP is happy! Please review your PR and make sure you accept our proposed changes! labels Jun 17, 2024
@sarah11918
Copy link
Member

Hi @smeubank ! I don't want to hold up publishing this any more than we have to, so I'm going to go ahead and publish now and if you find something that needs fixing/editing, we can simply correct it at that time!

Looking forward to having a Sentry guide, and thank you for contributing to docs! 🥳

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Jun 19, 2024
@sarah11918 sarah11918 merged commit e082696 into withastro:main Jun 19, 2024
8 checks passed
@smeubank
Copy link
Contributor Author

Hi @smeubank ! I don't want to hold up publishing this any more than we have to, so I'm going to go ahead and publish now and if you find something that needs fixing/editing, we can simply correct it at that time!

Looking forward to having a Sentry guide, and thank you for contributing to docs! 🥳

sorry i opened the preview, and sanity checked it with a colleague earlier this week, then got totally distracted. Thank you for pushing it through!

We agreed it look great thanks for all your contribution :)

thomasbnt added a commit to thomasbnt/docs that referenced this pull request Jun 25, 2024
yanthomasdev added a commit that referenced this pull request Jun 25, 2024
* i18n(fr): Update guides/astro-db from #8478

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/backend from #8450

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/backend/google-firebase from #8422

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/cms/apostrophecms from #8480

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/cms/builderio from #8259

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/cms/directus from #8647

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/cms/ghost from #8518

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/cms/statamic from #7119

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/content-collections from #8447

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/data-fetching from #8210

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/deploy/cloudflare from #8421

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/deploy/netlify from #8233

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/deploy/render from #8233

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/deploy/vercel from #8217 (and fix little typos)

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/environment-variables from #8533

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/environment-variables from #8611

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/images from #8447 #8646

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide from #8575

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/cloudflare from #8211

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/lit from #8270

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/markdoc from #8167 (Steeeeps)

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/preact from #8644

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/react from #8038

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/vue from #8295

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/markdown-content from #7218

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/markdown-content from #8167 #8239

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/middleware from #8572

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/prefetch from #8246

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/routing from #8466

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/rss from #8632

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/testing from #8369

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/view-transitions from #8646

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix typo in routing.mdx

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix links ?

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix badge

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix badge

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix tabs

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix tabs

Signed-off-by: Thomas Bonnet <[email protected]>

* Update src/content/docs/fr/guides/environment-variables.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/integrations-guide/lit.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/integrations-guide/vue.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/markdown-content.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/middleware.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/testing.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/testing.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/testing.mdx

Co-authored-by: pioupia <[email protected]>

* i18n(fr): Fix links

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `tutorial/6-islands` because CI links err

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): fix links

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): fix links

Signed-off-by: Thomas Bonnet <[email protected]>

---------

Signed-off-by: Thomas Bonnet <[email protected]>
Co-authored-by: pioupia <[email protected]>
Co-authored-by: Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd-party guide Community submitted CMS, deploy, backend etc. guide add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Docs is happy if OP is happy! Please review your PR and make sure you accept our proposed changes! Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants