Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve nodes description in React integrations docs #8038

Merged
merged 4 commits into from
May 3, 2024
Merged

Improve nodes description in React integrations docs #8038

merged 4 commits into from
May 3, 2024

Conversation

oscarvz
Copy link
Contributor

@oscarvz oscarvz commented Apr 27, 2024 •
edited
Loading

Description (required)

Just a fix for a typo I came across when reading the React integrations docs!

@vercel Vercel
Copy link

vercel bot commented Apr 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 3, 2024 8:33pm

@oscarvz oscarvz changed the title Fix typo in React integration docs Fix typo in React integrations docs Apr 27, 2024
@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Apr 27, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/integrations-guide/react.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

sarah11918
sarah11918 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting, and coming here to fix, this typo @oscarvz ! We appreciate that you took the time to contribute, and are happy to welcome you to Team Docs! 🥳

@sarah11918 sarah11918 added typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Apr 30, 2024
@yanthomasdev yanthomasdev added help - confirm behaviour Walk through the example/issue and confirm this is a general behaviour, or a correct update to make. and removed Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Apr 30, 2024
@yanthomasdev
Copy link
Member

yanthomasdev commented Apr 30, 2024 •
edited
Loading

Thanks @oscarvz, I'll give this some time for someone who knows the internals of the React integration since the intention might've been to really talk about vnodes, i.e. Virtual DOM Nodes, so despite it sounding like a typo, it might not really be one.

@oscarvz oscarvz changed the title Fix typo in React integrations docs Improve nodes description in React integrations docs May 2, 2024
@sarah11918
Copy link
Member

Looking great now @oscarvz ! Thanks for sticking with us while we got everything straightened out, and again, welcome to Team Docs! 🥳

@sarah11918 sarah11918 merged commit b7d1656 into withastro:main May 3, 2024
8 checks passed
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 4, 2024
@oscarvz @yanthomasdev
@sarah11918 @wpplumber
Improve nodes description in React integrations docs (withastro#8038)
ca51de3 
Co-authored-by: Yan <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
@liruifengv liruifengv mentioned this pull request May 7, 2024
Merged
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 9, 2024
@oscarvz @yanthomasdev
@sarah11918 @wpplumber
Improve nodes description in React integrations docs (withastro#8038)
35e10f2 
Co-authored-by: Yan <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@oscarvz @yanthomasdev
@sarah11918 @wpplumber
Improve nodes description in React integrations docs (withastro#8038)
fd62e11 
Co-authored-by: Yan <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@oscarvz @yanthomasdev
@sarah11918 @wpplumber
Improve nodes description in React integrations docs (withastro#8038)
fc3a410 
Co-authored-by: Yan <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
@jsparkdev jsparkdev mentioned this pull request May 16, 2024
Merged
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Jun 25, 2024
@thomasbnt
i18n(fr): Update guides/integrations-guide/react from withastro#8038
c935501 
Signed-off-by: Thomas Bonnet <[email protected]>
@thomasbnt thomasbnt mentioned this pull request Jun 25, 2024
Merged
yanthomasdev added a commit that referenced this pull request Jun 25, 2024
@thomasbnt @pioupia @yanthomasdev
i18n(fr): Update all Guides files in French language (june 25) (#8673)
94b7a24 
* i18n(fr): Update guides/astro-db from #8478

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/backend from #8450

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/backend/google-firebase from #8422

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/cms/apostrophecms from #8480

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/cms/builderio from #8259

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/cms/directus from #8647

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/cms/ghost from #8518

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/cms/statamic from #7119

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/content-collections from #8447

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/data-fetching from #8210

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/deploy/cloudflare from #8421

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/deploy/netlify from #8233

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/deploy/render from #8233

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/deploy/vercel from #8217 (and fix little typos)

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/environment-variables from #8533

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/environment-variables from #8611

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/images from #8447 #8646

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide from #8575

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/cloudflare from #8211

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/lit from #8270

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/markdoc from #8167 (Steeeeps)

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/preact from #8644

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/react from #8038

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/vue from #8295

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/markdown-content from #7218

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/markdown-content from #8167 #8239

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/middleware from #8572

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/prefetch from #8246

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/routing from #8466

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/rss from #8632

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/testing from #8369

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/view-transitions from #8646

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix typo in routing.mdx

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix links ?

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix badge

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix badge

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix tabs

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix tabs

Signed-off-by: Thomas Bonnet <[email protected]>

* Update src/content/docs/fr/guides/environment-variables.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/integrations-guide/lit.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/integrations-guide/vue.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/markdown-content.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/middleware.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/testing.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/testing.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/testing.mdx

Co-authored-by: pioupia <[email protected]>

* i18n(fr): Fix links

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `tutorial/6-islands` because CI links err

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): fix links

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): fix links

Signed-off-by: Thomas Bonnet <[email protected]>

---------

Signed-off-by: Thomas Bonnet <[email protected]>
Co-authored-by: pioupia <[email protected]>
Co-authored-by: Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanthomasdev yanthomasdev yanthomasdev left review comments

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
help - confirm behaviour Walk through the example/issue and confirm this is a general behaviour, or a correct update to make. typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oscarvz @astrobot-houston @yanthomasdev @sarah11918