Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS guide: Use new URL() instead of template literal #8632

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

evadecker
Copy link
Contributor

@evadecker evadecker commented Jun 22, 2024

Description (required)

The RSS guide currently uses a template literal to concatenate rss.xml and Astro.site. This works without issue when the site is built, but it raises an ESLint warning:

image

This PR updates the guide to recommend the safer URL() constructor to create the link to the rss.xml file.

Copy link

vercel bot commented Jun 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jun 24, 2024 1:38pm

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jun 22, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/rss.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jun 22, 2024
Copy link
Member

@at-the-vr at-the-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR Eva 🙌 and thank you for covering all locales as well

@at-the-vr at-the-vr added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Jun 23, 2024
@Fryuni Fryuni changed the title RSS guide: Use new URL() instead of template literal RSS guide: Use new URL() instead of template literal [i18nIgnore] Jun 23, 2024
@sarah11918 sarah11918 removed the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Jun 24, 2024
@sarah11918
Copy link
Member

Hi @evadecker , thanks so much for providing this!

Because of our translation status tracking, however, we do ask that PRs only be submitted in one language, then we let the translators catch up. Some of these pages might be out of date translations, some not. Someone might be working on updating a page at the moment! So, it's always easiest for us to only accept English versions of fixes, even when it looks like it should just be a simple fix across the board.

When you remove the other language files, we can get this merged! 🙌

@at-the-vr at-the-vr changed the title RSS guide: Use new URL() instead of template literal [i18nIgnore] RSS guide: Use new URL() instead of template literal Jun 24, 2024
@github-actions github-actions bot removed the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jun 24, 2024
@evadecker
Copy link
Contributor Author

Hi @evadecker , thanks so much for providing this!

Because of our translation status tracking, however, we do ask that PRs only be submitted in one language, then we let the translators catch up. Some of these pages might be out of date translations, some not. Someone might be working on updating a page at the moment! So, it's always easiest for us to only accept English versions of fixes, even when it looks like it should just be a simple fix across the board.

When you remove the other language files, we can get this merged! 🙌

No worries, updated!

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@yanthomasdev yanthomasdev merged commit 3ca4c84 into withastro:main Jun 24, 2024
8 checks passed
@evadecker evadecker deleted the patch-1 branch June 24, 2024 13:42
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Jun 25, 2024
yanthomasdev added a commit that referenced this pull request Jun 25, 2024
* i18n(fr): Update guides/astro-db from #8478

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/backend from #8450

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/backend/google-firebase from #8422

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/cms/apostrophecms from #8480

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/cms/builderio from #8259

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/cms/directus from #8647

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/cms/ghost from #8518

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/cms/statamic from #7119

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/content-collections from #8447

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/data-fetching from #8210

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/deploy/cloudflare from #8421

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/deploy/netlify from #8233

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/deploy/render from #8233

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/deploy/vercel from #8217 (and fix little typos)

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/environment-variables from #8533

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/environment-variables from #8611

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/images from #8447 #8646

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide from #8575

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/cloudflare from #8211

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/lit from #8270

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/markdoc from #8167 (Steeeeps)

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/preact from #8644

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/react from #8038

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/integrations-guide/vue from #8295

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/markdown-content from #7218

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/markdown-content from #8167 #8239

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/middleware from #8572

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/prefetch from #8246

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/routing from #8466

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/rss from #8632

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/testing from #8369

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update guides/view-transitions from #8646

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix typo in routing.mdx

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix links ?

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix badge

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix badge

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix tabs

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix tabs

Signed-off-by: Thomas Bonnet <[email protected]>

* Update src/content/docs/fr/guides/environment-variables.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/integrations-guide/lit.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/integrations-guide/vue.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/markdown-content.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/middleware.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/testing.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/testing.mdx

Co-authored-by: pioupia <[email protected]>

* Update src/content/docs/fr/guides/testing.mdx

Co-authored-by: pioupia <[email protected]>

* i18n(fr): Fix links

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `tutorial/6-islands` because CI links err

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): fix links

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): fix links

Signed-off-by: Thomas Bonnet <[email protected]>

---------

Signed-off-by: Thomas Bonnet <[email protected]>
Co-authored-by: pioupia <[email protected]>
Co-authored-by: Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants