Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print newest_ckpt_path when resuming trial. #26561

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Print newest_ckpt_path when resuming trial. #26561

merged 1 commit into from
Jul 15, 2022
+1 −0

Conversation

michalsustr
Copy link
Contributor

Why are these changes needed?

When trail is resumed, it is useful for the user to know from which checkpoint it happened.

Related issue number

N/A

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

krfricke
krfricke approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krfricke krfricke merged commit ca3d272 into ray-project:master Jul 15, 2022
truelegion47 pushed a commit to truelegion47/ray that referenced this pull request Jul 16, 2022
Merge branch 'master' into ISSUE-23166
9b56323 
* master: (35 commits)
  [data] Refactor all to all op implementations into a separate file (ray-project#26585)
  [Datasets] Explicitly define Dataset-like APIs in DatasetPipeline class (ray-project#26394)
  [Serve][Part2] Migrate the tests to use deployment graph api (ray-project#26507)
  [Serve] Default to EveryNode when starting Serve from REST API (ray-project#26588)
  Revert "[KubeRay][Autoscaler][Core] Add a flag to disable ray status version check (ray-project#26584)" (ray-project#26597)
  [air] Add initial benchmark section (ray-project#26608)
  [Workflow] Remove workflow execution module (ray-project#26504)
  [air] Add xgboost release test for silver tier(10-node case). (ray-project#26460)
  Revert "Revert "[serve] Use soft constraint for pinning controller on head node (ray-project#25091)" (ray-project#25857)" (ray-project#25858)
  [RLlib] Fixes MARWIL release tests (ray-project#26586)
  [Datasets] Improve read_xxx experience of HTTP file (ray-project#26454)
  Cleanup ActorContext due to multi actor instances got removed. (ray-project#26497)
  Print newest_ckpt_path when resuming trial. (ray-project#26561)
  Fix test_serialization_error_message for pytest 6.x (ray-project#26591)
  [RLlib] Make DQN update_target use only trainable variables. (ray-project#25226)
  [RLlib] In env check, step only expected agents. (ray-project#26425)
  [RLlib] `restart_failed_sub_environments` now works for MA cases and crashes during `reset()`; +more tests and logging; add eval worker sub-env fault tolerance test. (ray-project#26276)
  [runtime env] plugin refactor[4/n]: remove runtime env protobuf (ray-project#26522)
  Improve streaming read performance for default configuration. (ray-project#26587)
  [Dashboard] Fix test dashboard flaky by catch an expected exception (ray-project#26555)
  ...
truelegion47 pushed a commit to truelegion47/ray that referenced this pull request Jul 16, 2022
@michalsustr @sustr-equi
Print newest_ckpt_path when resuming trial. (ray-project#26561)
07c61cc 
When trail is resumed, it is useful for the user to know from which checkpoint it happened.

Signed-off-by: sustr-equi <[email protected]>
Co-authored-by: sustr-equi <[email protected]>
Signed-off-by: Your Name <[email protected]>
xwjiang2010 pushed a commit to xwjiang2010/ray that referenced this pull request Jul 19, 2022
@michalsustr @sustr-equi @xwjiang2010
Print newest_ckpt_path when resuming trial. (ray-project#26561)
e1d6475 
When trail is resumed, it is useful for the user to know from which checkpoint it happened.

Signed-off-by: sustr-equi <[email protected]>
Co-authored-by: sustr-equi <[email protected]>
Signed-off-by: Xiaowei Jiang <[email protected]>
avnishn pushed a commit to smorad/ray that referenced this pull request Jul 20, 2022
@michalsustr @sustr-equi @avnishn
Print newest_ckpt_path when resuming trial. (ray-project#26561)
1f1a421 
When trail is resumed, it is useful for the user to know from which checkpoint it happened.

Signed-off-by: sustr-equi <[email protected]>
Co-authored-by: sustr-equi <[email protected]>
Signed-off-by: Avnish <[email protected]>
klwuibm pushed a commit to yuanchi2807/ray that referenced this pull request Jul 27, 2022
@michalsustr @sustr-equi @klwuibm
Print newest_ckpt_path when resuming trial. (ray-project#26561)
1165f70 
When trail is resumed, it is useful for the user to know from which checkpoint it happened.

Signed-off-by: sustr-equi <[email protected]>
Co-authored-by: sustr-equi <[email protected]>
Signed-off-by: klwuibm <[email protected]>
franklsf95 pushed a commit to franklsf95/ray that referenced this pull request Aug 2, 2022
@michalsustr @sustr-equi @franklsf95
Print newest_ckpt_path when resuming trial. (ray-project#26561)
eeaeb23 
When trail is resumed, it is useful for the user to know from which checkpoint it happened.

Signed-off-by: sustr-equi <[email protected]>
Co-authored-by: sustr-equi <[email protected]>
Signed-off-by: Frank Luan <[email protected]>
gramhagen pushed a commit to gramhagen/ray that referenced this pull request Aug 15, 2022
@michalsustr @sustr-equi
Print newest_ckpt_path when resuming trial. (ray-project#26561)
8f81d5b 
When trail is resumed, it is useful for the user to know from which checkpoint it happened.

Signed-off-by: sustr-equi <[email protected]>
Co-authored-by: sustr-equi <[email protected]>
Signed-off-by: Scott Graham <[email protected]>
gramhagen pushed a commit to gramhagen/ray that referenced this pull request Aug 15, 2022
@michalsustr @sustr-equi
Print newest_ckpt_path when resuming trial. (ray-project#26561)
febf92d 
When trail is resumed, it is useful for the user to know from which checkpoint it happened.

Signed-off-by: sustr-equi <[email protected]>
Co-authored-by: sustr-equi <[email protected]>
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
@michalsustr @sustr-equi
Print newest_ckpt_path when resuming trial. (ray-project#26561)
68dd498 
When trail is resumed, it is useful for the user to know from which checkpoint it happened.

Signed-off-by: sustr-equi <[email protected]>
Co-authored-by: sustr-equi <[email protected]>
Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krfricke krfricke krfricke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michalsustr @krfricke @sustr-equi