Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Default to EveryNode when starting Serve from REST API #26588

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

simon-mo
Copy link
Contributor

Why are these changes needed?

A small configuration change to enable better performance in production scenario, especially with K8s.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@brucez-anyscale
Copy link
Contributor

I do not have background knowledge for this pr.

Copy link
Contributor

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simon-mo we should also default to this for serve.run, right?

@simon-mo
Copy link
Contributor Author

simon-mo commented Jul 15, 2022

@simon-mo we should also default to this for serve.run, right?

Leaving that to @sihanwang41 when we deprecate serve.start.

@simon-mo simon-mo merged commit 63d3ccf into ray-project:master Jul 15, 2022
xwjiang2010 pushed a commit to xwjiang2010/ray that referenced this pull request Jul 19, 2022
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants