Revert "[KubeRay][Autoscaler][Core] Add a flag to disable ray status version check" #26597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishbone
approved these changes
Jul 15, 2022
|
Uh, would have appreciated getting tagged on that. Will work on a Re-revert. |
xwjiang2010
pushed a commit
to xwjiang2010/ray
that referenced
this pull request
Jul 19, 2022
…version check (ray-project#26584)" (ray-project#26597) Reverts ray-project#26584 Seems it breaking test_advanced_4 Signed-off-by: Xiaowei Jiang <[email protected]>
DmitriGekhtman
added a commit
to DmitriGekhtman/ray
that referenced
this pull request
Jul 19, 2022
… status version check (ray-project#26584)" (ray-project#26597)" This reverts commit fe9a12a. Signed-off-by: Dmitri Gekhtman <[email protected]>
DmitriGekhtman
added a commit
that referenced
this pull request
Jul 19, 2022
Rohan138
pushed a commit
to Rohan138/ray
that referenced
this pull request
Jul 28, 2022
* Revert "Revert "[KubeRay][Autoscaler][Core] Add a flag to disable ray status version check (ray-project#26584)" (ray-project#26597)" (Fixes test issue.) Signed-off-by: Rohan138 <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
…version check (ray-project#26584)" (ray-project#26597) Reverts ray-project#26584 Seems it breaking test_advanced_4 Signed-off-by: Stefan van der Kleij <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
* Revert "Revert "[KubeRay][Autoscaler][Core] Add a flag to disable ray status version check (ray-project#26584)" (ray-project#26597)" (Fixes test issue.) Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #26584
Seems it breaking test_advanced_4