-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "[serve] Use soft constraint for pinning controller on head node (#25091)" (#25857)" #25858
Conversation
FYI @iycheng had to get reverted again :( |
9ac26f7
to
084e68d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving because it looks like code owners review needed from each team
Signed-off-by: Edward Oakes <[email protected]>
7602aed
to
e2f4593
Compare
@avnishn I ended up in git hell trying to fix the DCO and accidentally requested review from the global population. Should be fixed now. Thanks for the stamp. |
Dude same thing happened to me yesterday LOL |
* master: (35 commits) [data] Refactor all to all op implementations into a separate file (ray-project#26585) [Datasets] Explicitly define Dataset-like APIs in DatasetPipeline class (ray-project#26394) [Serve][Part2] Migrate the tests to use deployment graph api (ray-project#26507) [Serve] Default to EveryNode when starting Serve from REST API (ray-project#26588) Revert "[KubeRay][Autoscaler][Core] Add a flag to disable ray status version check (ray-project#26584)" (ray-project#26597) [air] Add initial benchmark section (ray-project#26608) [Workflow] Remove workflow execution module (ray-project#26504) [air] Add xgboost release test for silver tier(10-node case). (ray-project#26460) Revert "Revert "[serve] Use soft constraint for pinning controller on head node (ray-project#25091)" (ray-project#25857)" (ray-project#25858) [RLlib] Fixes MARWIL release tests (ray-project#26586) [Datasets] Improve read_xxx experience of HTTP file (ray-project#26454) Cleanup ActorContext due to multi actor instances got removed. (ray-project#26497) Print newest_ckpt_path when resuming trial. (ray-project#26561) Fix test_serialization_error_message for pytest 6.x (ray-project#26591) [RLlib] Make DQN update_target use only trainable variables. (ray-project#25226) [RLlib] In env check, step only expected agents. (ray-project#26425) [RLlib] `restart_failed_sub_environments` now works for MA cases and crashes during `reset()`; +more tests and logging; add eval worker sub-env fault tolerance test. (ray-project#26276) [runtime env] plugin refactor[4/n]: remove runtime env protobuf (ray-project#26522) Improve streaming read performance for default configuration. (ray-project#26587) [Dashboard] Fix test dashboard flaky by catch an expected exception (ray-project#26555) ...
… head node (ray-project#25091)" (ray-project#25857)" (ray-project#25858) Signed-off-by: Your Name <[email protected]>
… head node (ray-project#25091)" (ray-project#25857)" (ray-project#25858) Signed-off-by: Xiaowei Jiang <[email protected]>
… head node (ray-project#25091)" (ray-project#25857)" (ray-project#25858) Signed-off-by: Avnish <[email protected]>
… head node (ray-project#25091)" (ray-project#25857)" (ray-project#25858) Signed-off-by: klwuibm <[email protected]>
… head node (ray-project#25091)" (ray-project#25857)" (ray-project#25858) Signed-off-by: Frank Luan <[email protected]>
… head node (ray-project#25091)" (ray-project#25857)" (ray-project#25858) Signed-off-by: Scott Graham <[email protected]>
… head node (ray-project#25091)" (ray-project#25857)" (ray-project#25858) Signed-off-by: Stefan van der Kleij <[email protected]>
This reverts commit e435230.
Why are these changes needed?
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.