[RLlib] Fixes MARWIL release tests #26586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
sven1977
approved these changes
Jul 15, 2022
|
so this pr fixes learning tests f-z and #26581 potentially fixes learning tests a-e, or a-e is flaky and requires more debugging. Nonetheless this pr fixes a deterministic bug in f-z, we should merge ASAP |
avnishn
approved these changes
Jul 15, 2022
richardliaw
reviewed
Jul 15, 2022
| @@ -25,4 +25,5 @@ marwil-halfcheetahbulletenv-v0: | |||
| evaluation_interval: 3 | |||
| evaluation_config: | |||
| input: sampler | |||
| off_policy_estimation_methods: | |||
There was a problem hiding this comment.
can you put something like null instead of leaving it blank?
There was a problem hiding this comment.
Its my understanding that we have to leave it blank in order for it to map to None unfortunately with the way that our YAML is processed.
xwjiang2010
pushed a commit
to xwjiang2010/ray
that referenced
this pull request
Jul 19, 2022
Signed-off-by: Xiaowei Jiang <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
MARWIL release tests are broken because OPE is enabled by default, requiring action distributions to be present in our offline data, which they are not for the previously collected SAC file.
Related issue number
#26579
Checks
scripts/format.shto lint the changes in this PR.