Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smith and Rune Iron 165R2 Refactor #18552

Merged
merged 11 commits into from
Sep 30, 2022
Merged

Smith and Rune Iron 165R2 Refactor #18552

merged 11 commits into from
Sep 30, 2022

Conversation

noroadsleft
Copy link
Member

Description

  • implement proper LAYOUT_all (existing LAYOUT macro is not physically arranged)
  • add four new layout macros (65% Blocker layouts in ANSI and ISO, with and without top-right corner blocker)
  • refactor keymaps (use short-form aliases; update grid alignment)

cc @Gondolindrim (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft
iron165r2.h: add matrix diagram
983d186
@noroadsleft
info.json: add layout data
3db4626
@noroadsleft
add LAYOUT_all
a239e53 
Same positions as `LAYOUT`, but physically arranged per QMK standards.
@noroadsleft
refactor keymaps, phase 1
506bbbc 
- use QMK-native short-form keycode aliases
  - KC_ENTER -> KC_ENT
  - KC_LCTRL -> KC_LCTL
- update keycode grid alignment
@noroadsleft
refactor keymaps, phase 2
b775378 
Refactor keymaps to use `LAYOUT_all` macro.

Position K4E (Delete) moves from the end of the bottom row to the end of the top row.
@noroadsleft
remove now-unused LAYOUT macro
6e0bd24
@noroadsleft
add LAYOUT_65_ansi_blocker
89a1fb5
@noroadsleft
add LAYOUT_65_ansi_cb_blocker
1f8efcd
@noroadsleft
add LAYOUT_65_iso_blocker
c84a8c0
@noroadsleft
add LAYOUT_65_iso_cb_blocker
6d92749
@noroadsleft
info.json: correct maintainer value
d0300a0
@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Sep 30, 2022
@noroadsleft noroadsleft requested a review from a team September 30, 2022 20:38
@fauxpark fauxpark requested a review from a team September 30, 2022 20:39
@keyboard-magpie keyboard-magpie merged commit dfa5880 into qmk:master Sep 30, 2022
@noroadsleft noroadsleft deleted the rf/smithrune_iron165r2 branch October 3, 2022 08:40
quinnyo pushed a commit to quinnyo/qmk_firmware that referenced this pull request Oct 21, 2022
@noroadsleft @quinnyo
Smith and Rune Iron 165R2 Refactor (qmk#18552)
e374e9a 
by noroadsleft
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@noroadsleft
Smith and Rune Iron 165R2 Refactor (qmk#18552)
489050f 
by noroadsleft
tim-bennett83 pushed a commit to tim-bennett83/qmk_firmware that referenced this pull request Nov 9, 2022
Merge tag '0.18.9'
56f9ca8 
* tag '0.18.9': (558 commits)
  `:flash`: print bootloader (qmk#18569)
  Add `tzarc/ghoul`. (qmk#18562)
  [Keyboard] Add Uni v4 keyboard (qmk#18280)
  [Keyboard] Add waffling60 Rev D ISO Hotswap (qmk#18372)
  Remove more RESET keycode references (qmk#18559)
  Djinn theme, allow force redraws (qmk#18558)
  onekey: fix quine keymap (qmk#18555)
  [Keyboard] Add Little Big Scroll 4  macropad  (qmk#18516)
  [Keymap] corne layout with mac/linux text editing shortcuts (qmk#18374)
  Fixup keebio/sinc (qmk#18551)
  Smith and Rune Iron 165R2 Refactor (qmk#18552)
  Forrcaho foldkb caps lock blink (qmk#17424)
  [Keyboard] handwired/tractyl_manuform: Arduino Micro (qmk#17199)
  [Keyboard] Add nightstar75 (qmk#18546)
  Rotary encoder setting is revised to solve a malfunction. (qmk#18227)
  Add Unicomp PC122 keyboard (qmk#18326)
  AceVice One's keymap for Kyria keyboard (qmk#18393)
  [Keyboard] Add mini42 (qmk#18491)
  [Keyboard] Add saevus cor (qmk#18368)
  [Keyboard] Fix tklfrlnrlmlao layout (qmk#18543)
  ...
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@noroadsleft @ramonimbao
Smith and Rune Iron 165R2 Refactor (qmk#18552)
3e70dc7 
by noroadsleft
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@noroadsleft @nolanseaton
Smith and Rune Iron 165R2 Refactor (qmk#18552)
b8561fe 
by noroadsleft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@keyboard-magpie keyboard-magpie keyboard-magpie approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@noroadsleft @fauxpark @keyboard-magpie