Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corne layout with mac/linux text editing shortcuts #18374

Merged
merged 9 commits into from
Sep 30, 2022

Conversation

nimishgautam
Copy link
Contributor

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • [ x] Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [ x] My code follows the code style of this project: C, Python
  • [ x] I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Contributor

@spidey3 spidey3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add GPLv2-compatible copyright notices, as described at https://docs.qmk.fm/#/pr_checklist?id=example-gplv2-header.

keyboards/crkbd/keymaps/nimishgautam/config.h Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/nimishgautam/README.md Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/nimishgautam/keymap.c Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/nimishgautam/rules.mk Outdated Show resolved Hide resolved
@nimishgautam
Copy link
Contributor Author

Made changes according to code review :)

@nimishgautam nimishgautam requested review from drashna and removed request for spidey3 September 25, 2022 11:29
keyboards/crkbd/keymaps/nimishgautam/rules.mk Outdated Show resolved Hide resolved
SPACE_CADET_ENABLE = no
SPLIT_KEYBOARD = yes
#WPM_ENABLE = yes
#CAPS_WORD_ENABLE = yes # if you hold down both shifts, you get lshift enabled for 1 word, but only works with KC shift, not MOD shift :(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mod shift?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, when I tested it with my keyboard, it worked fine if you hold down 2 keys that send KC_LSFT and KC_RSFT respectfully but it did NOT work when the keys send something like MT(MOD_LSFT, ...) , MT(MOD_RSFT, ...) , So, it seems to work for the KC shifts but not the MOD shifts. Not sure if there's a better way to word that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aah, okay, this is due to mod tap using weak mods, and caps words not checking weak mods. That ... is actually a simple fix.

const uint8_t mods = get_mods() | get_oneshot_mods();
#else
const uint8_t mods = get_mods();

Changing that would allow for weak mods to be checked. However, it has the caveat of shifted keycodes (eg LSFT(kc)) will also be able to trigger it.

@drashna drashna merged commit 3db33fb into qmk:master Sep 30, 2022
quinnyo pushed a commit to quinnyo/qmk_firmware that referenced this pull request Oct 21, 2022
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants