-
-
Notifications
You must be signed in to change notification settings - Fork 39.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
corne layout with mac/linux text editing shortcuts #18374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please add GPLv2-compatible copyright notices, as described at https://docs.qmk.fm/#/pr_checklist?id=example-gplv2-header.
Made changes according to code review :) |
SPACE_CADET_ENABLE = no | ||
SPLIT_KEYBOARD = yes | ||
#WPM_ENABLE = yes | ||
#CAPS_WORD_ENABLE = yes # if you hold down both shifts, you get lshift enabled for 1 word, but only works with KC shift, not MOD shift :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mod shift?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, when I tested it with my keyboard, it worked fine if you hold down 2 keys that send KC_LSFT
and KC_RSFT
respectfully but it did NOT work when the keys send something like MT(MOD_LSFT, ...)
, MT(MOD_RSFT, ...)
, So, it seems to work for the KC
shifts but not the MOD
shifts. Not sure if there's a better way to word that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aah, okay, this is due to mod tap using weak mods, and caps words not checking weak mods. That ... is actually a simple fix.
qmk_firmware/quantum/process_keycode/process_caps_word.c
Lines 26 to 28 in 245f00b
const uint8_t mods = get_mods() | get_oneshot_mods(); | |
#else | |
const uint8_t mods = get_mods(); |
Changing that would allow for weak mods to be checked. However, it has the caveat of shifted keycodes (eg LSFT(kc)
) will also be able to trigger it.
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist