Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tzarc/ghoul. #18562

Merged
merged 8 commits into from
Oct 2, 2022
Merged

Add tzarc/ghoul. #18562

merged 8 commits into from
Oct 2, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Oct 1, 2022 •
edited
Loading

Description

As per the title.

PID/VID combo is valid: https://pid.codes/1209/4920/

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team October 1, 2022 22:23
@tzarc
Copy link
Member Author

tzarc commented Oct 1, 2022

CI build error is because qmk list-keyboards incorrectly detects the base folder as a keyboard due to the presence of rules.mk.

@tzarc
Copy link
Member Author

tzarc commented Oct 1, 2022

Needs a readme.md. Incoming.

zvecr
zvecr requested changes Oct 2, 2022
View reviewed changes
keyboards/tzarc/ghoul/ghoul.h Outdated Show resolved Hide resolved
keyboards/tzarc/ghoul/info.json Outdated Show resolved Hide resolved
keyboards/tzarc/ghoul/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tzarc/ghoul/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tzarc/ghoul/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tzarc/ghoul/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tzarc/ghoul/readme.md Outdated Show resolved Hide resolved
keyboards/tzarc/ghoul/readme.md Outdated Show resolved Hide resolved
@tzarc tzarc requested review from zvecr and a team October 2, 2022 00:13
drashna
drashna requested changes Oct 2, 2022
View reviewed changes
keyboards/tzarc/ghoul/readme.md Outdated Show resolved Hide resolved
@tzarc tzarc merged commit 9ecd6eb into qmk:master Oct 2, 2022
@tzarc tzarc deleted the ghoul branch October 2, 2022 20:24
@tzarc tzarc added the hacktoberfest-accepted All the good issues to tackle during Hacktoberfest! label Oct 5, 2022
quinnyo pushed a commit to quinnyo/qmk_firmware that referenced this pull request Oct 21, 2022
@tzarc @zvecr
@drashna @quinnyo
Add tzarc/ghoul. (qmk#18562)
9ba2063 
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@tzarc @zvecr @drashna
Add tzarc/ghoul. (qmk#18562)
c6d8079 
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@tzarc @zvecr
@drashna @ramonimbao
Add tzarc/ghoul. (qmk#18562)
0be2ca9 
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@tzarc @zvecr
@drashna @nolanseaton
Add tzarc/ghoul. (qmk#18562)
c4050f9 
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna requested changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted All the good issues to tackle during Hacktoberfest! keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzarc @drashna @zvecr