Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup keebio/sinc #18551

Merged
merged 2 commits into from
Sep 30, 2022
Merged

Fixup keebio/sinc #18551

merged 2 commits into from
Sep 30, 2022

Conversation

waffle87
Copy link
Member

Description

  • rev1/config.h & rev2/config.h were identical — moved to root
  • bootloader was not defined in info.json
  • rev1/rev1.c & rev2/rev2.c were identical — moved to root
  • no license header in sinc.h

Types of Changes

  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team September 30, 2022 20:36
@zvecr zvecr merged commit 245f00b into qmk:master Sep 30, 2022
@waffle87 waffle87 deleted the fix/sinc branch September 30, 2022 22:13
quinnyo pushed a commit to quinnyo/qmk_firmware that referenced this pull request Oct 21, 2022
@waffle87 @quinnyo
Fixup keebio/sinc (qmk#18551)
2fc6397
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@waffle87
Fixup keebio/sinc (qmk#18551)
4c85933
tim-bennett83 pushed a commit to tim-bennett83/qmk_firmware that referenced this pull request Nov 9, 2022
Merge tag '0.18.9'
56f9ca8 
* tag '0.18.9': (558 commits)
  `:flash`: print bootloader (qmk#18569)
  Add `tzarc/ghoul`. (qmk#18562)
  [Keyboard] Add Uni v4 keyboard (qmk#18280)
  [Keyboard] Add waffling60 Rev D ISO Hotswap (qmk#18372)
  Remove more RESET keycode references (qmk#18559)
  Djinn theme, allow force redraws (qmk#18558)
  onekey: fix quine keymap (qmk#18555)
  [Keyboard] Add Little Big Scroll 4  macropad  (qmk#18516)
  [Keymap] corne layout with mac/linux text editing shortcuts (qmk#18374)
  Fixup keebio/sinc (qmk#18551)
  Smith and Rune Iron 165R2 Refactor (qmk#18552)
  Forrcaho foldkb caps lock blink (qmk#17424)
  [Keyboard] handwired/tractyl_manuform: Arduino Micro (qmk#17199)
  [Keyboard] Add nightstar75 (qmk#18546)
  Rotary encoder setting is revised to solve a malfunction. (qmk#18227)
  Add Unicomp PC122 keyboard (qmk#18326)
  AceVice One's keymap for Kyria keyboard (qmk#18393)
  [Keyboard] Add mini42 (qmk#18491)
  [Keyboard] Add saevus cor (qmk#18368)
  [Keyboard] Fix tklfrlnrlmlao layout (qmk#18543)
  ...
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@waffle87 @ramonimbao
Fixup keebio/sinc (qmk#18551)
9b2b472
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@waffle87 @nolanseaton
Fixup keebio/sinc (qmk#18551)
9f322ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@waffle87 @fauxpark @zvecr